1264683 - [rep tests] Add tests for function rep

Status: RESOLVED FIXED

(DevTools :: Shared Components, enhancement, P1)

Description

[Lin Clark [:linclark]]

See Bug 1257552

Comment 1

[Lin Clark [:linclark]]

Attachment: Bug1264683.patch

I'm planning to consolidate the restRenderingInMode between the grips test and this one, but just posting a patch without that consolidation for now.

Comment 2

[Lin Clark [:linclark]]

Attachment: Bug1264683.patch

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8764610 [details] [diff] [review]
Bug1264683.patch

Review of attachment 8764610 [details] [diff] [review]:
-----------------------------------------------------------------

Just one comment, please fix. Otherwise looks good and it's passing for me. R+

Thanks!

Honza

::: devtools/client/shared/components/test/mochitest/test_reps_function.html
@@ +110,5 @@
> +          "extensible": true,
> +          "frozen": false,
> +          "sealed": false,
> +          "name": "testName",
> +          "displayName": "testName",

Note that `displayName` has higher priority over `name` and should be always used if available (e.g. also in stack frames etc.). You could change the `name` value here to something else than `testName` to test it.

Honza

Comment 4

[Lin Clark [:linclark]]

Do you know in what cases you would get a grip that has a different name and display name?

When I do this in the console, it returns a grip with the same name/displayName:

>let foo = function testName(){ let innerVar = "foo" }
>foo

Comment 5

[Lin Clark [:linclark]]

Discussed with Honza in the meeting. It turns out the displayName can be manually altered, but in our grips we use userDisplayName to hold this value, not displayName. Added Bug 1282427 to handle this. For now, the test will be committed as is.

Comment 6

[Lin Clark [:linclark]]

Attachment: Bug1264683.patch

Rebased to resolve collision in chrome.ini

Comment 7

[Carsten Book [:Tomcat]]

Hi Lin, 

this seems to have problems again

Hunk #3 FAILED at 90
Hunk #4 FAILED at 120
2 out of 6 hunks FAILED -- saving rejects to file devtools/client/shared/components/test/mochitest/test_reps_grip.html.rej

maybe because of https://bugzilla.mozilla.org/show_bug.cgi?id=1281489

Comment 8

[Lin Clark [:linclark]]

Attachment: Bug1264683.patch

Rebased again, so hopefully works now

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/c2cfdd905fdc
[rep tests] Add tests for function rep. r=Honza

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c2cfdd905fdc