1268477 - build/webapp-shared.js does not handle resources anymore

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[:gerard-majax]

This is expected fallout from moving to chrome.

Comment 1

[:gerard-majax]

Attachment: bogus transition profile

Comment 2

[:gerard-majax]

Attachment: expected output within system app

Comment 3

[Pochy]

I take a look around the problem here and I think is related with the relative path, right?

https://github.com/mozilla-b2g/gaia/pull/34278

I created the PR but I cant not understand if in the treeherder is fine or wrong, can you mentoring me in my first bug?

Comment 4

[:gerard-majax]

(In reply to Pochy from comment #3)
> I take a look around the problem here and I think is related with the
> relative path, right?
> 
> https://github.com/mozilla-b2g/gaia/pull/34278
> 
> I created the PR but I cant not understand if in the treeherder is fine or
> wrong, can you mentoring me in my first bug?

Sure, thanks for sending this PR ! The first thing you should fix in your PR and in your patch is following the naming. I believe this is documented on the Contributing to gaia section of MDN, but to be quick: name the patch and PR as "Bug XXX - Short description r=YYY", with XXX being the bug number (so autolander can attach your PR to the bug) and YYY being the nickname of the reviewer.

Comment 5

[:gerard-majax]

It's hard to judge if your PR is helping just with the treeherder link, because so far all tests are broken. I am going to look at re-enabling some asserts I disabled in bug 1266756 and that you might (should) have fixed with your PR :)

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] pochy-ja:bug1268477 > mozilla-b2g:kanikani

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] lissyx:bug1268477 > mozilla-b2g:kanikani

Comment 8

[:gerard-majax]

Right, so the real issue is that your patch is not enough :). In bug 1254281 I have removed the execution of webapp-shared since it was running per-app. We need to re-add the execution and make it global now.

Comment 9

[:gerard-majax]

I have added some more patches on my own PR: https://github.com/mozilla-b2g/gaia/pull/34280

But I think it is still not enough to get everything good :/

Comment 10

[:gerard-majax]

Aus, can you have a look at my PR? It seems to be fixing the remains, but I think multilocale is broken and not easy to fix.

Comment 11

[Pochy]

(In reply to Alexandre LISSY :gerard-majax from comment #4)
> (In reply to Pochy from comment #3)
> > I take a look around the problem here and I think is related with the
> > relative path, right?
> > 
> > https://github.com/mozilla-b2g/gaia/pull/34278
> > 
> > I created the PR but I cant not understand if in the treeherder is fine or
> > wrong, can you mentoring me in my first bug?
> 
> Sure, thanks for sending this PR ! The first thing you should fix in your PR
> and in your patch is following the naming. I believe this is documented on
> the Contributing to gaia section of MDN, but to be quick: name the patch and
> PR as "Bug XXX - Short description r=YYY", with XXX being the bug number (so
> autolander can attach your PR to the bug) and YYY being the nickname of the
> reviewer.

OK, sorry, I read this in MDN but I was confused, with if it was in the commit message or in the title of the PR, I have this for next bug.

(In reply to Alexandre LISSY :gerard-majax from comment #8)
> Right, so the real issue is that your patch is not enough :). In bug 1254281
> I have removed the execution of webapp-shared since it was running per-app.
> We need to re-add the execution and make it global now.

OK, I missed that. Thanks

(In reply to Alexandre LISSY :gerard-majax from comment #9)
> I have added some more patches on my own PR:
> https://github.com/mozilla-b2g/gaia/pull/34280
> 
> But I think it is still not enough to get everything good :/


OK, I take a look around the new information you show to us but maybe Aus is more precise in what happens with multilocale.

Comment 12

[Aus Lacroix [:aus]]

Ugh, wish I had something more useful to say here but your guess is as good as mine. I've never had to deal with those bits of the build system. :(

Comment 13

[Pochy]

I tried something new in my PR thinking that the problem is the path to file to language, but I think the new test on treeherder is worse, I cant not understand what is the real problem with multilocale.

Alex, what do you think, what is the real problem here? or what we are ignoring here?

Comment 14

[:gerard-majax]

I have no idea how this is supposed to be working.

Comment 15

[Ricky Chien [:rickychien] (inactive)]

What's the problem you're running into? I can't catch your problem on comment 13, could you elaborate more?

Comment 16

[:gerard-majax]

Ricky, the issue is exposed in attachment 8746512 [details] and attachment 8746513 [details]

Comment 17

[Ricky Chien [:rickychien] (inactive)]

Try to understand issue on descriptions and attachments, I guess you're missing shared/resources/ after packaging?

I'm going to look into your PR and build system changes during transition plan right now. Please correct me if above part is wrong.

Comment 18

[Ricky Chien [:rickychien] (inactive)]

I guess Pochy has caught issue that probably relative path relate.

https://github.com/mozilla-b2g/gaia/blob/master/build/utils-xpc.js#L149-L154

In build/webapp-shared.js, resolving parent path by "../xxx" build/webapp-shared.js doesn't support this path resolve well. Try to solve this path issue by wrapping path with utils.resolve('../xxx').

Lots of build system issues can be figured out by console.log(fullTargetPath). For instance, you can insert console.log to verify output path after https://github.com/pochy-ja/gaia/blob/4a8bd9130fe4867bdee980e4086c4c4234eb17fc/build/webapp-shared.js#L48
to find out what's going on.

Comment 19

[BMO Automation]

Firefox OS is not being worked on