1271241 - Port Bug 1223728 - Remove the unifiedcomplete pref and the urlinline component to suite

Status: RESOLVED FIXED

(SeaMonkey :: Autocomplete, defect)

Description

[Frank-Rainer Grahl (:frg)]

Bug 1223728 removed the unifiedcomplete.manifest which results in an error during make installer.

Comment 1

[Frank-Rainer Grahl (:frg)]

Thunderbird and Instantbird also have this in the package-manifest.in. 

Is all which is needed to remove the manifest file from the installer? Seamonkey seem to still run ok afterwards. Is UnifiedComplete.js still used in c-c?

Comment 2

[Marco Bonardo [:mak]]

please check bug 995095

Note that I didn't remove the unifiedcomplete.manifest, I just moved its definitions inside toolkitplaces.manifest. What I removed (in Firefox) is nsPlacesAutocomplete.manifest, that is used in Seamonkey.

Comment 3

[Jorg K (CEST = GMT+2)]

I really know nothing about this. All I can do is use DXR and I see two references.

Comment 4

[Philip Chee]

> -                     autocompletesearch="urlinline history"
> +                     autocompletesearch="unifiedcomplete"
We don't use urlinline but we do use history (autocompletesearch="history"). Does unifiedcomplete subsume history? If so we could switch to it?

Comment 5

[Marco Bonardo [:mak]]

(In reply to Philip Chee from comment #4)
> > -                     autocompletesearch="urlinline history"
> > +                     autocompletesearch="unifiedcomplete"
> We don't use urlinline but we do use history (autocompletesearch="history").
> Does unifiedcomplete subsume history? If so we could switch to it?

As explained in bug 995095 you have 2 choices:
1. move the old nsPlacesAutocomplete in suite, and keep using "history". you'll have to maintain that code but there's less risk we break you with future changes.
2. move to unifiedcomplete, that also includes history. You should try if there's anything that disallows you to use it. I think if you disable autoFill in prefs, it should just work the same as old history query. But it needs some testing to be sure.

Comment 6

[Frank-Rainer Grahl (:frg)]

Attachment: package-manifest.in patch for suite

Fix just for build break in Seamonkey. Leave bug open for TB and Instantbird or close it and change heading?

Comment 7

[Philip Chee]

Comment on attachment 8750298 [details] [diff] [review]
package-manifest.in patch for suite

(In reply to Frank-Rainer Grahl from comment #6)
> Created attachment 8750298 [details] [diff] [review]
> package-manifest.in patch for suite
> 
> Fix just for build break in Seamonkey. Leave bug open for TB and Instantbird
> or close it and change heading?
1. Fix just for build break in Seamonkey, change summary, and close.
2. Open new bug fior TB && IB assuming they don't already know about it.

https://bugzilla.mozilla.org/buglist.cgi?chfieldto=Now&chfield=[Bug%20creation]&query_format=advanced&chfieldfrom=-28d&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=READY&bug_status=ASSIGNED&bug_status=REOPENED&product=Thunderbird

https://bugzilla.mozilla.org/buglist.cgi?chfieldto=Now&chfield=[Bug%20creation]&query_format=advanced&chfieldfrom=-28d&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=READY&bug_status=ASSIGNED&bug_status=REOPENED&product=MailNews Core

Comment 8

[Frank-Rainer Grahl (:frg)]

Checked in for suite. Will check later what the TB devs decided and close bug and/or open new ones if no additional patches shoule be added here.

https://hg.mozilla.org/comm-central/rev/aaf1cc259cf6

Comment 9

[Richard Marti (:Paenglab)]

Filed bug 1271338 for im and mail.

Comment 10

[Frank-Rainer Grahl (:frg)]

Oki. I am closing shop here.