Closed Bug 1271241 Opened 5 years ago Closed 5 years ago

Port Bug 1223728 - Remove the unifiedcomplete pref and the urlinline component to suite

Categories

(SeaMonkey :: Autocomplete, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: frg, Assigned: frg)

References

Details

Attachments

(1 file)

Bug 1223728 removed the unifiedcomplete.manifest which results in an error during make installer.
Thunderbird and Instantbird also have this in the package-manifest.in. 

Is all which is needed to remove the manifest file from the installer? Seamonkey seem to still run ok afterwards. Is UnifiedComplete.js still used in c-c?
Flags: needinfo?(philip.chee)
Flags: needinfo?(mozilla)
please check bug 995095

Note that I didn't remove the unifiedcomplete.manifest, I just moved its definitions inside toolkitplaces.manifest. What I removed (in Firefox) is nsPlacesAutocomplete.manifest, that is used in Seamonkey.
I really know nothing about this. All I can do is use DXR and I see two references.
Flags: needinfo?(mozilla)
See Also: → 995095
> -                     autocompletesearch="urlinline history"
> +                     autocompletesearch="unifiedcomplete"
We don't use urlinline but we do use history (autocompletesearch="history"). Does unifiedcomplete subsume history? If so we could switch to it?
Flags: needinfo?(philip.chee) → needinfo?(mak77)
(In reply to Philip Chee from comment #4)
> > -                     autocompletesearch="urlinline history"
> > +                     autocompletesearch="unifiedcomplete"
> We don't use urlinline but we do use history (autocompletesearch="history").
> Does unifiedcomplete subsume history? If so we could switch to it?

As explained in bug 995095 you have 2 choices:
1. move the old nsPlacesAutocomplete in suite, and keep using "history". you'll have to maintain that code but there's less risk we break you with future changes.
2. move to unifiedcomplete, that also includes history. You should try if there's anything that disallows you to use it. I think if you disable autoFill in prefs, it should just work the same as old history query. But it needs some testing to be sure.
Flags: needinfo?(mak77)
Fix just for build break in Seamonkey. Leave bug open for TB and Instantbird or close it and change heading?
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Attachment #8750298 - Flags: review?(philip.chee)
Comment on attachment 8750298 [details] [diff] [review]
package-manifest.in patch for suite

(In reply to Frank-Rainer Grahl from comment #6)
> Created attachment 8750298 [details] [diff] [review]
> package-manifest.in patch for suite
> 
> Fix just for build break in Seamonkey. Leave bug open for TB and Instantbird
> or close it and change heading?
1. Fix just for build break in Seamonkey, change summary, and close.
2. Open new bug fior TB && IB assuming they don't already know about it.

https://bugzilla.mozilla.org/buglist.cgi?chfieldto=Now&chfield=[Bug%20creation]&query_format=advanced&chfieldfrom=-28d&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=READY&bug_status=ASSIGNED&bug_status=REOPENED&product=Thunderbird

https://bugzilla.mozilla.org/buglist.cgi?chfieldto=Now&chfield=[Bug%20creation]&query_format=advanced&chfieldfrom=-28d&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=READY&bug_status=ASSIGNED&bug_status=REOPENED&product=MailNews Core
Attachment #8750298 - Flags: review?(philip.chee) → review+
Checked in for suite. Will check later what the TB devs decided and close bug and/or open new ones if no additional patches shoule be added here.

https://hg.mozilla.org/comm-central/rev/aaf1cc259cf6
Filed bug 1271338 for im and mail.
Summary: Port Bug 1223728 - Remove the unifiedcomplete pref and the urlinline component to c-c → Port Bug 1223728 - Remove the unifiedcomplete pref and the urlinline component to suite
Oki. I am closing shop here.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Depends on: 1272322
You need to log in before you can comment on or make changes to this bug.