1272504 - Labels or text of the find toolbar does not fit on the responsive design view

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[m.adrian15]

Attachment: issue.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160502172042

Steps to reproduce:

1. Open the responsive design view.
2. Resize to 391px (width) or lower.
3. Search something. (Go to find toolbar)
4. The text doesn't fit.


Actual results:

 The text or label ("Match Case", "Phrase not found") doesn't fit in lower resolutions.


Expected results:

The text or label ("Match Case", "Phrase not found") should fit in any resolution.

Comment 1

[:Gijs (he/him)]

My gut feeling is that the find bar shouldn't be inside that thing at all, and should stay on the outer viewport... Mike / Ryan, opinions?

Either way, of course the same problem happens outside of responsive design mode if you just make the window smaller.

(In reply to m.adrian15 from comment #0)
> The text or label ("Match Case", "Phrase not found") should fit in any
> resolution.

I mean, this is clearly impossible, if you actually change the window size... text needs space, and so if you either make the text longer (e.g. in the German localization!) or make the space smaller (by making the window tiny) then you're gonna have a bad time. Arguably this happens too quickly now, but I don't know what our options are for making it better. Mike, could we make the thing wrap?

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to :Gijs Kruitbosch from comment #1)
> My gut feeling is that the find bar shouldn't be inside that thing at all,
> and should stay on the outer viewport... Mike / Ryan, opinions?
> 
> Either way, of course the same problem happens outside of responsive design
> mode if you just make the window smaller.

Various bugs have been opened in RDM about this over the years, I believe the oldest is bug 899031.

In general, I agree it would be better for the find bar to be outside the viewport.  However, we are also in the middle of rewriting the RDM UI, and the rewrite leaves the find bar outside.  I don't think there's much value in making a change if it would only improve the current RDM UI.

Comment 3

[Mike de Boer [:mikedeboer]]

Ryan, is it possible for you to triage this bug, since bug 899031 has been resolved?

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I would consider this fixed by the new RDM UI shipping in 52.