Closed
Bug 1282899
Opened 7 years ago
Closed 7 years ago
Land version 1.4.2 of the Loop system add-on in mozilla-central
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox48 verified, firefox49 fixed, firefox50 fixed)
VERIFIED
FIXED
mozilla50
People
(Reporter: standard8, Assigned: standard8)
References
()
Details
(Whiteboard: [btpp-fix-now])
Attachments
(2 files)
49.55 KB,
patch
|
standard8
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
49.00 KB,
patch
|
Sylvestre
:
approval-mozilla-release-
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 2•7 years ago
|
||
Fixes in this release: - Update OpenTok SDK to 2.7.6 to include iceRestart fixes. - Delay tab sharing startup until after AV start, to try and help connection issues. - 'Start a conversation...' menu item title capitalization fixed - One string change from a locale.
Assignee | ||
Comment 3•7 years ago
|
||
I was going to wait for bug 1282804 & co to deploy the standalone part of the delaying tab sharing. However, looking at how the UX works with the old standalone, it isn't drastically bad and good enough for nightly/aurora/beta. Additionally we should be deploying the standalone tomorrow, so it'll resolve itself then. In the meantime, I think its worth getting these out for wider testing.
No longer depends on: 1282804
Assignee | ||
Updated•7 years ago
|
Attachment #8766033 -
Flags: review+
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/352e0c835e68 Land version 1.4.2 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code.
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/352e0c835e68
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8766033 [details] [diff] [review] Land version 1.4.2 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code. Approval Request Comment [Feature/regressing bug #]: Firefox Hello, conversation connection reliability [User impact if declined]: This update is attempting to fix some reliability issues in the conversations where they are not completing correctly. [Describe test coverage new/current, TreeHerder]: Landed in m-c [Risks and why]: Low - small changes to the flow to attempt to aid connection issues. [String/UUID change made/needed]: None
Attachment #8766033 -
Flags: approval-mozilla-beta?
Attachment #8766033 -
Flags: approval-mozilla-aurora?
Updated•7 years ago
|
status-firefox48:
--- → affected
status-firefox49:
--- → affected
Comment 7•7 years ago
|
||
Comment on attachment 8766033 [details] [diff] [review] Land version 1.4.2 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code. let's do it. Should be in 48 beta 5
Attachment #8766033 -
Flags: approval-mozilla-beta?
Attachment #8766033 -
Flags: approval-mozilla-beta+
Attachment #8766033 -
Flags: approval-mozilla-aurora?
Attachment #8766033 -
Flags: approval-mozilla-aurora+
Comment 8•7 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/af55fb03c444
Comment 9•7 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/9c969eb692bd
Updated•7 years ago
|
Flags: qe-verify+
Assignee | ||
Comment 10•7 years ago
|
||
Approval Request Comment [Feature/regressing bug #]: Firefox Hello. This is part of the Firefox Hello 1.4.2 system add-on update that shipped to 47.0.1 users (along with bug 1273671 and bug 1281619). It should be landed in release should there be another dot release, so that users get the correct version of the add-on.
Attachment #8771390 -
Flags: approval-mozilla-release?
Comment 11•7 years ago
|
||
We recently performed smoketesting and system add-on update on Firefox 47.0.1 across platforms using Hello version 1.4.2 and we did not ran into issues.
Comment 12•7 years ago
|
||
Comment on attachment 8771390 [details] [diff] [review] mozilla-release version Don't think we will do a dot release of 47
Attachment #8771390 -
Flags: approval-mozilla-release? → approval-mozilla-release-
You need to log in
before you can comment on or make changes to this bug.
Description
•