Closed Bug 1285271 Opened 3 years ago Closed 7 months ago

PersistentBufferProviderShared regressions

Categories

(Core :: Graphics: Layers, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: nical, Assigned: nical)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(2 files)

There are some canvas rendering issues with PersistentBufferProviderShared (preffed off in bug 1284721). We need to figure them out and reenable it.
Depends on: 1284723
Depends on: 1284705
No longer depends on: 1284705
Depends on: 1284705
Summary: Race condition with PersistentBufferProviderShared → PersistentBufferProviderShared regressions
Depends on: 1284384
Depends on: 1289105
All of the problems that I could reproduce have been fixed and the remaining open bug is probably fixed although I haven't been able to verify it yet since I haven't reproduced it.

We should be good to re-enable it now.
Attachment #8775171 - Flags: review?(jnicol)
Attachment #8775171 - Flags: review?(jnicol) → review+
Blocks: 1290072
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d32a26786b30
Reenable copy-on-write canvas. r=jnicol
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c16134a5a20f
Reenable copy-on-write canvas. r=jnicol
Flags: needinfo?(nical.bugzilla)
https://hg.mozilla.org/mozilla-central/rev/c16134a5a20f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
There's another wave of regressions and the pref landed just befor ethe merge to aurora so I'm thinking about turning the pref back off on aurora. Maybe just on windows since the current regressions seem to be specific to D2D.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Currently all of the regressions that I don't have patches for are on windows+D2D, so let's try to keep it enabled on the other platforms for now.
Attachment #8778231 - Flags: review?(jnicol)
Attachment #8778231 - Flags: review?(jnicol) → review+
Depends on: 1292545
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/32b74662a9e3
Disable_copy_on_write_canvas_on_windows_r_jnicol: Disable copy-on-write canvas on Windows. r=jnicol
https://hg.mozilla.org/mozilla-central/rev/32b74662a9e3
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [gfx-noted][leave-open]
Comment on attachment 8778231 [details] [diff] [review]
Disable copy-on-write again, on windows

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Loads of crashes on windows
[Describe test coverage new/current, TreeHerder]: None.
[Risks and why]: low risk. The pref was flipped just before the merge to aurora, and we just want to flip it back off one windows due to regressions.
[String/UUID change made/needed]: None.
Attachment #8778231 - Flags: approval-mozilla-aurora?
Depends on: 1291296
Depends on: 1291084
Depends on: 1292192
Depends on: 1291163
Depends on: 1293693
Comment on attachment 8778231 [details] [diff] [review]
Disable copy-on-write again, on windows

This might account for the spike in Aurora crash rate, let's uplift to Fx50.
Attachment #8778231 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
No longer blocks: 1291190
Depends on: 1291190
No longer depends on: 1291084
Depends on: 1298813
Depends on: 1298345
Depends on: 1300121
Keywords: leave-open
Whiteboard: [gfx-noted][leave-open] → [gfx-noted]

The leave-open keyword is there and there is no activity for 6 months.
:nical, maybe it's time to close this bug?

Flags: needinfo?(nical.bugzilla)

Yeah.

Status: REOPENED → RESOLVED
Closed: 3 years ago7 months ago
Flags: needinfo?(nical.bugzilla)
Keywords: leave-open
Resolution: --- → FIXED
See Also: → 1531417
You need to log in before you can comment on or make changes to this bug.