1285271 - PersistentBufferProviderShared regressions

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect, P3)

Description

[Nicolas Silva [:nical]]

There are some canvas rendering issues with PersistentBufferProviderShared (preffed off in bug 1284721). We need to figure them out and reenable it.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Reenable copy-on-write canvas.

All of the problems that I could reproduce have been fixed and the remaining open bug is probably fixed although I haven't been able to verify it yet since I haven't reproduced it.

We should be good to re-enable it now.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d32a26786b30
Reenable copy-on-write canvas. r=jnicol

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/ed4692732f03 for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=32824020&repo=mozilla-inbound

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c16134a5a20f
Reenable copy-on-write canvas. r=jnicol

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c16134a5a20f

Comment 6

[Nicolas Silva [:nical]]

There's another wave of regressions and the pref landed just befor ethe merge to aurora so I'm thinking about turning the pref back off on aurora. Maybe just on windows since the current regressions seem to be specific to D2D.

Comment 7

[Nicolas Silva [:nical]]

Attachment: Disable copy-on-write again, on windows

Currently all of the regressions that I don't have patches for are on windows+D2D, so let's try to keep it enabled on the other platforms for now.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/32b74662a9e3
Disable_copy_on_write_canvas_on_windows_r_jnicol: Disable copy-on-write canvas on Windows. r=jnicol

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/32b74662a9e3

Comment 10

[Nicolas Silva [:nical]]

Comment on attachment 8778231 [details] [diff] [review]
Disable copy-on-write again, on windows

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Loads of crashes on windows
[Describe test coverage new/current, TreeHerder]: None.
[Risks and why]: low risk. The pref was flipped just before the merge to aurora, and we just want to flip it back off one windows due to regressions.
[String/UUID change made/needed]: None.

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8778231 [details] [diff] [review]
Disable copy-on-write again, on windows

This might account for the spike in Aurora crash rate, let's uplift to Fx50.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d4204af2ee53

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:nical, maybe it's time to close this bug?

Comment 14

[Nicolas Silva [:nical]]

Yeah.