1301317 - Don't build telephony API without MOZ_B2G_RIL

Status: RESOLVED DUPLICATE of bug 1307525

(Core :: DOM: Core & HTML, defect)

Description

[Makoto Kato [:m_kato]]

Although we disable navigator.Telephony without MOZ_B2G_RIL, dom/telephony is still built.

If we don't build this, it seems to be able to reduce ~60K APK size on Fennec.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1301317 - Don't build telephony API without MOZ_B2G_RIL.

Review commit: https://reviewboard.mozilla.org/r/77554/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77554/

Comment 2

[[:fabrice] Fabrice Desré]

What prevents us from just not build dom/telephony at all?

Comment 3

[Makoto Kato [:m_kato]]

(In reply to [:fabrice] Fabrice Desré from comment #2)
> What prevents us from just not build dom/telephony at all?

I would like to reduce footprint.  Actually, we don't use / run telephone API on desktop and mobile Firefox.  But for XPCOM interface and IPC code, compiler cannot remove these code by dead code elimination.

If this API is standard API and needs for web compatibility, we should keep it even if desktop Firefox.  But this API is for B2G phone only.

Comment 4

[[:fabrice] Fabrice Desré]

Sure, I agree. What I'm asking is "why not ignore the whole dom/telephony directory on platforms that are not b2g?"

Comment 5

[Makoto Kato [:m_kato]]

(In reply to [:fabrice] Fabrice Desré from comment #4)
> Sure, I agree. What I'm asking is "why not ignore the whole dom/telephony
> directory on platforms that are not b2g?"

We don't have C-preprocessor for IPDL, we cannot use like #ifdef into IPDL.  So telephony IPC protocol define is used on PContent.ipdl, we cannot ignore dom/telephony directory.

So at least, we need generate IPC headers and etc.

Comment 6

[Makoto Kato [:m_kato]]

Comment on attachment 8789265 [details]
Bug 1301317 - Don't build telephony API without MOZ_B2G_RIL.

This will be removed by Bug 1307525.