Open Bug 1301658 Opened 3 years ago Updated 3 months ago

High Contrast Theme - multiple menu options are shown as selected

Categories

(Core :: Widget: Win32, defect, P3)

x86_64
Windows 10
defect

Tracking

()

Tracking Status
firefox48 --- unaffected
firefox49 --- unaffected
firefox50 --- unaffected
firefox51 --- affected
firefox54 --- affected

People

(Reporter: simona.marcu, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: access, polish, Whiteboard: [tpi:+])

Attachments

(4 files)

Attached image highContrast.png
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160908030434

[Affected versions]:
- Nightly 51

[Affected platforms]:
- Windows 10

[Prerequisites]:
Activate a high contrast theme.
- "Windows: Go to Personalize> Themes> Theme Settings and activate a High Contrast Theme.
- Ubuntu: Install "gnome-control-center"- > System settings -> Appearance.

[Steps to reproduce]:
1. Launch Firefox with a new profile
2. Perform one download and wait for it to be complete
3. Click on the Downloads button
4. In the downloads panel, click on the dropmarker
5. Hover your mouse over the 2 options from the dropmarker ("Clear Preview Panel" and "Open Downloads folder")

[Expected result]:
The highlight is properly done as each option is hovered.

[Actual result]:
Both options are highlighted at the same time. Please see the screenshot for more details.

[Regression range]:
Not a regression.

[Additional notes]:
Not reproducible on Windows 7.
Not reproducible on Ubuntu 14.04.
Whiteboard: [CHE-MVP][CHE-BUG]
Hi Paolo,

I've reproduced the bug and uploaded the video.
If the mouse cursor is moved in the right speed, it can be reproduced.

"_moz-menuactive" property is normal that there is only one _moz-menuactive="true" in these two items, and I can't figure out the root cause.
May I have your suggestion?

Thank you.
Flags: needinfo?(paolo.mozmail)
I have no idea, never seen this before. Maybe Dão can help, seems to be on high contrast mode only?
Flags: needinfo?(paolo.mozmail) → needinfo?(dao+bmo)
I tried the same steps to reproduce it on non-high contrast mode, but it can not be reproduced.
I've seen this before in other menus (including from the main menu bar) in high contrast mode. Feels like a widget or graphics bug where invalidation doesn't happen when it should.
Component: Downloads Panel → Widget: Win32
Flags: needinfo?(dao+bmo) → needinfo?(jmathies)
Product: Firefox → Core
Hi Jim:

This is EPM Wesly from Taipei, nice to meet you!

Since this is an MVP bug of our project[1] that Softvision team recommended as a must-fix (in the sign-pff report), would you kindly check it, or let us know the most proper person for it?

Thanks!

[1] https://mana.mozilla.org/wiki/display/PM/Content+Handling+Enhancement
Flags: needinfo?(jmathies)
Flags: needinfo?(jmathies)
(In reply to Wesly Huang (Firefox EPM) from comment #5)
> Hi Jim:
> 
> This is EPM Wesly from Taipei, nice to meet you!
> 
> Since this is an MVP bug of our project[1] that Softvision team recommended
> as a must-fix (in the sign-pff report), would you kindly check it, or let us
> know the most proper person for it?
> 
> Thanks!
> 
> [1] https://mana.mozilla.org/wiki/display/PM/Content+Handling+Enhancement

Anyone from our community who knows a little bit about Mozilla and win32 coding can work on this. Internally I don't have anyone I can put on this now. It's pretty polishy, and therefore not a high priority.
Flags: needinfo?(jmathies)
Keywords: polish
Priority: -- → P3
Whiteboard: [CHE-MVP][CHE-BUG] → [CHE-MVP][CHE-BUG][tpi:+]
(In reply to Jim Mathies [:jimm] from comment #6)
> It's pretty polishy, and therefore not a high priority.

Not knowing what option from the dropdown will be activated is actually pretty bad from a user's perspective...
(In reply to Dão Gottwald [:dao] from comment #7)
> (In reply to Jim Mathies [:jimm] from comment #6)
> > It's pretty polishy, and therefore not a high priority.
> 
> Not knowing what option from the dropdown will be activated is actually
> pretty bad from a user's perspective...

While it's likely not that common that a user will hit this, it does block basic functionality for those that do, so I agree with Dão.
Thanks Jim and Dao, also Peter's comment from the Product team.

Jim, I understand you don't have people to put here for now. However since this polish work indeed impact those using it (and their experience/impression to Firefox), do you think you'll able to consider raising its priority and plan a resource on it in the near future? (e.g., early FFX 53?)

Thanks!
Flags: needinfo?(jmathies)
Flags: needinfo?(jmathies)
Priority: P3 → P2
Hi Jim:

Since this was set to P2 while FFX52 nightly, shall we update it to P1 now as we started FFX53 nightly last week? (I read the priority based on the Triage model presented in London[1])

Thanks!

[1] https://docs.google.com/presentation/d/1qlXlDsMnvcpA5ppJVJWIBaBDPEyw5hbjU-Q7wjjrZQM/edit#slide=id.g14da572af9_0_95
Flags: needinfo?(jmathies)
Hi Simona,

Could you provide the reproduce rate of this issue? In my experiments (video attachment 8801050 [details]), this bug is only reproducible under certain mouse movement speed.

IMO, the issue requires following 3 conditions to reproduce:
1. Windows 10
2. High Contrast Mode
3. at the certain mouse movement speed.

If you find any way to increase the reproducing rate, please share your steps.

BTW, this issue can be recovered by moving through the dropdown menu again once this issue happens in user side.

(In reply to Sean Lee [:seanlee][:weilonge] from comment #1)
> Created attachment 8801050 [details]
> video for reproducing the two highlighted items
> 
> Hi Paolo,
> 
> I've reproduced the bug and uploaded the video.
> If the mouse cursor is moved in the right speed, it can be reproduced.
> 
> "_moz-menuactive" property is normal that there is only one
> _moz-menuactive="true" in these two items, and I can't figure out the root
> cause.
> May I have your suggestion?
> 
> Thank you.
Flags: needinfo?(simona.marcu)
Attached video High Contrast.mp4
(In reply to Sean Lee [:seanlee][:weilonge] from comment #11)
> Hi Simona,
> 
> Could you provide the reproduce rate of this issue? In my experiments (video
> attachment 8801050 [details]), this bug is only reproducible under certain
> mouse movement speed.
> 
> IMO, the issue requires following 3 conditions to reproduce:
> 1. Windows 10
> 2. High Contrast Mode
> 3. at the certain mouse movement speed.
> 
> If you find any way to increase the reproducing rate, please share your
> steps.
> 
> BTW, this issue can be recovered by moving through the dropdown menu again
> once this issue happens in user side.

Indeed, I could only reproduce this issue on Windows 10 with a High Contrast theme and, on Firefox 50 release it was also dependent of the mouse movement speed (moving the mouse faster between the menus option fields will highlight more than one field).

But on the latest Nightly 53.0a1 (20161124030208) things have gotten worse and the issue is reproducible every time a menu is opened (no longer dependent on the mouse movement speed). Please see the screen cast.
Flags: needinfo?(simona.marcu)
(In reply to Wesly Huang (Firefox EPM) from comment #10)
> Hi Jim:
> 
> Since this was set to P2 while FFX52 nightly, shall we update it to P1 now
> as we started FFX53 nightly last week? (I read the priority based on the
> Triage model presented in London[1])
> 
> Thanks!
> 
> [1]
> https://docs.google.com/presentation/d/1qlXlDsMnvcpA5ppJVJWIBaBDPEyw5hbjU-
> Q7wjjrZQM/edit#slide=id.g14da572af9_0_95


I'm sorry but I do not have anyone on the platform integration team that can work on this currently.
Flags: needinfo?(jmathies)
(In reply to Simona B [:simonab ] from comment #12)
> Created attachment 8814343 [details]
> High Contrast.mp4
> 
> Indeed, I could only reproduce this issue on Windows 10 with a High Contrast
> theme and, on Firefox 50 release it was also dependent of the mouse movement
> speed (moving the mouse faster between the menus option fields will
> highlight more than one field).
> 
> But on the latest Nightly 53.0a1 (20161124030208) things have gotten worse
> and the issue is reproducible every time a menu is opened (no longer
> dependent on the mouse movement speed). Please see the screen cast.

After watching the screen cast, this issue is not only relative to Downloads Panel but also the context menu in the content.
Hi Dao,

Could you see attachment 8814343 [details] which is the screencast to show the high contrast issue?
It seems a general high contrast issue which is not limited to Downloads Panel only.
Do you have any idea for this issue? or anyone can help on it? Thanks.
Flags: needinfo?(dao+bmo)
(In reply to Sean Lee [:seanlee][:weilonge] from comment #15)
> Hi Dao,
> 
> Could you see attachment 8814343 [details] which is the screencast to show
> the high contrast issue?
> It seems a general high contrast issue which is not limited to Downloads
> Panel only.

Yes, I already noted this in comment 4.

> Do you have any idea for this issue? or anyone can help on it? Thanks.

It seems like a win32 widget issue and therefore needs someone with expertise in that field. I'd take a look myself but I wouldn't even know where to start as I have almost no experience with this code.
Flags: needinfo?(dao+bmo)
(In reply to Jim Mathies [:jimm] from comment #13)
> I'm sorry but I do not have anyone on the platform integration team that can
> work on this currently.

Thanks Jim, then maybe you can consider to set it to P1 in the early FFX54 nightly? i.e., plan a resource in advance, given the impact could be actually higher than originally understood (not only for Download Panel, but context menu) according to the discussion in comment#15 and comment#16.

Thanks!
Flags: needinfo?(jmathies)
I've found various reports of this: bug 1208972, bug 993387, it seems to go back at least to FF29, even if the first bug actually says it is reproducible even with keyboard selection.
Duplicate of this bug: 1208972
Duplicate of this bug: 993387
I'm fairly sure this is effectively the same as bug 1294788, which is a regression of bug 888870, if that helps at all. :-\
To sum up:
- this bug should track the multiple selections issue (as described in comment 0), with the note that this affects multiple areas, such as main menus, context dropdowns, etc) and not only download dropmarker.
- this bug got way worse after bug 1314133: "Enable the GPU process for Nightly Windows users." 
I can confirm this is the case since setting layers.gpu-process.dev.enabled to false will default to the old bad behavior. (new bad behavior: everything in the menus appear as getting selected. -see attachment 8814343 [details])

Based on the above, changing the bug summary and removing the block on bug 1269956 and on bug 1320259. Adding bug 1314133 as blocking since it seems to be the culprit for the worsening of this bad behavior.
Blocks: 1314133
No longer blocks: 1269956, 1320259
Summary: High Contrast Theme - both options are highlighted in the downloads dropmarker → High Contrast Theme - multiple menu options are shown as selected
Whiteboard: [CHE-MVP][CHE-BUG][tpi:+] → [CHE-BUG][tpi:+]
Whiteboard: [CHE-BUG][tpi:+] → [tpi:+]
Hey Simona? Are you still seeing this? I'm testing with the high contrast black theme, latest nightly. I can't reproduce.
Flags: needinfo?(jmathies) → needinfo?(simona.marcu)
Attached video highContrastN54.0a1.mp4
(In reply to Jim Mathies [:jimm] from comment #23)
> Hey Simona? Are you still seeing this? I'm testing with the high contrast
> black theme, latest nightly. I can't reproduce.

Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170126030209

Yes, I can still reproduce this issue on the latest Nightly 54.0a1 on Windows 10 x64.
Please see the screen cast as a confirmation.
Flags: needinfo?(simona.marcu)
Hi

I have been affected from this bug since windows 10 come out. It's a very old bug and Thunderbird have it also. 
Right now the Firefox 53 is way more easy to "paint" all menus in the high contrast mode with the highlight color.
Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Priority: P2 → P3
Keywords: access
You need to log in before you can comment on or make changes to this bug.