1303914 - TC Android builds on mozilla-beta failing because they don't have the secret /builds/adjust-sdk-beta.token

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Description

[Phil Ringnalda (:philor)]

There are two seekrit files, /builds/adjust-sdk-beta.token and for mozilla-release (for which you have six weeks) /builds/adjust-sdk.token, added to releng build slaves by bug 1245304 and bug 1152871 respectively, which nobody remembered to tell you about.

As of this morning, you are building the tier-1 Android debug build on mozilla-beta, except that you aren't building it because configure fails out if you try to build beta without having /builds/adjust-sdk-beta.token.

Comment 1

[Jordan Lund (:jlund)]

Attachment: Bug 1303914 - buildbot - turn on fennec debug builds and tests for beta 50

Review commit: https://reviewboard.mozilla.org/r/79660/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79660/

Comment 2

[Jordan Lund (:jlund)]

Attachment: Bug 1303914 - TC Android builds on mozilla-beta failing. require secret /builds/adjust-sdk-beta.token

Review commit: https://reviewboard.mozilla.org/r/79664/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79664/

Comment 3

[Jordan Lund (:jlund)]

comment 1 and 2 add patches re-add bbot android debug builds and demote tc andorid debug builds to tier 2. This is a stopgap while we apply a long term fix.

I see three long term fixes:

1: remove the need for the secret file on beta debug builds

2: use tc secret service to add the file at runtime

3: use internal tooltool to add the file at runtime

Comment 4

[Aki Sasaki (not active)]

Comment on attachment 8792757 [details]
Bug 1303914 - buildbot - turn on fennec debug builds and tests for beta 50

https://reviewboard.mozilla.org/r/79660/#review78328

Comment 5

[Aki Sasaki (not active)]

Comment on attachment 8792758 [details]
Bug 1303914 - TC Android builds on mozilla-beta failing. require secret /builds/adjust-sdk-beta.token

https://reviewboard.mozilla.org/r/79664/#review78330

Comment 6

[Jordan Lund (:jlund)]

https://hg.mozilla.org/build/buildbot-configs/rev/2726220a2e497ecfd6263f2e9f0f6df7d2f95adc
Bug 1303914 - buildbot - turn on fennec debug builds and tests for beta 50, r=aki

Comment 7

[Phil Ringnalda (:philor)]

Okay, you're right, that summary was confusing.

Comment 8

[Phil Ringnalda (:philor)]

Hidden on treeherder, don't let me forget that I need to unhide them when they get greened up.

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

Jordan, a week or so ago, someone was working on adding adjust-sdk to mozharness such that it would be downloaded from the secrets service.  Is this fixed?  Does that need to be backported to release branches?

Comment 10

[Jordan Lund (:jlund)]

I'm going to poke this today

Comment 11

[Jordan Lund (:jlund)]

Comment on attachment 8792758 [details]
Bug 1303914 - TC Android builds on mozilla-beta failing. require secret /builds/adjust-sdk-beta.token

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79664/diff/1-2/

Comment 12

[Jordan Lund (:jlund)]

bah, I confused mozreview and clobbered my bandaid gecko patch. will file follow up bug to track long term fix

Comment 13

[Jordan Lund (:jlund)]

(In reply to Dustin J. Mitchell [:dustin] from comment #9)
> Jordan, a week or so ago, someone was working on adding adjust-sdk to
> mozharness such that it would be downloaded from the secrets service.  Is
> this fixed?  Does that need to be backported to release branches?

hm, haven't seen anything on central from ~ 1 week ago. However, I noticed that the file by the same name is downloaded for linux builds. I've copied the config over for android here: https://bugzilla.mozilla.org/attachment.cgi?id=8798215

running against try now. made some assumptions here: https://bugzilla.mozilla.org/show_bug.cgi?id=1308010#c2

Comment 14

[Jordan Lund (:jlund)]

https://hg.mozilla.org/build/buildbot-configs/rev/afb6b9678db61ad1d7f3b26a1924273f56ed5bad
relands Bug 1303914 - rev: 2726220a2e49

Comment 15

[Greg Arndt [:garndt]]

Looks like this bug has been taken care of and the original demotion was reverted.  Android builds are tier 1 in TC.  Please reopen if there is an issue or if I closed mistakenly.