1306670 - Scrolling in bookmarks menu hides text for 4 seconds and other issues with buttons & menus in Mozilla Firefox Nightly 52.0a1 (2016-09-30)

Status: VERIFIED FIXED

(Core :: Graphics: Text, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bug.png

[Tracking Requested - why for this release]: Regression


Regression window (mozilla-central)
Good:
https://ftp.mozilla.org/pub/firefox/nightly/2016/09/2016-09-29-03-04-26-mozilla-central/

Bad:
https://ftp.mozilla.org/pub/firefox/nightly/2016/09/2016-09-30-03-03-15-mozilla-central/

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f7d5008ee2ab9200052e45ad6ecc3f3a348f7f86&tochange=59db3b0781908d9e2145477ff8dc5a85729e25bf


STR:
1. Open bookmarks menu
2. Scroll it to see that text will hide for 4 seconds

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: Graphics section from about:support.txt

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I suspect that it was caused by bug #1303570,
as I remember similar issue in the past in bug #626299, which was caused by bug #622482.

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

@ Jonathan Kew (:jfkthame) - Could you please look in your free time on this bug, as it's nearly identical to the bug #626299, which you fixed. Thanks.

Comment 4

[Alice0775 White]

I can reproduce on Nightly 52.0a1 Windows10 if set layout.css.devPixelsPerPx <> 1.0

Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=22b1e96cfd05eab52fc71c0dd9a846f4cc45f5bf&tochange=f21ffbf119bd6d7084309123be42f97743f1f7e5

Comment 5

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Also there is some flickering after pressing download button, like just 1 second of not visible text.

Comment 6

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: 52.0a1 (2016-09-30) (64-bit).gif

Posting how the bug look like.
Source of attachment: bug #1303570 comment #39.

Comment 7

[Bas Schouten (:bas.schouten)]

(In reply to Virtual_ManPL [:Virtual] - (ni? me) from comment #5)
> Also there is some flickering after pressing download button, like just 1
> second of not visible text.

I can reproduce this, with a non 1.0 devPixelsPerPx. Not the issue with bookmarks, but let's assume it's the same bug for now.

Comment 8

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Just FYI, I have by default set "layout.css.devPixelsPerPx" to "-1.0" on Windows 7 (64bit) with Nightly (64bit)

Comment 9

[Marco Bonardo [:mak]]

(In reply to Virtual_ManPL [:Virtual] - (ni? me) from comment #8)
> Just FYI, I have by default set "layout.css.devPixelsPerPx" to "-1.0" on
> Windows 7 (64bit) with Nightly (64bit)

Same here on Win10 and I can reproduce.
I also see other issues that appeared in the same build and are likely related:

1. drag the devtools button to the nav-bar, click on it. The menu paints the previous content for a while, then clears and paints again.
2. Downloads in the downloads panel are missing the status greytext (the text below the file name indicating the host, size and so on).

Comment 10

[Marcia Knous [:marcia]]

Tracking 52+ for this regression.

Comment 11

[Bas Schouten (:bas.schouten)]

Attachment: Bug 1306670: Properly disable cleartype when the underlying surface indicates it may not be opaque.

Review commit: https://reviewboard.mozilla.org/r/82796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82796/

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8797195 [details]
Bug 1306670: Properly disable cleartype when the underlying surface indicates it may not be opaque.

https://reviewboard.mozilla.org/r/82796/#review81842

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df26b07efb46
Properly disable cleartype when the underlying surface indicates it may not be opaque. r=jrmuizel

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/df26b07efb46

Comment 15

[Marco Bonardo [:mak]]

Attachment: No Cleartype on downloads panel

The flickring on the panels has gone, thank you.

On the other side, I noticed the status text on the downloads panel is missing cleartype, see the difference compared to the Library window (on the right).

I guess this may be expected based on the name of the patch?
Any ideas on how we can workaround the problem in the UI?

Comment 16

[Marco Bonardo [:mak]]

The downloads details are set as:
.downloadDetails {
  opacity: 0.7;
  font-size: 95%;

Comment 17

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Comment on attachment 8798034 [details]
No Cleartype on downloads panel

(In reply to Marco Bonardo [::mak] from comment #15)
> Created attachment 8798034 [details]
> No Cleartype on downloads panel
> 
> The flickring on the panels has gone, thank you.
> 
> On the other side, I noticed the status text on the downloads panel is
> missing cleartype, see the difference compared to the Library window (on the
> right).
> 
> I guess this may be expected based on the name of the patch?
> Any ideas on how we can workaround the problem in the UI?
+
(In reply to Marco Bonardo [::mak] from comment #16)
> The downloads details are set as:
> .downloadDetails {
>   opacity: 0.7;
>   font-size: 95%;

Confirmed and reported it here - bug #1307833

Comment 20

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

[Tracking Requested - why for this release]: Regression

Marking Firefox 51 as affected per uplift to Aurora bug #1303570 comment #56.

Comment 21

[Gerry Chang [:gchang]]

Track 51+ as regression.

Hi :bas.schouten,
could you please nominate this uplift to Beta51?

Comment 22

[Gerry Chang [:gchang]]

Hi Milan,
Can you help find someone to create uplift request for Beta51?

Comment 24

[Bas Schouten (:bas.schouten)]

Comment on attachment 8797195 [details]
Bug 1306670: Properly disable cleartype when the underlying surface indicates it may not be opaque.

Approval Request Comment
[Feature/regressing bug #]: 1303570
[User impact if declined]: Missing text in some fallback scenarios
[Describe test coverage new/current, TreeHerder]: Aurora
[Risks and why]: Can disable cleartype in some cases where it -could- be used.
[String/UUID change made/needed]: None

Comment 26

[Gerry Chang [:gchang]]

Comment on attachment 8797195 [details]
Bug 1306670: Properly disable cleartype when the underlying surface indicates it may not be opaque.

Fix a regression when scrolling in bookmarks menu. Beta51+. Should be in 51 beta 2.

Comment 29

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/755199811a51