Closed
Bug 1310187
Opened 8 years ago
Closed 8 years ago
make Scheduled Changes conditions' configurable
Categories
(Release Engineering Graveyard :: Applications: Balrog (backend), defect)
Release Engineering Graveyard
Applications: Balrog (backend)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
Attachments
(1 file)
Currently, Scheduled Changes supports two types of conditions: time-based, and telemtery-based. These both make sense for Rules, but telemetry-based conditions do not make sense for Releases or Permissions. We will be enabling Scheduled Changes for these, so we'll need to make it possible to disable conditions on a per-table basis.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → bhearsum
|
|
Assignee | |
Comment 1•8 years ago
|
||
Details in the PR, as usual.
Attachment #8802920 -
Flags: review?(nthomas)
Attachment #8802920 -
Flags: review?(jlorenzo)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8802920 [details] [review]
make conditions configurable
I forgot to report r+ back in Bugzilla.
Attachment #8802920 -
Flags: review?(jlorenzo) → review+
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8802920 [details] [review]
make conditions configurable
Looks good, but sounds like there's going to be another iteration here.
Attachment #8802920 -
Flags: review?(nthomas)
|
|
Assignee | |
Comment 4•8 years ago
|
||
Comment on attachment 8802920 [details] [review]
make conditions configurable
Could you guys take a second look at this now that it's got the conditions table merged in?
Attachment #8802920 -
Flags: review?(nthomas)
Attachment #8802920 -
Flags: review?(jlorenzo)
|
|
||
Updated•8 years ago
|
Attachment #8802920 -
Flags: review?(jlorenzo) → review+
|
|
||
Updated•8 years ago
|
Attachment #8802920 -
Flags: review?(nthomas) → review+
|
||
Comment 5•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/balrog
https://github.com/mozilla/balrog/commit/3c7256baa3670bf746a21eca7c5c7dfbcde6d112
bug 1310187: Make Scheduled Changes conditions configurable (#151). r=jlorenzo,nthomas
|
||
Comment 6•8 years ago
|
||
This change will be deployed in bug 1320966 sometime between 11am and 1pm pacific on 2016-11-30. IT will be deployed to stage today. Can you verify your fixes once stage is deployed please?
Flags: needinfo?(bhearsum)
|
|
Assignee | |
Comment 7•8 years ago
|
||
(In reply to Rail Aliiev [:rail] ⌚️ET from comment #6)
> This change will be deployed in bug 1320966 sometime between 11am and 1pm
> pacific on 2016-11-30. IT will be deployed to stage today. Can you verify
> your fixes once stage is deployed please?
Yup, works fine.
Flags: needinfo?(bhearsum)
|
|
Assignee | |
Comment 8•8 years ago
|
||
This made it to production today.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Product: Release Engineering → Release Engineering Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•