The default bug view has changed. See this FAQ.

Background of badge on browserAction button changes to red on entering and remains red on exiting Customize mode

UNCONFIRMED
Unassigned

Status

()

Toolkit
WebExtensions: Frontend
P5
normal
UNCONFIRMED
5 months ago
5 months ago

People

(Reporter: dw-dev, Unassigned)

Tracking

48 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [browserAction]triaged)

(Reporter)

Description

5 months ago
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160823121617

Steps to reproduce:

I have developed three WebExtensions add-ons (Print Edit WE, Tile Tabs WE and Zoom Page WE) that all have a badge on the browserAction button indicating the state of the add-on.

Normally, the badges work fine.  However, on entering Customize mode the badge backgrounds all change to red, and on exiting Customize mode the badge backgrounds remain red.


Actual results:

On entering Customize mode the badge backgrounds all change to red, and on exiting Customize mode the badge background all remain red.


Expected results:

On entering Customize mode the badge backgrounds should either remain the colors that they were previously or the badges should be hidden.

On exiting Customize mode the badge backgrounds should return to the colors that they were previously (before entering Customize mode).
(Reporter)

Updated

5 months ago
Summary: badge on browserAction button changes to red after exit customize → WebExtensions: Background of badge on browserAction button changes to red on entering and remains red on exiting Customize mode

Updated

5 months ago
Component: Untriaged → WebExtensions: Untriaged
Product: Firefox → Toolkit

Comment 1

5 months ago
I can't reproduce this at all. Do you have other add-ons or themes that might be causing this?

Updated

5 months ago
Summary: WebExtensions: Background of badge on browserAction button changes to red on entering and remains red on exiting Customize mode → Background of badge on browserAction button changes to red on entering and remains red on exiting Customize mode

Updated

5 months ago
Component: WebExtensions: Untriaged → WebExtensions: Frontend
Flags: needinfo?(dw-dev)
Whiteboard: [browserAction]
(Reporter)

Comment 2

5 months ago
I have re-tested with both Firefox 49.0 and Nightly 52.0a1, installing only my Zoom Page WE 3.0 add-on in a new profile.  The reported problem occurs every time I enter/exit Customize mode.

I have also re-tested Nightly 52.0a1, installing my Print Edit WE and Tile Tabs WE add-ons in separate new profiles.  Again, the reported problem occurs every time I enter/exit Customize mode.

The simplest test is:

1. Use Firefox 49.0 or Nightly 52.0a1.
2. Create a new profile.
3. Install Zoom Page WE 3.0.
4. Navigate to the Google home page.
5. The Zoom Page WE button should be showing a badge with a dark grey background and the text "100".
6. Use the Firefox menu panel to enter Customize mode.
7. The badge on the Zoom Page WE button now has a red background.
8. Exit Customize mode.
9. The badge on the Zoom Page WE button still has a red background.
10. Click on the Zoom Page WE button and the badge background returns to dark grey.
Flags: needinfo?(dw-dev)

Comment 3

5 months ago
Ah thanks, dw-dev I can reproduce, its the text on the browser action that goes red. Red is the default background colour of the text, so this looks like a bug in how setBadgeBackgroundColor works.
Priority: -- → P5
Whiteboard: [browserAction] → [browserAction]triaged
You need to log in before you can comment on or make changes to this bug.