1316405 - [e10s] Dropdown menu list is using wrong font size

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P1)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

+++ This bug was initially created as a clone of Bug #1313418 +++

[Tracking Requested - why for this release]: Regression

STR:
1. Open this website page - https://bugzilla.mozilla.org/enter_bug.cgi?product=Core
2. Open second "Platform" dropdown menu list
3. See that font in text on dropdown menu list is using other size family than on button. The font is smaller. It's consistency and compatibility issue, comparing to other browsers.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Hey Philipp, what do you think about the difference between the font being used on the button and what shows up in the popup?

You can look at https://bug1313418.bmoattachments.org/attachment.cgi?id=8805455 to see the difference. We didn't change the font on the button because we are worried about web compat.

Comment 2

[Jim Mathies [:jimm]]

Attachment: selects.jpg

I think this is a recent regression. might have something to do with recent gfx changes related to oopc.

Comment 3

[Jim Mathies [:jimm]]

Attachment: 51selects.jpg

here's aurora, which doesn't have the issue.

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Jim Mathies [:jimm] from comment #2)
> Created attachment 8809181 [details]
> selects.jpg
> 
> I think this is a recent regression. might have something to do with recent
> gfx changes related to oopc.
+
(In reply to Jim Mathies [:jimm] from comment #3)
> Created attachment 8809184 [details]
> 51selects.jpg
> 
> here's aurora, which doesn't have the issue.

It's bug #1315568,
not this one, which is about wrong size of the fonts
Firefox 51 - https://bug1313418.bmoattachments.org/attachment.cgi?id=8805454
Firefox 52 - https://bug1313418.bmoattachments.org/attachment.cgi?id=8805455
It regressed because of patch from bug #1091592.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

This is fixed by the patch in bug 1316722.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Fixed by bug 1316722.

Comment 7

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Thank you very much! \o/

Comment 8

[Marcia Knous [:marcia]]

Tracking 53- since this is verified fixed.

Comment 9

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Reopening, as it's not fixed for all dropdown menu lists

Comment 10

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: good size.png

Comment 11

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bad size.png

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: font-size.png

This screenshot shows Firefox Beta 51 on the right and Firefox Nightly 53 on the left. The font-sizes here are the same between the two.

There were some changes in look between non-e10s and e10s but those are considered wontfix. The only changes that these two screenshots show is lighter border color, increased padding, and a grey background for the optgroup headers. These changes are by design.

Comment 13

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #12)
> [...] There were some changes in look between non-e10s and e10s
> but those are considered wontfix.
> [...] These changes are by design.

So the font size in the button won't be the same, as the font size in the dropdown menu,
and it's considered wontfix, as it's intended by design?

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Virtual_ManPL [:Virtual] - (ni? me) from comment #13)
> (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #12)
> > [...] There were some changes in look between non-e10s and e10s
> > but those are considered wontfix.
> > [...] These changes are by design.
> 
> So the font size in the button won't be the same, as the font size in the
> dropdown menu,
> and it's considered wontfix, as it's intended by design?

I tested on Windows 10 and we can match the default font of the button to that of the popup if we set `font: -moz-list;` on the menucaptions and menuitems inside of the #ContentSelectDropdown. I will upload a patch to bug 1316404. Thank you for your persistence.

Comment 15

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #14)
> (In reply to Virtual_ManPL [:Virtual] - (ni? me) from comment #13)
> > (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #12)
> > > [...] There were some changes in look between non-e10s and e10s
> > > but those are considered wontfix.
> > > [...] These changes are by design.
> > 
> > So the font size in the button won't be the same, as the font size in the
> > dropdown menu,
> > and it's considered wontfix, as it's intended by design?
> 
> I tested on Windows 10 and we can match the default font of the button to
> that of the popup if we set `font: -moz-list;` on the menucaptions and
> menuitems inside of the #ContentSelectDropdown. I will upload a patch to bug
> 1316404. Thank you for your persistence.

Thank you very much for reconsidering and creating the patch and ! \o/