Closed
Bug 1313418
Opened 8 years ago
Closed 8 years ago
[e10s] Dropdown menu list is using wrong font family & size and have too much useless space between items
Categories
(Core :: Layout: Form Controls, defect)
Tracking
()
VERIFIED
DUPLICATE
of bug 1300784
People
(Reporter: Virtual, Unassigned)
Details
(Keywords: nightly-community)
Attachments
(5 files)
STR:
1. Open this website page - https://bugzilla.mozilla.org/enter_bug.cgi?product=Core
2. Open second "Platform" dropdown menu list
3. See that visual appearance of dropdown menu list with e10s enabled is different compared to dropdown menu list with e10s disabled.
Most notable changes are that:
- font family used in foreground text isn't used in dropdown menu list
- there are too much useless space between items in dropdown menu list
Reporter | ||
Updated•8 years ago
|
Reporter | ||
Comment 3•8 years ago
|
||
Also size of the font is different.
Summary: [e10s] Dropdown menu list is using wrong font family and have too much useless space between items → [e10s] Dropdown menu list is using wrong font family & size and have too much useless space between items
Reporter | ||
Comment 4•8 years ago
|
||
[Tracking Requested - why for this release]: Regression
On stable builds the regression started in Firefox 48, where e10s is by default enabled.
status-firefox49:
--- → affected
status-firefox50:
--- → affected
status-firefox51:
--- → affected
status-firefox52:
--- → affected
status-firefox-esr45:
--- → unaffected
tracking-firefox49:
--- → ?
tracking-firefox50:
--- → ?
tracking-firefox51:
--- → ?
tracking-firefox52:
--- → ?
Reporter | ||
Comment 8•8 years ago
|
||
There even was some change between Firefox 51 and Firefox 52 in this issue.
Version: Trunk → 48 Branch
Reporter | ||
Updated•8 years ago
|
Keywords: multiprocess
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Comment 10•8 years ago
|
||
Bug #1300784 is only about combining e10s and non-e10s <select> dropdown mechanisms, not about regression that dropdown menu list is using wrong font family & size and have too much useless space between items.
Reporter | ||
Updated•8 years ago
|
Status: REOPENED → NEW
Reporter | ||
Comment 11•8 years ago
|
||
Bug #1091592 probably regressed most of things stated in this bug.
Blocks: 1091592
Reporter | ||
Updated•8 years ago
|
Blocks: e10s-select
Comment 12•8 years ago
|
||
The spacing between items was a conscious design decision.
Flags: needinfo?(markgolbeck08)
Comment 13•8 years ago
|
||
Is it a regression that the popup uses a different font-family than the button in the page? What happened before this patch if the font-family on the page was set to Georgia, for example?
As Neil commented, the difference between e10s and non-e10s will be fixed with bug 1300784.
Flags: needinfo?(markgolbeck08)
Comment 14•8 years ago
|
||
The e10s team triaged a number of bugs about this. Basically we switched UI elements for the drop down, and because of that, the fonts and layout changed somewhat. The consensus was that the new layout was better. Regardless, we decided we would not attempt to fix these issues since e10s is replacing non-e10s so minor font/layout differences in the dropdown are irrelevant.
Status: NEW → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → WONTFIX
Reporter | ||
Comment 15•8 years ago
|
||
What are the reasons for:
-making font smaller
-making dropdown text using other font family than on button
-increasing that much space between items, which is useless on non-touch devices
-changing appearance to be inconsistent compared to other browser?
Comment 18•8 years ago
|
||
Hey Philipp, what do you think about the difference between the font being used on the button and what shows up in the popup?
You can look at https://bug1313418.bmoattachments.org/attachment.cgi?id=8805455 to see the difference. We didn't change the font on the button because we are worried about web compat.
Flags: needinfo?(philipp)
Reporter | ||
Comment 19•8 years ago
|
||
Please, see comment #15
Flags: needinfo?(markgolbeck08)
Flags: needinfo?(jmathies)
Comment 20•8 years ago
|
||
(In reply to Virtual_ManPL [:Virtual] - (ni? me) from comment #15)
> What are the reasons for:
> -making font smaller
> -making dropdown text using other font family than on button
> -increasing that much space between items, which is useless on non-touch
> devices
> -changing appearance to be inconsistent compared to other browser?
As I said, we switched UI elements and so the layout changed. Feel free to file bugs on individual issues.
Flags: needinfo?(jmathies)
Reporter | ||
Comment 21•8 years ago
|
||
OK, but I was hoping that we could omit bureaucracy and deal with these issues here... seems not. ;)
Updated•8 years ago
|
Flags: needinfo?(philipp)
Flags: needinfo?(markgolbeck08)
Comment 22•8 years ago
|
||
(In reply to Virtual_ManPL [:Virtual] - (ni? me) from comment #21)
> OK, but I was hoping that we could omit bureaucracy and deal with these
> issues here... seems not. ;)
Looks like we have newer regressions in this area due to the select styling and gpu changes, so not really the same styling issues we triaged under e10s.
Reporter | ||
Comment 23•8 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #22)
> (In reply to Virtual_ManPL [:Virtual] - (ni? me) from comment #21)
> > OK, but I was hoping that we could omit bureaucracy and deal with these
> > issues here... seems not. ;)
>
> Looks like we have newer regressions in this area due to the select styling
> and gpu changes, so not really the same styling issues we triaged under e10s.
I reported the GPU Process changes and regressions to select dropdown menu list (especially about these blurry and not sharp fonts in text) in bug #1315568,
but this bug wasn't about it, as it was reported before GPU Process was landed,
it's about regression from bug #1091592, which is now tracked separately as you wanted.
I am assuming bug 1300784 will fix this. Too late for 49 and 50, both are wontfix now.
Reporter | ||
Updated•8 years ago
|
Status: RESOLVED → VERIFIED
Has Regression Range: yes → ---
Has STR: yes → ---
status-firefox49:
wontfix → ---
status-firefox50:
wontfix → ---
status-firefox51:
affected → ---
status-firefox52:
affected → ---
status-firefox-esr45:
unaffected → ---
tracking-firefox50:
- → ---
tracking-firefox51:
- → ---
tracking-firefox52:
- → ---
No longer depends on: 1300784
Keywords: multiprocess,
regression,
ux-consistency,
ux-minimalism
Resolution: WONTFIX → DUPLICATE
Reporter | ||
Updated•8 years ago
|
Reporter | ||
Updated•7 years ago
|
Keywords: nightly-community
Reporter | ||
Updated•7 years ago
|
QA Contact: Virtual
You need to log in
before you can comment on or make changes to this bug.
Description
•