[e10s] Dropdown menu list is using wrong font family

VERIFIED FIXED in Firefox 52

Status

()

Core
Layout: Form Controls
P1
major
VERIFIED FIXED
9 months ago
23 days ago

People

(Reporter: Virtual, Assigned: jaws)

Tracking

(Blocks: 2 bugs, 5 keywords)

52 Branch
mozilla53
x86_64
Windows 7
multiprocess, nightly-community, regression, ux-consistency, ux-minimalism
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 unaffected, firefox-esr45 unaffected, firefox50 unaffected, firefox51 unaffected, firefox52+ verified, firefox53+ verified)

Details

(URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments, 1 obsolete attachment)

+++ This bug was initially created as a clone of Bug #1313418 +++

[Tracking Requested - why for this release]: Regression

STR:
1. Open this website page - https://bugzilla.mozilla.org/enter_bug.cgi?product=Core
2. Open second "Platform" dropdown menu list
3. See that font in text on dropdown menu list is using other font family than on button. It's consistency and compatibility issue, comparing to other browsers.
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox49: --- → unaffected
status-firefox50: --- → unaffected
status-firefox-esr45: --- → unaffected
status-firefox53: --- → affected
tracking-firefox53: --- → ?

Updated

9 months ago
Priority: -- → P1
(Assignee)

Updated

9 months ago
Duplicate of this bug: 1318543
(Assignee)

Updated

9 months ago
Assignee: nobody → markgolbeck08
Mentor: jaws@mozilla.com
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
(Assignee)

Comment 3

9 months ago
mozreview-review
Comment on attachment 8812173 [details]
Bug  1316404 Dropdown menu list is using wrong font family.

https://reviewboard.mozilla.org/r/94026/#review94172

This patch still doesn't look right. I'll put up a patch for this.
Attachment #8812173 - Flags: review?(jaws) → review-
(Assignee)

Updated

9 months ago
Attachment #8812173 - Flags: review?(mconley)
Actually, this looks to be unrelated to the changes that bug 1091592 introduced.
Assignee: markgolbeck08 → nobody
Mentor: jaws@mozilla.com
Status: ASSIGNED → NEW
(Assignee)

Updated

9 months ago
No longer blocks: 1091592
Tracking 53+ - we should show the correct font here.
tracking-firefox53: ? → +
Created attachment 8813833 [details]
potentially illustrative screenshot

Is the attached what you mean (ignore the oddity with the dropdown text being vertically compressed a bit; that's not what I saw outside the screenshot)?
(Assignee)

Updated

9 months ago
Attachment #8812173 - Attachment is obsolete: true
No longer depends on: 1313418
Comment hidden (mozreview-request)
(Assignee)

Updated

8 months ago
Assignee: nobody → jaws
Status: NEW → ASSIGNED
I checked on Linux that we don't need to make a similar change there. It doesn't look like a change needs to be made for OSX but I didn't confirm it.

Comment 9

8 months ago
mozreview-review
Comment on attachment 8818407 [details]
Bug 1316404 - Use font:-moz-list; on the e10s select popup to match the default font used by the associated select button.

https://reviewboard.mozilla.org/r/98476/#review98852

I tested on OS X, and it doesn't look like we need this there.

Thanks for the patch!
Attachment #8818407 - Flags: review?(mconley) → review+

Comment 10

8 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a9a8fb2f9cad
Use font:-moz-list; on the e10s select popup to match the default font used by the associated select button. r=mconley
Blocks: 1316405
Comment on attachment 8818407 [details]
Bug 1316404 - Use font:-moz-list; on the e10s select popup to match the default font used by the associated select button.

Approval Request Comment
[Feature/Bug causing the regression]: when the select popups were switched to the e10s implementation, the e10s implementation inherited the system fonts for the menutiems, causing the menuitems to no longer match the previous font that was used for the menuitems (windows only)
[User impact if declined]: On Windows the font of the popup doesn't match the font of the button for select elements.
[Is this code covered by automated tests?]: no, visual only
[Has the fix been verified in Nightly?]: not yet, just landed in autoland
[Needs manual test from QE? If yes, steps to reproduce]: shouldn't need manual testing from QE
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: css only change, just changes the font-family of the items in the popup to match what was previously shipped prior to v52
[String changes made/needed]: none
Attachment #8818407 - Flags: approval-mozilla-aurora?

Comment 12

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a9a8fb2f9cad
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Virtual, can you verify this is fixed for you in the current nightly?
Flags: needinfo?(virtual)
Sure.
I'm confirming that this bug and bug #1316405 are now fixed started with Firefox Nightly 53.0a1 (2016-12-15).
Now, waiting for patch uplifting to Aurora.

Thank you very much Jared Wein [:jaws]! \0/
Status: RESOLVED → VERIFIED
status-firefox53: fixed → verified
Flags: needinfo?(virtual)
Comment on attachment 8818407 [details]
Bug 1316404 - Use font:-moz-list; on the e10s select popup to match the default font used by the associated select button.

change font on windows e10s select popup to match non-e10s, for aurora52
Attachment #8818407 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(In reply to Virtual_ManPL [:Virtual] - (ni? me) from comment #14)
> Sure.
> I'm confirming that this bug and bug #1316405 are now fixed started with
> Firefox Nightly 53.0a1 (2016-12-15).
> Now, waiting for patch uplifting to Aurora.
> 
> Thank you very much Jared Wein [:jaws]! \0/

You are very welcome, and thank you again :)

Comment 17

8 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/44a934bd6938
status-firefox52: affected → fixed
tracking-firefox52: ? → +
status-firefox52: fixed → verified
Keywords: nightly-community
QA Contact: Virtual
You need to log in before you can comment on or make changes to this bug.