1316404 - [e10s] Dropdown menu list is using wrong font family

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P1)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

+++ This bug was initially created as a clone of Bug #1313418 +++

[Tracking Requested - why for this release]: Regression

STR:
1. Open this website page - https://bugzilla.mozilla.org/enter_bug.cgi?product=Core
2. Open second "Platform" dropdown menu list
3. See that font in text on dropdown menu list is using other font family than on button. It's consistency and compatibility issue, comparing to other browsers.

Comment 2

[Mark Golbeck]

Attachment: Bug 1316404 Dropdown menu list is using wrong font family.

Review commit: https://reviewboard.mozilla.org/r/94026/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94026/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8812173 [details]
Bug  1316404 Dropdown menu list is using wrong font family.

https://reviewboard.mozilla.org/r/94026/#review94172

This patch still doesn't look right. I'll put up a patch for this.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Actually, this looks to be unrelated to the changes that bug 1091592 introduced.

Comment 5

[Marcia Knous [:marcia]]

Tracking 53+ - we should show the correct font here.

Comment 6

[Andrew Overholt [:overholt]]

Attachment: potentially illustrative screenshot

Is the attached what you mean (ignore the oddity with the dropdown text being vertically compressed a bit; that's not what I saw outside the screenshot)?

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1316404 - Use font:-moz-list; on the e10s select popup to match the default font used by the associated select button.

Review commit: https://reviewboard.mozilla.org/r/98476/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98476/

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

I checked on Linux that we don't need to make a similar change there. It doesn't look like a change needs to be made for OSX but I didn't confirm it.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8818407 [details]
Bug 1316404 - Use font:-moz-list; on the e10s select popup to match the default font used by the associated select button.

https://reviewboard.mozilla.org/r/98476/#review98852

I tested on OS X, and it doesn't look like we need this there.

Thanks for the patch!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9a8fb2f9cad
Use font:-moz-list; on the e10s select popup to match the default font used by the associated select button. r=mconley

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8818407 [details]
Bug 1316404 - Use font:-moz-list; on the e10s select popup to match the default font used by the associated select button.

Approval Request Comment
[Feature/Bug causing the regression]: when the select popups were switched to the e10s implementation, the e10s implementation inherited the system fonts for the menutiems, causing the menuitems to no longer match the previous font that was used for the menuitems (windows only)
[User impact if declined]: On Windows the font of the popup doesn't match the font of the button for select elements.
[Is this code covered by automated tests?]: no, visual only
[Has the fix been verified in Nightly?]: not yet, just landed in autoland
[Needs manual test from QE? If yes, steps to reproduce]: shouldn't need manual testing from QE
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: css only change, just changes the font-family of the items in the popup to match what was previously shipped prior to v52
[String changes made/needed]: none

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a9a8fb2f9cad

Comment 13

[Julien Cristau [:jcristau]]

Virtual, can you verify this is fixed for you in the current nightly?

Comment 14

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Sure.
I'm confirming that this bug and bug #1316405 are now fixed started with Firefox Nightly 53.0a1 (2016-12-15).
Now, waiting for patch uplifting to Aurora.

Thank you very much Jared Wein [:jaws]! \0/

Comment 15

[Julien Cristau [:jcristau]]

Comment on attachment 8818407 [details]
Bug 1316404 - Use font:-moz-list; on the e10s select popup to match the default font used by the associated select button.

change font on windows e10s select popup to match non-e10s, for aurora52

Comment 16

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Virtual_ManPL [:Virtual] - (ni? me) from comment #14)
> Sure.
> I'm confirming that this bug and bug #1316405 are now fixed started with
> Firefox Nightly 53.0a1 (2016-12-15).
> Now, waiting for patch uplifting to Aurora.
> 
> Thank you very much Jared Wein [:jaws]! \0/

You are very welcome, and thank you again :)

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/44a934bd6938