Closed
Bug 1330698
Opened 9 years ago
Closed 9 years ago
WebIDL bindings should support Constructor(optional (USVString or something) foo = "")
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: baku, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
14.31 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Updated•9 years ago
|
|
Assignee | |
Comment 1•9 years ago
|
||
This is actually only a problem with a string literal default value for a union-type argument containing USVString. If the argument type is USVString we coerce the literal to be DOMString-typed, so there is no problem. But in the union case we have to give the literal the type of the thing it matched inside the union, which is what causes the issue.
Summary: WebIDL bindings should support Constructor(optional USVString foo = "") → WebIDL bindings should support Constructor(optional (USVString or something) foo = "")
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8826259 -
Flags: review?(kyle)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
||
Updated•9 years ago
|
Attachment #8826259 -
Flags: review?(kyle) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b75e432a3b77
Support string default values for unions containing USVString. r=qdot
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•