1332981 - [EME][Fennec] Pref on EME API not only for Nightly build.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect, P2)

Description

[James Cheng[:JamesCheng]]

Bug 1267141 will put the clearkey CDM into Fennec.

and Bug 1149374 will start to enable the related EME test cases.

Here is the test result which runs the test case 20 times

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb87066e573698aaf4045cb8bfe49eb4302c0426

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1332981 - [EME][Fennec] Pref on EME API not only for Nightly build.

Review commit: https://reviewboard.mozilla.org/r/106424/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106424/

Comment 2

[James Cheng[:JamesCheng]]

Update treeherder result since the EME test only runs on real device.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b4b2899ab104941f203b004f25c7accc6c6be74

It seems "test_eme_request_notifications.html" expects widevine CDM did not install but on Android real device Widevine CDM is available.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8829324 [details]
Bug 1332981 - [EME][Fennec] Pref on EME API not only for Nightly build.

https://reviewboard.mozilla.org/r/106424/#review107998

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcf8aab15bda
[EME][Fennec] Pref on EME API not only for Nightly build. r=cpearce

Comment 5

[James Cheng[:JamesCheng]]

Comment on attachment 8829324 [details]
Bug 1332981 - [EME][Fennec] Pref on EME API not only for Nightly build.

The uplift request is to fix the error described in Bug 1333315 comment 2. 

Approval Request Comment
[Feature/Bug causing the regression]:Bug 1333315
[User impact if declined]:No
[Is this code covered by automated tests?]:Yes
[Has the fix been verified in Nightly?]:Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]:No
[Is the change risky?]:No
[Why is the change risky/not risky?]:It is only a fix for fixing the try fail described in Bug 1333315.
[String changes made/needed]:No

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bcf8aab15bda

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 8829324 [details]
Bug 1332981 - [EME][Fennec] Pref on EME API not only for Nightly build.

enable EME for fennec in aurora53

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Release Note Request (optional, but appreciated)
[Why is this notable]: EME enabled on adnroid
[Affects Firefox for Android]: yes, specific android
[Suggested wording]: EME enabled on Firefox for Android
[Links (documentation, blog post, etc)]: ? the MDN doc?

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9e940073dc84

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Added to Fx53 Aurora release notes.

Comment 12

[Gerry Chang [:gchang]]

According to bug 1340172, EME will only be enabled in nightly. Remove release note flag for 53.

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Thanks for catching that Gerry! I removed the relnote.