1338239 - Remove tc() prefix from platforms that no longer exist in buildbot

Status: RESOLVED DUPLICATE of bug 1386857

(Infrastructure & Operations Graveyard :: CIDuty, task, P5)

Description

[Michael Shal [:mshal]]

Some platforms now run solely in Taskcluster and have no buildbot jobs. Similar to bug 1295962, I think we should remove the tc() prefix for platforms where nothing is running on buildbot.

My motivation here is primarily to find things like the build task more easily. For example a Windows build might look like:

B Cpp Gtest ... T(+8) ...

But Linux x64 opt currently looks like:

S Sm-tc(+4) T(+9) T-e10s(+9) tc(+11) tc-Fxfn-l(en-US) tc-Fxfn-l-e10s(en-US)

In this case the build job is much harder to find - instead of a prominent B at the beginning of the list, it's hidden under the tc() group in the middle somewhere.

Any objections to start doing this now? Or is it helpful to look at treeherder and see things that aren't tc-prefixed and realize that we still need to convert them?

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

I'm keen to do this.  I suppose sheriffs would be th emost likely to have objections.

Comment 2

[Kim Moir [:kmoir] ET]

Sheriffs, do you have any objections to this?  If not, I'll get buildduty to write the patches

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Sounds good to me. I was just wondering about this recently.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Ship it.

Comment 5

[Alin Selagea [:aselagea]]

I spent some time investigating this, but unfortunately I don't see an easy way to remove the 'tc' prefix for the TC jobs that are no longer running in BB.

e.g. https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/test/tests.yml#8
As it can be noticed above, the Treeherder symbol is defined for the entire test suite, so removing it will affect the way TC jobs appear in Treeherder for all the platforms. That may be OK for Linux, since most of the jobs there run solely on TC, but it won't be fine for OS X and Windows as it'll only make it more difficult to distinguish between TC and BB jobs. 

Besides that, there still are several branches where most of the jobs are run by BB (e.g. ESR branches, mozilla-release), so that'll make things a bit more complicated as well.

Some input here will be much appreciated before going forward with this, so ni-ing Dustin and Michael.

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Probably the right way to do this is to remove the prefix everywhere, then re-add it in a transform for platforms that aren't yet ported.  That transform would be in `taskcluster/taskgraph/transforms/tests.py`

Changes like this ride the trains, so they won't land immediately on mozilla-release and certainly not on ESR, so that's not a big worry.

Comment 7

[Michael Shal [:mshal]]

(In reply to Dustin J. Mitchell [:dustin] from comment #6)
> Probably the right way to do this is to remove the prefix everywhere, then
> re-add it in a transform for platforms that aren't yet ported.  That
> transform would be in `taskcluster/taskgraph/transforms/tests.py`
> 
> Changes like this ride the trains, so they won't land immediately on
> mozilla-release and certainly not on ESR, so that's not a big worry.

I agree on all points :). Personally I don't mind if other branches take a few cycles to get updated, so we can just fix it in central and not worry about the others.

Comment 9

[Mihai Tabara [:mtabara]⌚️GMT]

This is a good bug for learning how to handle with TC transforms.

Note explaining the priority level: P5 doesn't mean we've lowered the priority, but the contrary. However, we're aligning these levels to the buildduty quarterly deliverables, where P1-P3 are taken by our daily waterline KTLO operational tasks.

Comment 10

[Alin Selagea [:aselagea]]

Fyi, I'm not currently working on this and would probably be a good exercise for the new buildduty folks.

Comment 11

[Firefox Bug Husbandry Bot]

Bulk change of QA Contact to :jlund, per https://bugzilla.mozilla.org/show_bug.cgi?id=1428483

Comment 12

[Roland Mutter Michael (:rmutter)]

Seems like the issue was solved in bug #1386857