1339182 - Remove OSX universal support in the build system

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Shal [:mshal]]

test_unify.py is currently the only test under python/mozbuild/mozpack that fails to run without an objdir, which means its harder to split them out into their own test job. Since this test just verifies the UnifiedFinder / UnifiedBuildFinder classes that we don't use anymore since bug 1295375, I think we should remove it. We mind as well remove the packaging code as well, unless https://bugzilla.mozilla.org/show_bug.cgi?id=1295375#c1 is still a concern. If so we can just remove the test file.

Comment 1

[Michael Shal [:mshal]]

Attachment: Bug 1339182 - Remove OSX universal support in the build system;

This removes the UNIFY_DIST and UNIFIED_BUILD variables, as well as the
--unify flag from the packager and UnifiedBuildFinder from mozpack. As a
result the STAGEPATH varibale is never defined anymore, so its uses can
be removed as well.

test_unify.py is currently the only mozbuild/mozpack test that fails
without running configure first, and there isn't much point in fixing
tests for things that we don't actually use anymore.

Review commit: https://reviewboard.mozilla.org/r/112150/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112150/

Comment 2

[(not currently active) Ted Mielczarek]

We should just start removing universal build support.

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8836836 [details]
Bug 1339182 - Remove OSX universal support in the build system;

https://reviewboard.mozilla.org/r/112150/#review113994

You have a typo in the commit message (varibale)

Comment 4

[Michael Shal [:mshal]]

Comment on attachment 8836836 [details]
Bug 1339182 - Remove OSX universal support in the build system;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/112150/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d88a5673b1f7
Remove OSX universal support in the build system; r=glandium

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d88a5673b1f7

Comment 7

[Jorg K (CEST = GMT+2)]

Are you going to remove browser/config/mozconfigs/macosx-universal one day?

Comment 8

[Michael Shal [:mshal]]

(In reply to Jorg K (GMT+1) from comment #7)
> Are you going to remove browser/config/mozconfigs/macosx-universal one day?

I think we can once we no longer build macosx-universal on any tree. I think the m-c configs still play a role in the merge-day scripts, so I didn't want to mess with those yet. jlund can shed more light here - is it ok to remove these mozconfigs now or will that cause issues with universal builds on beta/release trees?

Comment 9

[Jordan Lund (:jlund)]

should be safe to remove all mozconfigs from central and aurora after a quick eyeball at release/merge automation. thanks for checking!