Remove OSX universal support in the build system

RESOLVED FIXED in Firefox 54

Status

defect
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: mshal, Assigned: mshal)

Tracking

(Blocks 1 bug)

unspecified
mozilla54
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

test_unify.py is currently the only test under python/mozbuild/mozpack that fails to run without an objdir, which means its harder to split them out into their own test job. Since this test just verifies the UnifiedFinder / UnifiedBuildFinder classes that we don't use anymore since bug 1295375, I think we should remove it. We mind as well remove the packaging code as well, unless https://bugzilla.mozilla.org/show_bug.cgi?id=1295375#c1 is still a concern. If so we can just remove the test file.
We should just start removing universal build support.
Comment on attachment 8836836 [details]
Bug 1339182 - Remove OSX universal support in the build system;

https://reviewboard.mozilla.org/r/112150/#review113994

You have a typo in the commit message (varibale)
Attachment #8836836 - Flags: review?(mh+mozilla) → review+
Depends on: 1295375
Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d88a5673b1f7
Remove OSX universal support in the build system; r=glandium
https://hg.mozilla.org/mozilla-central/rev/d88a5673b1f7
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Are you going to remove browser/config/mozconfigs/macosx-universal one day?
Flags: needinfo?(ted)
(In reply to Jorg K (GMT+1) from comment #7)
> Are you going to remove browser/config/mozconfigs/macosx-universal one day?

I think we can once we no longer build macosx-universal on any tree. I think the m-c configs still play a role in the merge-day scripts, so I didn't want to mess with those yet. jlund can shed more light here - is it ok to remove these mozconfigs now or will that cause issues with universal builds on beta/release trees?
Flags: needinfo?(ted) → needinfo?(jlund)
should be safe to remove all mozconfigs from central and aurora after a quick eyeball at release/merge automation. thanks for checking!
Flags: needinfo?(jlund)
Blocks: 1342911
Blocks: 1412431
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.