1343519 - Clean up some of eslint-plugin-mozilla - change some rules to be environments and automatically parse global-scripts.inc

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Mark Banner (:standard8)]

I've discovered that we can move some more of our rules to be environments - which will be better as it'll just be a one-off cost for setup.

Additionally in doing this I think we can introduce parsing of global-scripts.inc which means we shouldn't have to update the list of imported scripts too often (which will also help the no-undef work).

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1343519 - Change some function calls from using 'this' to 'context' in the eslint-plugin-mozilla code so that it works correctly when timing rule lengths.

Review commit: https://reviewboard.mozilla.org/r/116386/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116386/

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1343519 - Change the ESLint rule 'import-browserjs-globals' to be an environment (mozilla/browser-window) to better describe the purpose of it.

Review commit: https://reviewboard.mozilla.org/r/116388/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116388/

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1343519 - Change the ESLint rule 'import-test-globals' to be an environment (mozilla/simpletest) to better describe the purpose of it.

Review commit: https://reviewboard.mozilla.org/r/116390/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116390/

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1343519 - Change the ESLint browser-window environment to determine most of the scripts for globals by parsing global-scripts.inc.

Review commit: https://reviewboard.mozilla.org/r/116392/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116392/

Comment 5

[Mark Banner (:standard8)]

Note: For eslint to pass, this also needs bug 1343521 (which is currently on autoland). Otherwise you get "Read-only global 'Social' should not be modified  no-native-reassign" which is due to better detection of globals and not allowing them to be modified when they shouldn't be.

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 8842610 [details]
Bug 1343519 - Change some function calls from using 'this' to 'context' in the eslint-plugin-mozilla code so that it works correctly when timing rule lengths.

https://reviewboard.mozilla.org/r/116386/#review118016

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 8842611 [details]
Bug 1343519 - Change the ESLint rule 'import-browserjs-globals' to be an environment (mozilla/browser-window) to better describe the purpose of it.

https://reviewboard.mozilla.org/r/116388/#review118072

Comment 8

[Dave Townsend [:mossop]]

Comment on attachment 8842612 [details]
Bug 1343519 - Change the ESLint rule 'import-test-globals' to be an environment (mozilla/simpletest) to better describe the purpose of it.

https://reviewboard.mozilla.org/r/116390/#review118074

Comment 9

[Dave Townsend [:mossop]]

Comment on attachment 8842613 [details]
Bug 1343519 - Change the ESLint browser-window environment to determine most of the scripts for globals by parsing global-scripts.inc.

https://reviewboard.mozilla.org/r/116392/#review118076

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64ebe0113929
Change some function calls from using 'this' to 'context' in the eslint-plugin-mozilla code so that it works correctly when timing rule lengths. r=mossop
https://hg.mozilla.org/integration/autoland/rev/563299ade2ae
Change the ESLint rule 'import-browserjs-globals' to be an environment (mozilla/browser-window) to better describe the purpose of it. r=mossop
https://hg.mozilla.org/integration/autoland/rev/8dbddf1d169e
Change the ESLint rule 'import-test-globals' to be an environment (mozilla/simpletest) to better describe the purpose of it. r=mossop
https://hg.mozilla.org/integration/autoland/rev/72b573571f72
Change the ESLint browser-window environment to determine most of the scripts for globals by parsing global-scripts.inc. r=mossop

Comment 11

[Mark Banner (:standard8)]

Attachment: Bump the eslint-plugin-mozilla version

I forgot to bump the version number when I was moving patches around. This fixes that.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/180a160ae22a
Bump the version number for eslint-plugin-mozilla for the changes. r=bustage-fix-for-developers a=tomcat

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/64ebe0113929
https://hg.mozilla.org/mozilla-central/rev/563299ade2ae
https://hg.mozilla.org/mozilla-central/rev/8dbddf1d169e
https://hg.mozilla.org/mozilla-central/rev/72b573571f72
https://hg.mozilla.org/mozilla-central/rev/180a160ae22a