|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
Created attachment 8850895 [details] 2017-03-24_1136.png [Affected versions]: Firefox 55.0a1 (2017-03-23) Firefox 54.0a2 (2017-03-23) Firefox 53.0b6 (20170323121323) [Affected platforms]: Windows 10 64-bit Ubuntu 16.04 32-bit [Steps to reproduce]: 1.Launch Firefox with clean profile. 2.Create extensions.webextPermissionPrompts and set it to true. 3.Create xpinstall.signatures.dev-root and set it to true. 4.Restart the browser. 5.Click on “+ Add to Firefox” button to install the following webextension: https://addons-dev.allizom.org/en-US/firefox/addon/9gag-mini-permissions/ [Expected Results]: http://*/* and https://*/* permissions displays together only one description. [Actual Results]: - The same description appears twice, one for each permission. - See attached screenshot. [Additional Notes]: - This issue also reproduce for domains specified in "content_scripts" field. - Here is a screenshot about how Chrome behaves using the same extension: https://www.screencast.com/t/geDlQFFVRj
dev doc is to use * instead of permissions for both http or https
The fix here is pretty straightforward: use Sets instead of arrays to keep track of hosts and domains inside ExtensionsUI._buildStrings(). ie here: http://searchfox.org/mozilla-central/rev/4bd7a206dea5382c97a8a0c30beef668cc449f5b/browser/modules/ExtensionsUI.jsm#242
This also applies to hosts that appear in the "content_scripts" section of the manifest, as reported in bug 1363263
Comment on attachment 8888879 [details] Bug 1350277 remove duplicates when showing host permissons https://reviewboard.mozilla.org/r/159904/#review169054 Nice, thanks, but can you please apply the same logic to wildcard/domain permissions?
Thanks, updated per feedback to do the wildcard check. The xpi change just removes the signing as thats unneccesary these days and changes the manifest to have a matching http and https single host and wildcard domain.
Comment on attachment 8888879 [details] Bug 1350277 remove duplicates when showing host permissons https://reviewboard.mozilla.org/r/159904/#review184034 ::: commit-message-e99e3:1 (Diff revision 4) > +bug 1350277 ignore protocol when showing host permissons r?aswan Capitalize Bug and the summary. Although we already ignore the protocol, this is about weeding out duplciates -- update the summary to describe that more clearly?
Autoland can't push this until all pending issues in MozReview are marked as resolved.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/2b74ec6bb1d8 remove duplicates when showing host permissons r=aswan
Turns out I do have to sign this add-on, the failures were checking if the extension was signed or not. I've signed the extension and run a try build. Looks good apart from those unrelated oranges.
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s cd4094992fe5 -d 9219c2f933e2: rebasing 419919:cd4094992fe5 "Bug 1350277 remove duplicates when showing host permissons r=aswan" (tip) merging browser/base/content/test/webextensions/browser_webext_permissions.xpi merging toolkit/components/extensions/Extension.jsm warning: /repos/mozreview-gecko/browser/base/content/test/webextensions/browser_webext_permissions.xpi looks like a binary file. warning: conflicts while merging browser/base/content/test/webextensions/browser_webext_permissions.xpi! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/41effc9b8c27 Remove duplicates when showing host permissons. r=aswan
(In reply to Mozilla Autoland from comment #27) > We're sorry, Autoland could not rebase your commits for you automatically. > Please manually rebase your commits and try again. > > hg error in cmd: hg rebase -s cd4094992fe5 -d 9219c2f933e2: rebasing > 419919:cd4094992fe5 "Bug 1350277 remove duplicates when showing host > permissons r=aswan" (tip) > merging > browser/base/content/test/webextensions/browser_webext_permissions.xpi > merging toolkit/components/extensions/Extension.jsm > warning: > /repos/mozreview-gecko/browser/base/content/test/webextensions/ > browser_webext_permissions.xpi looks like a binary file. > warning: conflicts while merging > browser/base/content/test/webextensions/browser_webext_permissions.xpi! > (edit, then use 'hg resolve --mark') > unresolved conflicts (see hg resolve, then hg rebase --continue) I manually imported the commit and was able to apply and push it without issue. Was Autoland trying to rebase a binary file or something here?
Filed bug 1400377 to track the autoland issue.
Created attachment 8909753 [details] 2017-09-19_1518.png I confirm that this issue is fixed on Firefox 57.0a1 (20170918220054) under Windows 10 64-bit and Mac OS X 10.12.3. There are no longer duplicated permissions displayed in webextension installation pop-up. See screenshot.
a month ago
I'm not sure what developer documentation is needed here, can you elaborate please?
(In reply to Will Bamberg [:wbamberg] from comment #34) > I'm not sure what developer documentation is needed here, can you elaborate > please? I think there was a suggestion a while back that before this bug was fixed, extension authors could work around this bug by using *://foo.com/ instead of listing both http://foo.com/ and https://foo.com/ I do agree that it doesn't seem like there's much to add now that this is fixed...
Thanks aswan. For reference: dev-doc-needed is for bugs that deliver a new feature (or fix) that will need documenting. As such we don't look at the bug until it has been marked fixed. So adding dev-doc-needed to ask for documentation of a workaround that won't be needed after that bug is fixed will not have the desired effect. In a situation like this it's better to raise a documentation bug: https://bugzilla.mozilla.org/enter_bug.cgi?product=Developer%20Documentation.