1351512 - Stop using CPOWs in tests

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Blake Kaplan (:mrbkap) (inactive)]

This is a tracking bug for work relating to removing CPOW usage from our tests. This should include shim usage as well.

Comment 1

[Benjamin Smedberg]

Adding some data from IRC:

<bsmedberg> mconley, I was surprised this morning that mochitests were still using/allowed to use CPOWs
<mconley> bsmedberg: yeah, there was an effort by mrbkap at one point to pare that down, but e10s-multi kinda took over
<mrbkap> mconley: bsmedberg: I'm still going through myself and fixing them
<mrbkap> But there's a lot.
<bsmedberg> mrbkap, if you have a list, that's something the platform QA group may be able to help with
<mrbkap> bsmedberg: I can regenerate one and send it to you.
<bsmedberg> mrbkap, or even just tell me how you generate the list
<mrbkap> bsmedberg: I push to try with a patch that makes the CPOW code log stacks and run https://github.com/mrbkap/cpow-log-parser on the resulting logs.
<mrbkap> bsmedberg: https://pastebin.mozilla.org/8983426 is the patch to get logs with stacks

I have pushed a try build with this patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=244cf21b8d2c833275a77fec3b0e820db7260b1b

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: cpows from bsmedberg's push

Comment 3

[Mark Banner (:standard8)]

Just to note, in bug 1412778 I am expanding the no-cpows-in-tests ESLint rule across the whole tree (where ESLint is currently enabled). This should reduced more instances being created. Existing instances are whitelisted and can be found here:

http://searchfox.org/mozilla-central/search?q=mozilla%2Fno-cpows-in-tests&case=false&regexp=false

There may be some false-positives in that list, there may also be instances of things we aren't catching. If there's more things we want to catch, please file a bug in Testing:Lint.

Comment 4

[Tom S [:evilpie]]

Are there really only 8 cases left? It would be good to completely remove CPOW usage from tests.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

It looks like https://searchfox.org/mozilla-central/search?q=uses-unsafe-cpows&path= might be the current list of cpow-using tests.