Closed Bug 1631358 Opened 3 months ago Closed 3 months ago

Remove support for CPOWs and sendRpcMessage from message managers

Categories

(Core :: DOM: Content Processes, defect)

defect

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

AFAICT we don't have any actual consumers left. I have a green-ish trypush.

The dependency on bug 1614462 is not a very strong one; it's just that the first patch removes support for the extra principal argument, and so it touches some of the same code.

dom.js and listener.js pass around target pointing to an event target,
using CPOWs, but the implementation of WebElementEventTarget then always
overrides that with this anyway, so there's no point. This change removes
the handling of objects/target.

Depends on D71512

This commit:

  • removes sendRpcMessage, which was unused;
  • removes the CPOW argument to sendAsyncMessage, broadcastAsyncMessage, and
    sendSyncMessage;
  • removes the aIsSync argument used internally to distinguish sendRpcMessage
    and sendSyncMessage;
  • removes CPOW tests;
  • updates the few remaining callsites that use more than 2 arguments in
    sendAsyncMessage for the removal of the cpows argument.

Depends on D71513

Blocks: 1351512
Blocks: 1590090
Blocks: 1631792
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9a52ba06953d
remove traces of CPOWs from devtools, r=jdescottes,loganfsmyth
https://hg.mozilla.org/integration/autoland/rev/dfbc67734d16
remove traces of CPOWs from browser/, testing/ and toolkit/, r=mconley
https://hg.mozilla.org/integration/autoland/rev/934d69727bf4
make it clearer we don't use CPOWs in pwmgr code, r=jaws
https://hg.mozilla.org/integration/autoland/rev/1e3aec08e4ec
remove CPOW handling in marionette r=marionette-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/b6848f971b57
remove CPOW support in the message manager, r=mccr8
Component: IPC → DOM: Content Processes
Blocks: 1632264
You need to log in before you can comment on or make changes to this bug.