1631358 - Remove support for CPOWs and sendRpcMessage from message managers

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[:Gijs (he/him)]

AFAICT we don't have any actual consumers left. I have a green-ish trypush.

The dependency on bug 1614462 is not a very strong one; it's just that the first patch removes support for the extra principal argument, and so it touches some of the same code.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1631358 - remove traces of CPOWs from devtools, r?jdescottes!,loganfsmyth!

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1631358 - remove traces of CPOWs from browser/, testing/ and toolkit/, r?mconley

Depends on D71509

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1631358 - make it clearer we don't use CPOWs in pwmgr code, r?jaws

Depends on D71510

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1631358 - remove CPOW handling in marionette

dom.js and listener.js pass around target pointing to an event target,
using CPOWs, but the implementation of WebElementEventTarget then always
overrides that with this anyway, so there's no point. This change removes
the handling of objects/target.

Depends on D71512

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1631358 - remove CPOW support in the message manager, r?mccr8

This commit:

• removes sendRpcMessage, which was unused;
• removes the CPOW argument to sendAsyncMessage, broadcastAsyncMessage, and
  sendSyncMessage;
• removes the aIsSync argument used internally to distinguish sendRpcMessage
  and sendSyncMessage;
• removes CPOW tests;
• updates the few remaining callsites that use more than 2 arguments in
  sendAsyncMessage for the removal of the cpows argument.

Depends on D71513

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a52ba06953d
remove traces of CPOWs from devtools, r=jdescottes,loganfsmyth
https://hg.mozilla.org/integration/autoland/rev/dfbc67734d16
remove traces of CPOWs from browser/, testing/ and toolkit/, r=mconley
https://hg.mozilla.org/integration/autoland/rev/934d69727bf4
make it clearer we don't use CPOWs in pwmgr code, r=jaws
https://hg.mozilla.org/integration/autoland/rev/1e3aec08e4ec
remove CPOW handling in marionette r=marionette-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/b6848f971b57
remove CPOW support in the message manager, r=mccr8

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/9a52ba06953d
https://hg.mozilla.org/mozilla-central/rev/dfbc67734d16
https://hg.mozilla.org/mozilla-central/rev/934d69727bf4
https://hg.mozilla.org/mozilla-central/rev/1e3aec08e4ec
https://hg.mozilla.org/mozilla-central/rev/b6848f971b57