Add -Wl,-z,relro linker flags

RESOLVED FIXED in Firefox 56

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tjr, Assigned: glandium)

Tracking

(Blocks 2 bugs, {sec-want})

Trunk
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [sg:want][adv-main56-])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
This bug was created as a clone Bug 620058 which contains more context.
(Reporter)

Updated

2 years ago
Depends on: 1359918
(Reporter)

Updated

2 years ago
Depends on: 1359920
(Reporter)

Updated

2 years ago
Depends on: 1359926
(Reporter)

Updated

2 years ago
Depends on: 1359928
(Reporter)

Updated

2 years ago
Depends on: 1360299
(Reporter)

Updated

2 years ago
Depends on: 1360300
(Reporter)

Updated

2 years ago
Depends on: 1360301
(Reporter)

Updated

2 years ago
No longer depends on: 1359918
(Reporter)

Updated

2 years ago
No longer depends on: 1360301
(Reporter)

Updated

2 years ago
No longer depends on: 1360300
(Reporter)

Updated

2 years ago
No longer depends on: 1360299
(Reporter)

Updated

2 years ago
No longer blocks: 1359905
No longer depends on: 1359920, 1359926, 1359928, 671426
(Reporter)

Updated

2 years ago
Depends on: 635961
(Assignee)

Updated

2 years ago
Depends on: 1384314
(Assignee)

Updated

2 years ago
Assignee: nobody → mh+mozilla
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8890094 [details]
Bug 1359912 - Add -z relro linker flags.

https://reviewboard.mozilla.org/r/161168/#review166552

Yay for minor security wins!

But the Try push is on fire, so no r+.

Also, do you need to announce this when it lands because it could introduce new classes of crashes due to a segfault accessing a (now) read-only segment? Will the crash signature make this obvious?
Attachment #8890094 - Flags: review?(gps) → review-
Comment hidden (mozreview-request)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8890094 [details]
Bug 1359912 - Add -z relro linker flags.

https://reviewboard.mozilla.org/r/161168/#review166600

This patch didn't change. But I trust you and enough eyes are on other code related to this that I feel comfortable giving this my stamp of approval.
Attachment #8890094 - Flags: review?(gps) → review+

Comment 5

2 years ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/adb09e2d7a30
Add -z relro linker flags. r=gps
This busted noopt debug builds on linux like https://treeherder.mozilla.org/logviewer.html#?job_id=118224316&repo=autoland

Backed out.
Flags: needinfo?(mh+mozilla)

Comment 7

2 years ago
Backout by kwierso@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ab2472a1042b
Backed out changeset adb09e2d7a30 for breaking linux noopt debug builds a=backout
(Assignee)

Updated

2 years ago
Depends on: 1385117

Comment 8

2 years ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/465b7a02cb33
Add -z relro linker flags. r=gps
(Assignee)

Updated

2 years ago
Blocks: 1359918

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/465b7a02cb33
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
(Assignee)

Updated

2 years ago
Flags: needinfo?(mh+mozilla)
Whiteboard: [sg:want] → [sg:want][adv-main56-]
You need to log in before you can comment on or make changes to this bug.