Closed
Bug 1359912
Opened 7 years ago
Closed 7 years ago
Add -Wl,-z,relro linker flags
Categories
(Core :: Security, enhancement)
Core
Security
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: tjr, Assigned: glandium)
References
(Blocks 1 open bug)
Details
(Keywords: sec-want, Whiteboard: [sg:want][adv-main56-])
Attachments
(1 file)
This bug was created as a clone Bug 620058 which contains more context.
Updated•7 years ago
|
No longer blocks: b2gSystemSecurity
Updated•7 years ago
|
status-firefox57:
affected → ---
Reporter | ||
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → mh+mozilla
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8890094 [details] Bug 1359912 - Add -z relro linker flags. https://reviewboard.mozilla.org/r/161168/#review166552 Yay for minor security wins! But the Try push is on fire, so no r+. Also, do you need to announce this when it lands because it could introduce new classes of crashes due to a segfault accessing a (now) read-only segment? Will the crash signature make this obvious?
Attachment #8890094 -
Flags: review?(gps) → review-
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8890094 [details] Bug 1359912 - Add -z relro linker flags. https://reviewboard.mozilla.org/r/161168/#review166600 This patch didn't change. But I trust you and enough eyes are on other code related to this that I feel comfortable giving this my stamp of approval.
Attachment #8890094 -
Flags: review?(gps) → review+
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/adb09e2d7a30 Add -z relro linker flags. r=gps
This busted noopt debug builds on linux like https://treeherder.mozilla.org/logviewer.html#?job_id=118224316&repo=autoland Backed out.
Flags: needinfo?(mh+mozilla)
Backout by kwierso@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ab2472a1042b Backed out changeset adb09e2d7a30 for breaking linux noopt debug builds a=backout
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/465b7a02cb33 Add -z relro linker flags. r=gps
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/465b7a02cb33
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(mh+mozilla)
Comment 10•7 years ago
|
||
https://hg.mozilla.org/projects/jamun/rev/465b7a02cb336ac45c43664f2198bf6cd225132b Bug 1359912 - Add -z relro linker flags. r=gps
Updated•7 years ago
|
Whiteboard: [sg:want] → [sg:want][adv-main56-]
You need to log in
before you can comment on or make changes to this bug.
Description
•