1359918 - Add -Wl,-z,now Linker Flags

Status: RESOLVED FIXED

(Core :: Security, enhancement, P3)

Description

[Tom Ritter [:tjr]]

This bug was created as a clone Bug 620058 which has more context.

More info: https://wiki.debian.org/Hardening#DEB_BUILD_HARDENING_BINDNOW_.28ld_-z_now.29

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1359918 - Add -z now linker flags.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5de1d0915a4
Add -z now linker flags. r=firefox-build-system-reviewers,andi

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e5de1d0915a4

Comment 4

[Matthew Turnbull [Bluefang]]

I think this regressed compatibility with GTK built without wayland support. See Bug 1746715

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing regression (bug 1746715)

Backout link: https://hg.mozilla.org/integration/autoland/rev/6dce48ad74565f2d1f8c4f9ff5a55feafa48a99f

Comment 6

[Cristian Tuns]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/6dce48ad7456

Comment 7

[Mike Hommey [:glandium]]

Have we seen any perf regressions from this, between the landing and the backout?

Comment 8

[Alexandru Ionescu (needinfo me) [:alexandrui]]

I didn't so far.

Comment 9

[Andra Esanu (needinfo me)]

I haven't seen any either.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:glandium, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1a486575f57
Add -z now linker flags. r=firefox-build-system-reviewers,andi

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f1a486575f57