1360299 - --enable-hardening should imply --enable-pie

Status: RESOLVED FIXED

(Core :: Security, enhancement)

Description

[Tom Ritter [:tjr]]

This bug was created as a clone of Bug #620058 which has more context.

Comment 1

[Alex Gaynor [:Alex_Gaynor]]

Attachment: Bug 1360299 - When --enable-hardening is used, --enable-pie will be automatically enabled

Review commit: https://reviewboard.mozilla.org/r/135246/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135246/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8863458 [details]
Bug 1360299 - When --enable-hardening is used, --enable-pie will be automatically enabled

https://reviewboard.mozilla.org/r/135246/#review138156

Since this is imply_option'ing a thing from the old-configure.in world, would you confirm that either:

1. config.status contains the appropriate PIE flags after compiling with `--enable-hardening`; or
2. (paranoia) firefox and related executables are PIE executables after building with `--enable-hardening`.

The above should Just Work, but you never know...  Thanks!

Comment 3

[Alex Gaynor [:Alex_Gaynor]]

Comment on attachment 8863458 [details]
Bug 1360299 - When --enable-hardening is used, --enable-pie will be automatically enabled

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135246/diff/1-2/

Comment 4

[Alex Gaynor [:Alex_Gaynor]]

Comment on attachment 8863458 [details]
Bug 1360299 - When --enable-hardening is used, --enable-pie will be automatically enabled

https://reviewboard.mozilla.org/r/135246/#review138156

Confirmed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9e0e0d49ced
When --enable-hardening is used, --enable-pie will be automatically enabled r=froydnj

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f9e0e0d49ced