--enable-hardening should imply --enable-pie

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tjr, Assigned: Alex_Gaynor)

Tracking

(Blocks 1 bug, {sec-want})

Trunk
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [sg:want][adv-main55-])

Attachments

(1 attachment)

Reporter

Description

2 years ago
This bug was created as a clone of Bug #620058 which has more context.
Reporter

Updated

2 years ago
No longer blocks: 1359918
Reporter

Updated

2 years ago
No longer depends on: 671426
Assignee

Updated

2 years ago
Attachment #8863458 - Flags: review?(nfroyd)
Assignee

Updated

2 years ago
Assignee: nobody → agaynor

Comment 2

2 years ago
mozreview-review
Comment on attachment 8863458 [details]
Bug 1360299 - When --enable-hardening is used, --enable-pie will be automatically enabled

https://reviewboard.mozilla.org/r/135246/#review138156

Since this is imply_option'ing a thing from the old-configure.in world, would you confirm that either:

1. config.status contains the appropriate PIE flags after compiling with `--enable-hardening`; or
2. (paranoia) firefox and related executables are PIE executables after building with `--enable-hardening`.

The above should Just Work, but you never know...  Thanks!
Attachment #8863458 - Flags: review?(nfroyd) → review+
Comment hidden (mozreview-request)
Assignee

Comment 4

2 years ago
mozreview-review-reply
Comment on attachment 8863458 [details]
Bug 1360299 - When --enable-hardening is used, --enable-pie will be automatically enabled

https://reviewboard.mozilla.org/r/135246/#review138156

Confirmed.
Assignee

Updated

2 years ago
Keywords: checkin-needed

Comment 5

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f9e0e0d49ced
When --enable-hardening is used, --enable-pie will be automatically enabled r=froydnj
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f9e0e0d49ced
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Depends on: 1361889
Whiteboard: [sg:want] → [sg:want][adv-main55-]
You need to log in before you can comment on or make changes to this bug.