Closed Bug 1360299 Opened 4 years ago Closed 4 years ago

--enable-hardening should imply --enable-pie

Categories

(Core :: Security, enhancement)

Product:
Core
Component:
Security
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: tjr, Assigned: Alex_Gaynor)

References

(Blocks 1 open bug)

Details

(Keywords: sec-want, Whiteboard: [sg:want][adv-main55-])

Attachments

(1 file)

Bug 1360299 - When --enable-hardening is used, --enable-pie will be automatically enabled
59 bytes, text/x-review-board-request
froydnj
: review+
Details 
This bug was created as a clone of Bug #620058 which has more context.
Attachment #8863458 - Flags: review?(nfroyd)
Assignee: nobody → agaynor
Comment on attachment 8863458 [details]
Bug 1360299 - When --enable-hardening is used, --enable-pie will be automatically enabled

https://reviewboard.mozilla.org/r/135246/#review138156

Since this is imply_option'ing a thing from the old-configure.in world, would you confirm that either:

1. config.status contains the appropriate PIE flags after compiling with `--enable-hardening`; or
2. (paranoia) firefox and related executables are PIE executables after building with `--enable-hardening`.

The above should Just Work, but you never know...  Thanks!
Attachment #8863458 - Flags: review?(nfroyd) → review+
Comment on attachment 8863458 [details]
Bug 1360299 - When --enable-hardening is used, --enable-pie will be automatically enabled

https://reviewboard.mozilla.org/r/135246/#review138156

Confirmed.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f9e0e0d49ced
When --enable-hardening is used, --enable-pie will be automatically enabled r=froydnj
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f9e0e0d49ced
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Whiteboard: [sg:want] → [sg:want][adv-main55-]
You need to log in before you can comment on or make changes to this bug.