Add performance settings section into the old organization

VERIFIED FIXED in Firefox 55

Status

()

enhancement
P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: evanxd, Assigned: evanxd)

Tracking

unspecified
Firefox 55
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox55 verified)

Details

(Whiteboard: [photon-preference])

Attachments

(1 attachment)

Assignee

Description

2 years ago
Add performance settings section into the old organization.
Flags: qe-verify+
Status: NEW → ASSIGNED
Assignee

Updated

2 years ago
Attachment #8866797 - Flags: review?(jaws)
Assignee

Comment 2

2 years ago
Hi Jared,

Could you help review the patch? Basicly, this is just copied from the patch[1] we've alreay reviewed before at Bug 1357348.

Thanks.

[1]: https://reviewboard.mozilla.org/r/133386/
Assignee

Updated

2 years ago
Blocks: 1364094
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Comment 5

2 years ago
mozreview-review
Comment on attachment 8866797 [details]
Bug 1364070 - Add performance settings section into the old organization

https://reviewboard.mozilla.org/r/138406/#review143358

::: browser/locales/en-US/chrome/browser/preferences-old/advanced.dtd:131
(Diff revision 3)
> +
> +<!ENTITY performance.label               "Performance">
> +<!ENTITY useRecommendedPerformanceSettings.label
> +                                         "Use recommended performance settings">
> +<!ENTITY useRecommendedPerformanceSettings.description
> +                                         "These settings are tailored to your computer's hardware and operating system.">

Updated the strings to align the new spec [1].

[1]: https://mozilla.invisionapp.com/share/WGBJOAB76#/screens/230367023

Comment 6

2 years ago
mozreview-review
Comment on attachment 8866797 [details]
Bug 1364070 - Add performance settings section into the old organization

https://reviewboard.mozilla.org/r/138406/#review144720

::: browser/locales/en-US/chrome/browser/preferences-old/advanced.dtd:131
(Diff revision 3)
> +
> +<!ENTITY performance.label               "Performance">
> +<!ENTITY useRecommendedPerformanceSettings.label
> +                                         "Use recommended performance settings">
> +<!ENTITY useRecommendedPerformanceSettings.description
> +                                         "These settings are tailored to your computer's hardware and operating system.">

This string will fail the browser_misused_characters_in_strings.js test. You will need to change this single-quote to a unicode curly-quote.
Attachment #8866797 - Flags: review?(jaws) → review+
Comment hidden (mozreview-request)
Assignee

Comment 8

2 years ago
mozreview-review-reply
Comment on attachment 8866797 [details]
Bug 1364070 - Add performance settings section into the old organization

https://reviewboard.mozilla.org/r/138406/#review144720

> This string will fail the browser_misused_characters_in_strings.js test. You will need to change this single-quote to a unicode curly-quote.

Updated the patch for it. Thanks.
Assignee

Comment 9

2 years ago
Updated the patch for review comments. Let's land the patch after the try[1] is good.

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b6f9c39a315
Assignee

Comment 10

2 years ago
Try is good. Let's land the patch.
Keywords: checkin-needed

Comment 11

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/925f632c4c99
Add performance settings section into the old organization r=jaws
Keywords: checkin-needed

Comment 12

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/925f632c4c99
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Any reason performanceSettingsLearnMore.label from bug 1360140 hasn't been copied?
Flags: needinfo?(evan)

Comment 14

2 years ago
"… can improve &brandShortName; performance"

Shouldn’t this be "can improve &brandShortName;’s performance"?
Assignee

Updated

2 years ago
See Also: → 1367350
Assignee

Comment 15

2 years ago
(In reply to Francesco Lodolo [:flod] from comment #13)
> Any reason performanceSettingsLearnMore.label from bug 1360140 hasn't been
> copied?

Hi Francesco,

Soryy, it is a mistake. I filed and took a bug (Bug 1367350) to fix it.
Flags: needinfo?(evan)
Assignee

Comment 16

2 years ago
(In reply to Ton from comment #14)
> "… can improve &brandShortName; performance"
> 
> Shouldn’t this be "can improve &brandShortName;’s performance"?

Hi Ton,

I would say both is OK. But the string is from the spec[1]. I think Michelle has a better answer for this.

Hi Michelle, what do you think of Comment 14.

[1]: https://mozilla.invisionapp.com/share/WGBJOAB76#/screens/230367023
Flags: needinfo?(mheubusch)

Comment 17

2 years ago
Hi - yes, Evan, both are correct, but so would removing Firefox or Firefox's, so let's do that.  Please edit this string to read " . . . can improve performance"  because the name of the browser will be understood in the context.
Flags: needinfo?(mheubusch)
Assignee

Comment 19

2 years ago
(In reply to mheubusch from comment #17)
> Hi - yes, Evan, both are correct, but so would removing Firefox or
> Firefox's, so let's do that.  Please edit this string to read " . . . can
> improve performance"  because the name of the browser will be understood in
> the context.

Hi Michelle,

Sure, let's update it at Bug 1367959.
My mistake, the relnote flag set in bug 1367350 comment 8 should belong here.
Depends on: 1382649
Depends on: 1385250

Comment 21

2 years ago
This bug was verified on Firefox Nightly 55.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.