1364070 - Add performance settings section into the old organization

Status: VERIFIED FIXED

(Firefox :: Settings UI, enhancement, P1)

Description

[Evan Tseng [:evanxd]]

Add performance settings section into the old organization.

Comment 1

[Evan Tseng [:evanxd]]

Attachment: Bug 1364070 - Add performance settings section into the old organization

Review commit: https://reviewboard.mozilla.org/r/138406/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138406/

Comment 2

[Evan Tseng [:evanxd]]

Hi Jared,

Could you help review the patch? Basicly, this is just copied from the patch[1] we've alreay reviewed before at Bug 1357348.

Thanks.

[1]: https://reviewboard.mozilla.org/r/133386/

Comment 3

[Evan Tseng [:evanxd]]

Comment on attachment 8866797 [details]
Bug 1364070 - Add performance settings section into the old organization

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/138406/diff/1-2/

Comment 4

[Evan Tseng [:evanxd]]

Comment on attachment 8866797 [details]
Bug 1364070 - Add performance settings section into the old organization

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/138406/diff/2-3/

Comment 5

[Evan Tseng [:evanxd]]

Comment on attachment 8866797 [details]
Bug 1364070 - Add performance settings section into the old organization

https://reviewboard.mozilla.org/r/138406/#review143358

::: browser/locales/en-US/chrome/browser/preferences-old/advanced.dtd:131
(Diff revision 3)
> +
> +<!ENTITY performance.label               "Performance">
> +<!ENTITY useRecommendedPerformanceSettings.label
> +                                         "Use recommended performance settings">
> +<!ENTITY useRecommendedPerformanceSettings.description
> +                                         "These settings are tailored to your computer's hardware and operating system.">

Updated the strings to align the new spec [1].

[1]: https://mozilla.invisionapp.com/share/WGBJOAB76#/screens/230367023

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8866797 [details]
Bug 1364070 - Add performance settings section into the old organization

https://reviewboard.mozilla.org/r/138406/#review144720

::: browser/locales/en-US/chrome/browser/preferences-old/advanced.dtd:131
(Diff revision 3)
> +
> +<!ENTITY performance.label               "Performance">
> +<!ENTITY useRecommendedPerformanceSettings.label
> +                                         "Use recommended performance settings">
> +<!ENTITY useRecommendedPerformanceSettings.description
> +                                         "These settings are tailored to your computer's hardware and operating system.">

This string will fail the browser_misused_characters_in_strings.js test. You will need to change this single-quote to a unicode curly-quote.

Comment 7

[Evan Tseng [:evanxd]]

Comment on attachment 8866797 [details]
Bug 1364070 - Add performance settings section into the old organization

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/138406/diff/3-4/

Comment 8

[Evan Tseng [:evanxd]]

Comment on attachment 8866797 [details]
Bug 1364070 - Add performance settings section into the old organization

https://reviewboard.mozilla.org/r/138406/#review144720

> This string will fail the browser_misused_characters_in_strings.js test. You will need to change this single-quote to a unicode curly-quote.

Updated the patch for it. Thanks.

Comment 9

[Evan Tseng [:evanxd]]

Updated the patch for review comments. Let's land the patch after the try[1] is good.

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b6f9c39a315

Comment 10

[Evan Tseng [:evanxd]]

Try is good. Let's land the patch.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/925f632c4c99
Add performance settings section into the old organization r=jaws

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/925f632c4c99

Comment 13

[Francesco Lodolo [:flod]]

Any reason performanceSettingsLearnMore.label from bug 1360140 hasn't been copied?

Comment 14

[Ton [:Tonnes]]

"… can improve &brandShortName; performance"

Shouldn’t this be "can improve &brandShortName;’s performance"?

Comment 15

[Evan Tseng [:evanxd]]

(In reply to Francesco Lodolo [:flod] from comment #13)
> Any reason performanceSettingsLearnMore.label from bug 1360140 hasn't been
> copied?

Hi Francesco,

Soryy, it is a mistake. I filed and took a bug (Bug 1367350) to fix it.

Comment 16

[Evan Tseng [:evanxd]]

(In reply to Ton from comment #14)
> "… can improve &brandShortName; performance"
> 
> Shouldn’t this be "can improve &brandShortName;’s performance"?

Hi Ton,

I would say both is OK. But the string is from the spec[1]. I think Michelle has a better answer for this.

Hi Michelle, what do you think of Comment 14.

[1]: https://mozilla.invisionapp.com/share/WGBJOAB76#/screens/230367023

Comment 17

[mheubusch]

Hi - yes, Evan, both are correct, but so would removing Firefox or Firefox's, so let's do that.  Please edit this string to read " . . . can improve performance"  because the name of the browser will be understood in the context.

Comment 18

[Mike Conley (:mconley) (:⚙️) (PTO Dec 22 - Jan 2)]

https://hg.mozilla.org/projects/cedar/rev/925f632c4c9986a0ac941513d88923abcf2bf9a0
Bug 1364070 - Add performance settings section into the old organization r=jaws

Comment 19

[Evan Tseng [:evanxd]]

(In reply to mheubusch from comment #17)
> Hi - yes, Evan, both are correct, but so would removing Firefox or
> Firefox's, so let's do that.  Please edit this string to read " . . . can
> improve performance"  because the name of the browser will be understood in
> the context.

Hi Michelle,

Sure, let's update it at Bug 1367959.

Comment 20

[Tim Guan-tin Chien [:timdream] (please needinfo)]

My mistake, the relnote flag set in bug 1367350 comment 8 should belong here.

Comment 21

[Hani Yacoub, Desktop QA]

This bug was verified on Firefox Nightly 55.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64