Closed
Bug 1364070
Opened 7 years ago
Closed 7 years ago
Add performance settings section into the old organization
Categories
(Firefox :: Settings UI, enhancement, P1)
Firefox
Settings UI
Tracking
()
VERIFIED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | verified |
People
(Reporter: evanxd, Assigned: evanxd)
References
Details
(Whiteboard: [photon-preference])
Attachments
(1 file)
Add performance settings section into the old organization.
Flags: qe-verify+
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•7 years ago
|
Attachment #8866797 -
Flags: review?(jaws)
Assignee | ||
Comment 2•7 years ago
|
||
Hi Jared, Could you help review the patch? Basicly, this is just copied from the patch[1] we've alreay reviewed before at Bug 1357348. Thanks. [1]: https://reviewboard.mozilla.org/r/133386/
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8866797 [details] Bug 1364070 - Add performance settings section into the old organization https://reviewboard.mozilla.org/r/138406/#review143358 ::: browser/locales/en-US/chrome/browser/preferences-old/advanced.dtd:131 (Diff revision 3) > + > +<!ENTITY performance.label "Performance"> > +<!ENTITY useRecommendedPerformanceSettings.label > + "Use recommended performance settings"> > +<!ENTITY useRecommendedPerformanceSettings.description > + "These settings are tailored to your computer's hardware and operating system."> Updated the strings to align the new spec [1]. [1]: https://mozilla.invisionapp.com/share/WGBJOAB76#/screens/230367023
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8866797 [details] Bug 1364070 - Add performance settings section into the old organization https://reviewboard.mozilla.org/r/138406/#review144720 ::: browser/locales/en-US/chrome/browser/preferences-old/advanced.dtd:131 (Diff revision 3) > + > +<!ENTITY performance.label "Performance"> > +<!ENTITY useRecommendedPerformanceSettings.label > + "Use recommended performance settings"> > +<!ENTITY useRecommendedPerformanceSettings.description > + "These settings are tailored to your computer's hardware and operating system."> This string will fail the browser_misused_characters_in_strings.js test. You will need to change this single-quote to a unicode curly-quote.
Attachment #8866797 -
Flags: review?(jaws) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8866797 [details] Bug 1364070 - Add performance settings section into the old organization https://reviewboard.mozilla.org/r/138406/#review144720 > This string will fail the browser_misused_characters_in_strings.js test. You will need to change this single-quote to a unicode curly-quote. Updated the patch for it. Thanks.
Assignee | ||
Comment 9•7 years ago
|
||
Updated the patch for review comments. Let's land the patch after the try[1] is good. [1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b6f9c39a315
Comment 11•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/925f632c4c99 Add performance settings section into the old organization r=jaws
Keywords: checkin-needed
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/925f632c4c99
Comment 13•7 years ago
|
||
Any reason performanceSettingsLearnMore.label from bug 1360140 hasn't been copied?
Flags: needinfo?(evan)
Comment 14•7 years ago
|
||
"… can improve &brandShortName; performance" Shouldn’t this be "can improve &brandShortName;’s performance"?
Assignee | ||
Comment 15•7 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #13) > Any reason performanceSettingsLearnMore.label from bug 1360140 hasn't been > copied? Hi Francesco, Soryy, it is a mistake. I filed and took a bug (Bug 1367350) to fix it.
Flags: needinfo?(evan)
Assignee | ||
Comment 16•7 years ago
|
||
(In reply to Ton from comment #14) > "… can improve &brandShortName; performance" > > Shouldn’t this be "can improve &brandShortName;’s performance"? Hi Ton, I would say both is OK. But the string is from the spec[1]. I think Michelle has a better answer for this. Hi Michelle, what do you think of Comment 14. [1]: https://mozilla.invisionapp.com/share/WGBJOAB76#/screens/230367023
Flags: needinfo?(mheubusch)
Comment 17•7 years ago
|
||
Hi - yes, Evan, both are correct, but so would removing Firefox or Firefox's, so let's do that. Please edit this string to read " . . . can improve performance" because the name of the browser will be understood in the context.
Flags: needinfo?(mheubusch)
Comment 18•7 years ago
|
||
https://hg.mozilla.org/projects/cedar/rev/925f632c4c9986a0ac941513d88923abcf2bf9a0 Bug 1364070 - Add performance settings section into the old organization r=jaws
Assignee | ||
Comment 19•7 years ago
|
||
(In reply to mheubusch from comment #17) > Hi - yes, Evan, both are correct, but so would removing Firefox or > Firefox's, so let's do that. Please edit this string to read " . . . can > improve performance" because the name of the browser will be understood in > the context. Hi Michelle, Sure, let's update it at Bug 1367959.
Comment 20•7 years ago
|
||
My mistake, the relnote flag set in bug 1367350 comment 8 should belong here.
Comment 21•7 years ago
|
||
This bug was verified on Firefox Nightly 55.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•