Closed
Bug 1366369
Opened 7 years ago
Closed 7 years ago
Update Default/Dark/Light theme icons
Categories
(Firefox :: Toolbars and Customization, enhancement, P1)
Firefox
Toolbars and Customization
Tracking
()
Tracking | Status | |
---|---|---|
firefox57 | --- | verified |
People
(Reporter: dao, Assigned: anting004)
References
Details
(Keywords: good-first-bug, Whiteboard: [reserve-photon-visual][p3])
Attachments
(4 files)
+++ This bug was initially created as a clone of Bug #1366363 +++ Firefox 57 will have compact and touch modes independently from current compact themes, but we want to keep these themes as dark/light alternatives to the default. We need to update these icons accordingly: browser/base/content/default-theme-icon.svg browser/base/content/defaultthemes/compactlight.icon.svg browser/base/content/defaultthemes/compactdark.icon.svg
Reporter | ||
Updated•7 years ago
|
Priority: -- → P2
Reporter | ||
Updated•7 years ago
|
Flags: qe-verify+
Updated•7 years ago
|
QA Contact: brindusa.tot
Reporter | ||
Comment 2•7 years ago
|
||
Stephen, can you please provide icons for this?
Flags: needinfo?(shorlander)
Reporter | ||
Updated•7 years ago
|
Whiteboard: [photon-visual][p1][57] → [reserve-photon-visual][p3]
Reporter | ||
Updated•7 years ago
|
Priority: P2 → P3
Comment 4•7 years ago
|
||
Comment 5•7 years ago
|
||
Updated•7 years ago
|
Keywords: good-first-bug
If it is not too much trouble I would really like to do this, seeing as it is now a good-first-bug. Is it as simple as replacing browser/base/content/default-theme-icon.svg browser/base/content/defaultthemes/compactlight.icon.svg browser/base/content/defaultthemes/compactdark.icon.svg with Stephens updated versions?
Comment 7•7 years ago
|
||
(In reply to anting004 from comment #6) > If it is not too much trouble I would really like to do this, seeing as it > is now a good-first-bug. > Is it as simple as replacing > > browser/base/content/default-theme-icon.svg > browser/base/content/defaultthemes/compactlight.icon.svg > browser/base/content/defaultthemes/compactdark.icon.svg > > with Stephens updated versions? Yep, exactly. You might want to rename compactlight to light and compactdark to dark too (and change the references).
(In reply to Tim Nguyen :ntim from comment #7) > (In reply to anting004 from comment #6) > > If it is not too much trouble I would really like to do this, seeing as it > > is now a good-first-bug. > > Is it as simple as replacing > > > > browser/base/content/default-theme-icon.svg > > browser/base/content/defaultthemes/compactlight.icon.svg > > browser/base/content/defaultthemes/compactdark.icon.svg > > > > with Stephens updated versions? > > Yep, exactly. You might want to rename compactlight to light and compactdark > to dark too (and change the references). Good, thanks. I have fixed the images and renamed them (and any reference I could find with grep). However I found the documentation on making the patch a bit difficult to understand. https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch Mentions both using hg export (or rather hg bzexport) but also reviewboard. Should I use reviewboard, mercurial or both in some way to submit a patch?
Comment hidden (mozreview-request) |
Reporter | ||
Comment 10•7 years ago
|
||
(In reply to anting004 from comment #8) > However I found the documentation on making the patch > a bit difficult to understand. > https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/ > How_to_Submit_a_Patch Mentions both using hg export (or rather hg bzexport) > but also reviewboard. Sorry about that. I unsuccessfully lobbied for not telling new contributors to use reviewboard, since we're getting rid of reviewboard later this year. > Should I use reviewboard, mercurial or both in some > way to submit a patch? It's up to you...
Reporter | ||
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8910165 [details] Bug 1366369 - Change default theme icons. https://reviewboard.mozilla.org/r/181662/#review187028 This looks good. Thanks!
Attachment #8910165 -
Flags: review+
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → anting004
Comment 12•7 years ago
|
||
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/46ce0f1dcd55 Change default theme icons. r=dao
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: P3 → P1
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/46ce0f1dcd55
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Updated•7 years ago
|
Iteration: --- → 57.3 - Sep 19
Comment 14•7 years ago
|
||
Build ID: 20170920220431 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•