Closed Bug 1367118 Opened 6 years ago Closed 6 years ago

stylo: investigate the disabled SVG related tests

Categories

(Core :: CSS Parsing and Computation, enhancement, P5)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: chenpighead, Assigned: chenpighead)

References

Details

In Bug 1359343, we disabled a bunch of tests (by annotating them with skip-if or fails-if) to enable stylo for SVG documents. This bug is filed for the further investigation about the disabled tests. We should categorize all of them, and file bugs for each of the test. So we could narrow down the scope and measure how far we are from fully support SVG for stylo.

The first step would be moving the current investigation progress (mostly made by Brian and Cameron) to here. Then I'll keep updating them in this bug, until we ensure that each of the tests is tracked by a bug (or bugs).

========

dom/smil/crashtests/690994-1.svg
layout/reftests/svg/smil/** (150 tests)
layout/reftests/svg/text/textLength-6.svg
layout/reftests/svg/mask-type-04.svg
  lack of SMIL support (bug 1302948)

Brian can take care of these.

layout/reftests/bugs/220165-1.svg
layout/reftests/bugs/490177-1.svg
layout/reftests/svg/foreignObject-form-theme.svg
  button not using native theming (bug 1349651)

layout/reftests/scoped-style/scoped-style-019.svg
layout/reftests/scoped-style/scoped-style-dynamic-012.svg
layout/reftests/scoped-style/scoped-style-dynamic-013.svg
layout/reftests/scoped-style/scoped-style-dynamic-014.svg
layout/reftests/scoped-style/scoped-style-dynamic-015.svg
layout/reftests/scoped-style/scoped-style-dynamic-015.svg
  lack of <style scoped> support (bug 1345702)

layout/reftests/svg/sizing/scrollbars-01.svg
layout/reftests/svg/sizing/scrollbars-02.svg
layout/reftests/svg/outer-svg-border-and-padding-01.svg
  scroll bars not working (bug 1321769)

layout/reftests/svg/text/pseudo-first-line.svg
layout/reftests/svg/text/pseudo-first-line-2.svg
  lack of ::first-line support (bug 1324619)

layout/reftests/svg/moz-only/xbl-grad-ref--grad-in-resources-01.svg
layout/reftests/svg/moz-only/xbl-grad-ref--grad-in-resources-02.svg
  something to do with XBL and resolving local url() references (no bug)

layout/reftests/svg/conditions-07.svg
layout/reftests/svg/dynamic-conditions-01.svg
layout/reftests/svg/dynamic-conditions-02.svg
layout/reftests/svg/dynamic-conditions-03.svg
layout/reftests/svg/dynamic-conditions-04.svg
layout/reftests/svg/dynamic-conditions-06.svg
layout/reftests/svg/dynamic-conditions-09.svg
layout/reftests/svg/dynamic-conditions-10.svg
layout/reftests/svg/dynamic-conditions-13.svg
  dynamic changes to conditional processing attributes aren't handled --
  maybe we're not correctly generating/processing the ReconstructFrame
  hint in nsSVGElement::GetAttributeChangeHint?  (no bug)

layout/reftests/svg/currentColor-01.svg
layout/reftests/svg/currentColor-02.svg
layout/reftests/svg/currentColor-03.svg
layout/reftests/svg/use-02-extref.svg
  fill="currentColor" isn't working?

These might overlap with bug 1345709 somewhat (although that is more about interpolation)
We should re-check these once bug 1345709 is resolved.

layout/reftests/svg/dynamic-mask-01.svg
  timed out waiting for MozReftestInvalidate, not sure what the
  issues is (no bug)

layout/reftests/svg/dynamic-text-01.svg
layout/reftests/svg/dynamic-text-02.svg
layout/reftests/svg/dynamic-text-03.svg
layout/reftests/svg/dynamic-text-04.svg
layout/reftests/svg/dynamic-text-07.svg
layout/reftests/svg/dynamic-text-08.svg
layout/reftests/svg/dynamic-textPath-01.svg
layout/reftests/svg/gradient-live-01a.svg
layout/reftests/svg/gradient-live-01b.svg
layout/reftests/svg/gradient-live-01c.svg
layout/reftests/svg/paint-order-02.svg
layout/reftests/svg/stroke-dasharray-and-text-01.svg
layout/reftests/svg/text-gradient-02.svg
layout/reftests/svg/text-in-link-03.svg
layout/reftests/svg/text-layout-01.svg
layout/reftests/svg/text-layout-02.svg
layout/reftests/svg/text-layout-03.svg
layout/reftests/svg/text-layout-04.svg
layout/reftests/svg/text-layout-06.svg
layout/reftests/svg/text-layout-07.svg
layout/reftests/svg/text-scale-01.svg
layout/reftests/svg/textPath-01.svg
  text size wrong, might be related to mFontSizeScaleFactor?

Bug 1357296 is probably related (i.e. we need to factor out text-zoom for animation values, but I guess in general too).

layout/reftests/svg/fallback-color-02a.svg
layout/reftests/svg/fallback-color-02b.svg
layout/reftests/svg/fallback-color-04.svg
  something with a failing paint server reference and fallback color
  (no bug)

layout/reftests/svg/foreignObject-change-transform-01.svg
layout/reftests/svg/g-transform-01.svg
  maybe an issue with transform="" attribute updating not causing
  a restyle?  (no bug)

layout/reftests/svg/stroke-dasharray-02.svg
  maybe an issue with stroke-width glue, or accuracy?  (no bug)
(In reply to Jeremy Chen [:jeremychen] UTC+8 from comment #0)

I am commenting for 'no bug' tests.

> layout/reftests/svg/moz-only/xbl-grad-ref--grad-in-resources-01.svg
> layout/reftests/svg/moz-only/xbl-grad-ref--grad-in-resources-02.svg
>   something to do with XBL and resolving local url() references (no bug)

Already passed.

> layout/reftests/svg/conditions-07.svg
> layout/reftests/svg/dynamic-conditions-01.svg
> layout/reftests/svg/dynamic-conditions-02.svg
> layout/reftests/svg/dynamic-conditions-03.svg
> layout/reftests/svg/dynamic-conditions-04.svg
> layout/reftests/svg/dynamic-conditions-06.svg
> layout/reftests/svg/dynamic-conditions-09.svg
> layout/reftests/svg/dynamic-conditions-10.svg
> layout/reftests/svg/dynamic-conditions-13.svg
>   dynamic changes to conditional processing attributes aren't handled --
>   maybe we're not correctly generating/processing the ReconstructFrame
>   hint in nsSVGElement::GetAttributeChangeHint?  (no bug)

Already passed.

> layout/reftests/svg/dynamic-mask-01.svg
>   timed out waiting for MozReftestInvalidate, not sure what the
>   issues is (no bug)

Already passed.

> layout/reftests/svg/fallback-color-02a.svg
> layout/reftests/svg/fallback-color-02b.svg
> layout/reftests/svg/fallback-color-04.svg
>   something with a failing paint server reference and fallback color
>   (no bug)

Already passed.

> layout/reftests/svg/foreignObject-change-transform-01.svg
> layout/reftests/svg/g-transform-01.svg
>   maybe an issue with transform="" attribute updating not causing
>   a restyle?  (no bug)

Already passed.

> layout/reftests/svg/stroke-dasharray-02.svg
>   maybe an issue with stroke-width glue, or accuracy?  (no bug)

As far as I can tell this is the only one unknown failure now, needs to be investigated.
(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)
> 
> > layout/reftests/svg/stroke-dasharray-02.svg
> >   maybe an issue with stroke-width glue, or accuracy?  (no bug)
> 
> As far as I can tell this is the only one unknown failure now, needs to be
> investigated.

Nice!!! \o/
Thank you for the update. I'll take look at this.
(In reply to Jeremy Chen [:jeremychen] UTC+8 from comment #2)
> (In reply to Hiroyuki Ikezoe (:hiro) from comment #1)
> > 
> > > layout/reftests/svg/stroke-dasharray-02.svg
> > >   maybe an issue with stroke-width glue, or accuracy?  (no bug)
> > 
> > As far as I can tell this is the only one unknown failure now, needs to be
> > investigated.
> 
> Nice!!! \o/
> Thank you for the update. I'll take look at this.

Looks like this has nothing to do with stroke-dasharray nor stroke-width...
Filed Bug 1367327
(In reply to Jeremy Chen [:jeremychen] UTC+8 from comment #0)
> 
> layout/reftests/svg/currentColor-01.svg
> layout/reftests/svg/currentColor-02.svg
> layout/reftests/svg/currentColor-03.svg
> layout/reftests/svg/use-02-extref.svg
>   fill="currentColor" isn't working?

Filed bug 1368376.
Update the remaining unresolved tests

> ========
> 
> dom/smil/crashtests/690994-1.svg
> layout/reftests/svg/smil/** (150 tests)
> layout/reftests/svg/text/textLength-6.svg
> layout/reftests/svg/mask-type-04.svg
>   lack of SMIL support (bug 1302948)

Brian can take care of these.

> 
> layout/reftests/scoped-style/scoped-style-019.svg
> layout/reftests/scoped-style/scoped-style-dynamic-012.svg
> layout/reftests/scoped-style/scoped-style-dynamic-013.svg
> layout/reftests/scoped-style/scoped-style-dynamic-014.svg
> layout/reftests/scoped-style/scoped-style-dynamic-015.svg
> layout/reftests/scoped-style/scoped-style-dynamic-015.svg
>   lack of <style scoped> support (bug 1345702)

> layout/reftests/svg/sizing/scrollbars-01.svg
> layout/reftests/svg/sizing/scrollbars-02.svg
> layout/reftests/svg/outer-svg-border-and-padding-01.svg
>   scroll bars not working (bug 1321769)

Ting-Yu has been assigned to these two bugs.
 
> layout/reftests/svg/text/pseudo-first-line.svg
> layout/reftests/svg/text/pseudo-first-line-2.svg
>   lack of ::first-line support (bug 1324619)

bz has been assigned.

> 
> layout/reftests/svg/currentColor-01.svg
> layout/reftests/svg/currentColor-02.svg
> layout/reftests/svg/currentColor-03.svg
> layout/reftests/svg/use-02-extref.svg
>   fill="currentColor" isn't working?
> 
> These might overlap with bug 1345709 somewhat (although that is more about
> interpolation)
> We should re-check these once bug 1345709 is resolved.

Hiroyuki somehow links this to bug 1368376.
Both these two bugs have no assignees.

> layout/reftests/svg/dynamic-text-01.svg
> layout/reftests/svg/dynamic-text-02.svg
> layout/reftests/svg/dynamic-text-03.svg
> layout/reftests/svg/dynamic-text-04.svg
> layout/reftests/svg/dynamic-text-07.svg
> layout/reftests/svg/dynamic-text-08.svg
> layout/reftests/svg/dynamic-textPath-01.svg
> layout/reftests/svg/gradient-live-01a.svg
> layout/reftests/svg/gradient-live-01b.svg
> layout/reftests/svg/gradient-live-01c.svg
> layout/reftests/svg/paint-order-02.svg
> layout/reftests/svg/stroke-dasharray-and-text-01.svg
> layout/reftests/svg/text-gradient-02.svg
> layout/reftests/svg/text-in-link-03.svg
> layout/reftests/svg/text-layout-01.svg
> layout/reftests/svg/text-layout-02.svg
> layout/reftests/svg/text-layout-03.svg
> layout/reftests/svg/text-layout-04.svg
> layout/reftests/svg/text-layout-06.svg
> layout/reftests/svg/text-layout-07.svg
> layout/reftests/svg/text-scale-01.svg
> layout/reftests/svg/textPath-01.svg
>   text size wrong, might be related to mFontSizeScaleFactor?
> 
> Bug 1357296 is probably related (i.e. we need to factor out text-zoom for
> animation values, but I guess in general too).

Stylo does not support text-zoom yet (Bug 1357296), which seems blocked by bug 1290228.
Both bugs have no assignees.
(In reply to Jeremy Chen [:jeremychen] UTC+8 from comment #5)

> > layout/reftests/svg/dynamic-text-01.svg
> > layout/reftests/svg/dynamic-text-02.svg
> > layout/reftests/svg/dynamic-text-03.svg
> > layout/reftests/svg/dynamic-text-04.svg
> > layout/reftests/svg/dynamic-text-07.svg
> > layout/reftests/svg/dynamic-text-08.svg
> > layout/reftests/svg/dynamic-textPath-01.svg
> > layout/reftests/svg/gradient-live-01a.svg
> > layout/reftests/svg/gradient-live-01b.svg
> > layout/reftests/svg/gradient-live-01c.svg
> > layout/reftests/svg/paint-order-02.svg
> > layout/reftests/svg/stroke-dasharray-and-text-01.svg
> > layout/reftests/svg/text-gradient-02.svg
> > layout/reftests/svg/text-in-link-03.svg
> > layout/reftests/svg/text-layout-01.svg
> > layout/reftests/svg/text-layout-02.svg
> > layout/reftests/svg/text-layout-03.svg
> > layout/reftests/svg/text-layout-04.svg
> > layout/reftests/svg/text-layout-06.svg
> > layout/reftests/svg/text-layout-07.svg
> > layout/reftests/svg/text-scale-01.svg
> > layout/reftests/svg/textPath-01.svg
> >   text size wrong, might be related to mFontSizeScaleFactor?
> > 
> > Bug 1357296 is probably related (i.e. we need to factor out text-zoom for
> > animation values, but I guess in general too).
> 
> Stylo does not support text-zoom yet (Bug 1357296), which seems blocked by
> bug 1290228.
> Both bugs have no assignees.

Those tests have been already enabled. bug 1357296 affects only SMIL.
(In reply to Hiroyuki Ikezoe (:hiro) from comment #6)
> 
> Those tests have been already enabled. bug 1357296 affects only SMIL.

Nice!! Thank you for the info.
So, I guess the currentColor support is the only remaining un-assigned task.
Update the remaining unresolved tests

> ========
> 
> layout/reftests/svg/smil/** (150 tests)
> layout/reftests/svg/mask-type-04.svg
>   lack of SMIL support (bug 1302948)

Brian can take care of these.

> 
> layout/reftests/scoped-style/scoped-style-019.svg
> layout/reftests/scoped-style/scoped-style-dynamic-012.svg
> layout/reftests/scoped-style/scoped-style-dynamic-013.svg
> layout/reftests/scoped-style/scoped-style-dynamic-014.svg
> layout/reftests/scoped-style/scoped-style-dynamic-015.svg
> layout/reftests/scoped-style/scoped-style-dynamic-015.svg
>   lack of <style scoped> support (bug 1345702)

Ting-Yu has been assigned to this.
 
> layout/reftests/svg/text/pseudo-first-line.svg
> layout/reftests/svg/text/pseudo-first-line-2.svg
>   lack of ::first-line support (bug 1324619)

bz has been assigned.

> 
> layout/reftests/svg/currentColor-01.svg
> layout/reftests/svg/currentColor-02.svg
> layout/reftests/svg/currentColor-03.svg
> layout/reftests/svg/use-02-extref.svg
>   fill="currentColor" isn't working?
> 
> These might overlap with bug 1345709 somewhat (although that is more about
> interpolation)
> We should re-check these once bug 1345709 is resolved.

Hiroyuki somehow links this to bug 1368376.
Both these two bugs have no assignees.
(In reply to Jeremy Chen [:jeremychen] UTC+8 from comment #8)
> Update the remaining unresolved tests
> 
> > ========
> > 
> > layout/reftests/svg/smil/** (150 tests)
> > layout/reftests/svg/mask-type-04.svg
> >   lack of SMIL support (bug 1302948)
> 
> Brian can take care of these.

mask-type-04.svg has been fixed by bug 1367283.
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b76a023ad0c12b4e7f4992d0e915b4de354c1f3a
There was a discrete type property (mask-type).
Jeremy we have other failure tests that we haven't tracked in this bug.

https://hg.mozilla.org/mozilla-central/file/9a5c710587f9/layout/reftests/svg/as-image/reftest.list#l60

They are tracked in bug 1338764, I guess.
(In reply to Hiroyuki Ikezoe (:hiro) from comment #10)
> Jeremy we have other failure tests that we haven't tracked in this bug.
> 
> https://hg.mozilla.org/mozilla-central/file/9a5c710587f9/layout/reftests/svg/
> as-image/reftest.list#l60
> 
> They are tracked in bug 1338764, I guess.

Good catch!!

I'll re-check all the disabled tests (not just the ones that I disabled in bug 1359343) and give a update here.
Hmm... just figure that I should not care about the tests that have been annotated with fails-if(!styloVsGecko). These kind of tests were annotated with fails before stylo, and we might need the fails-if(!styloVsGecko) for a while, to ensure that in these kind of known failures, stylo result is still identical with gecko result. Lesson learned!!
Update the remaining unresolved tests

> ========
> 
> layout/reftests/svg/smil/** (150 tests)
>   lack of SMIL support (bug 1302948)

Brian can take care of these.

> 
> layout/reftests/scoped-style/scoped-style-019.svg
> layout/reftests/scoped-style/scoped-style-dynamic-012.svg
> layout/reftests/scoped-style/scoped-style-dynamic-013.svg
> layout/reftests/scoped-style/scoped-style-dynamic-014.svg
> layout/reftests/scoped-style/scoped-style-dynamic-015.svg
> layout/reftests/scoped-style/scoped-style-dynamic-015.svg
>   lack of <style scoped> support (bug 1345702)

Ting-Yu has been assigned to this.
 
> layout/reftests/svg/text/pseudo-first-line.svg
> layout/reftests/svg/text/pseudo-first-line-2.svg
>   lack of ::first-line support (bug 1324619)

bz has been assigned.

> layout/reftests/svg/as-image/context-fill-01.html lime100x100-ref.html
> layout/reftests/svg/as-image/context-fill-02.html lime100x100-w-border-ref.html
> layout/reftests/svg/as-image/context-fill-03.html lime100x100-50pct-ref.html
> layout/reftests/svg/as-image/context-fill-04.html lime100x100-50pct-ref.html
> layout/reftests/svg/as-image/context-fill-05.html context-fill-or-stroke-05-ref.html
> layout/reftests/svg/as-image/context-fill-06.html lime100x100-ref.html
> layout/reftests/svg/as-image/context-fill-07.html context-fill-07-ref.html
> layout/reftests/svg/as-image/context-fill-bg-image-01.html blue100x100-ref.html
> layout/reftests/svg/as-image/context-stroke-01.html lime100x100-ref.html
> layout/reftests/svg/as-image/context-stroke-02.html lime100x100-w-border-ref.html
> layout/reftests/svg/as-image/context-stroke-03.html lime100x100-50pct-ref.html
> layout/reftests/svg/as-image/context-stroke-04.html lime100x100-50pct-ref.html
> layout/reftests/svg/as-image/context-stroke-05.html context-fill-or-stroke-05-ref.html
> layout/reftests/svg/as-image/context-stroke-06.html lime100x100-ref.html
> layout/reftests/svg/as-image/context-stroke-bg-image-01.html blue100x100-border-ref.html

These should be tracked in bug 1338764, which is taken by CJ

> layout/reftests/image/image-srcset-svg-3x.html

A strange bar appears on stylo...
https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/TV_V6NeaRqSvzBH4ypIzYg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

no bug yet!

> layout/reftests/svg/use-02-extref.svg

no bug yet!

> ========

I'll take a look at the last two tests.
(In reply to Jeremy Chen [:jeremychen] UTC+8 from comment #13)
> 
> > layout/reftests/svg/use-02-extref.svg
> 

Looks like this has been re-enabled in https://hg.mozilla.org/mozilla-central/rev/29177506860d.
Update the remaining unresolved tests

> ========
> 
> layout/reftests/svg/smil/** (150 tests)
>   lack of SMIL support (bug 1302948)

Brian can take care of these.

> 
> layout/reftests/scoped-style/scoped-style-019.svg
> layout/reftests/scoped-style/scoped-style-dynamic-012.svg
> layout/reftests/scoped-style/scoped-style-dynamic-013.svg
> layout/reftests/scoped-style/scoped-style-dynamic-014.svg
> layout/reftests/scoped-style/scoped-style-dynamic-015.svg
> layout/reftests/scoped-style/scoped-style-dynamic-015.svg
>   lack of <style scoped> support (bug 1345702)

Ting-Yu has been assigned to this.
 
> layout/reftests/svg/text/pseudo-first-line.svg
> layout/reftests/svg/text/pseudo-first-line-2.svg
>   lack of ::first-line support (bug 1324619)

bz has been assigned.

> layout/reftests/svg/as-image/context-fill-01.html lime100x100-ref.html
> layout/reftests/svg/as-image/context-fill-02.html lime100x100-w-border-ref.html
> layout/reftests/svg/as-image/context-fill-03.html lime100x100-50pct-ref.html
> layout/reftests/svg/as-image/context-fill-04.html lime100x100-50pct-ref.html
> layout/reftests/svg/as-image/context-fill-05.html context-fill-or-stroke-05-ref.html
> layout/reftests/svg/as-image/context-fill-06.html lime100x100-ref.html
> layout/reftests/svg/as-image/context-fill-07.html context-fill-07-ref.html
> layout/reftests/svg/as-image/context-fill-bg-image-01.html blue100x100-ref.html
> layout/reftests/svg/as-image/context-stroke-01.html lime100x100-ref.html
> layout/reftests/svg/as-image/context-stroke-02.html lime100x100-w-border-ref.html
> layout/reftests/svg/as-image/context-stroke-03.html lime100x100-50pct-ref.html
> layout/reftests/svg/as-image/context-stroke-04.html lime100x100-50pct-ref.html
> layout/reftests/svg/as-image/context-stroke-05.html context-fill-or-stroke-05-ref.html
> layout/reftests/svg/as-image/context-stroke-06.html lime100x100-ref.html
> layout/reftests/svg/as-image/context-stroke-bg-image-01.html blue100x100-border-ref.html

These should be tracked in bug 1338764, which is taken by Tommy now.

> layout/reftests/image/image-srcset-svg-3x.html

Filed Bug 1369321, and I'll look into it.
Update the remaining unresolved tests

> ========
> 
> layout/reftests/svg/smil/** (150 tests)

After I ran

`grep 'stylo' -r layout/reftests/svg/smil/`

,there are only a few remaining tests (22 tests):

> layout/reftests/svg/smil//reftest.list:fails-if(!styloVsGecko) == anim-fillcolor-1.svg      anim-standard-ref.svg # bug 436296
> layout/reftests/svg/smil//reftest.list:skip-if(styloVsGecko) == anim-view-01.svg#view lime.svg # bug 1354406
> layout/reftests/svg/smil//reftest.list:fails-if(styloVsGecko||stylo) == anim-class-01.svg lime.svg
> layout/reftests/svg/smil//reftest.list:fails-if(styloVsGecko||stylo) == anim-class-02.svg lime.svg
> layout/reftests/svg/smil//reftest.list:fails-if(styloVsGecko||stylo) == anim-class-03.svg lime.svg
> layout/reftests/svg/smil//reftest.list:fails-if(styloVsGecko||stylo) == anim-class-04.svg anim-class-04-ref.svg
> layout/reftests/svg/smil//reftest.list:fails-if(styloVsGecko||stylo) == anim-paintserver-1.svg anim-paintserver-1-ref.svg
> layout/reftests/svg/smil//reftest.list:fails-if(!styloVsGecko) == anim-strokecolor-1.svg anim-standard-ref.svg # bug 436296
> layout/reftests/svg/smil//reftest.list:fails-if(!styloVsGecko) == anim-pattern-attr-presence-02.svg anim-pattern-attr-presence-02-ref.svg
> layout/reftests/svg/smil//reftest.list:fails-if(styloVsGecko||stylo) == anim-change-display-block-for-dynamically-appended-elem.html anim-standard-ref.html
> layout/reftests/svg/smil//style/reftest.list:fuzzy-if(skiaContent,1,550) fails-if(styloVsGecko||stylo) == anim-css-fill-1-by-ident-hex.svg         anim-css-fill-1-ref.svg
> layout/reftests/svg/smil//style/reftest.list:fuzzy-if(skiaContent,1,550) fails-if(styloVsGecko||stylo) == anim-css-fill-1-by-ident-curcol.svg      anim-css-fill-1-ref.svg
> layout/reftests/svg/smil//style/reftest.list:fuzzy-if(skiaContent,1,580) fails-if(styloVsGecko||stylo) == anim-css-fill-3-by-ident-ident.svg       anim-css-fill-3-ref.svg
> layout/reftests/svg/smil//style/reftest.list:fails-if(styloVsGecko||stylo) == anim-css-fill-overflow-1-by.svg       anim-css-fill-overflow-1-ref.svg
> layout/reftests/svg/smil//style/reftest.list:fails-if(!stylo) == anim-css-fill-overflow-1-from-by.svg anim-css-fill-overflow-1-ref.svg # bug 515919
> layout/reftests/svg/smil//style/reftest.list:fails-if(!stylo) == anim-css-stopcolor-overflow-1-from-by.svg anim-css-stopcolor-overflow-1-ref.svg # bug 515919
> layout/reftests/svg/smil//style/reftest.list:fails-if(!stylo) == anim-css-floodcolor-overflow-1-from-by.svg anim-css-floodcolor-overflow-1-ref.svg # bug 515919
> layout/reftests/svg/smil//style/reftest.list:fuzzy-if(skiaContent,1,885) fails-if(styloVsGecko||stylo) == anim-css-fillopacity-1-by.svg            anim-css-fillopacity-1-ref.svg
> layout/reftests/svg/smil//style/reftest.list:fuzzy-if(skiaContent,1,210) fails-if(styloVsGecko||stylo) == anim-css-fillopacity-1-from-by.svg       anim-css-fillopacity-1-ref.svg
> layout/reftests/svg/smil//style/reftest.list:fuzzy-if(skiaContent,1,365) fails-if(styloVsGecko||stylo) == anim-css-fillopacity-3-clamp-small.svg   anim-css-fillopacity-3-ref.svg
> layout/reftests/svg/smil//style/reftest.list:fails-if(styloVsGecko||stylo) == anim-css-font-1.svg  anim-css-font-1-ref.svg
> layout/reftests/svg/smil//style/reftest.list:skip-if(!styloVsGecko) == anim-css-strokedasharray-1.svg anim-css-strokedasharray-1-ref.svg

For those fails-if(!styloVsGecko) tests, I believe we're fine to leave them as they are, since they should be expected. So, that makes the number even less!!!

Brian and Hiro are still working on the rest. (tracked by bug 1302948)

> 
> layout/reftests/scoped-style/scoped-style-019.svg
> layout/reftests/scoped-style/scoped-style-dynamic-012.svg
> layout/reftests/scoped-style/scoped-style-dynamic-013.svg
> layout/reftests/scoped-style/scoped-style-dynamic-014.svg
> layout/reftests/scoped-style/scoped-style-dynamic-015.svg
> layout/reftests/scoped-style/scoped-style-dynamic-015.svg
>   lack of <style scoped> support (bug 1345702)

We may consider to remove <style scoped> support in Bug 1345702.
Here's the intent to unship thread: https://groups.google.com/forum/#!topic/mozilla.dev.platform/iBoROFkR9V8

Cameron is working on disabling <style scoped> in content documents in Bug 1291515. Even though, we still can't re-enable these tests, unless we resolve Bug 1345702.

So, set Bug 1345702 as a blocker for Bug 1352284 (stylo-svg) for now.
 
> layout/reftests/svg/text/pseudo-first-line.svg
> layout/reftests/svg/text/pseudo-first-line-2.svg
>   lack of ::first-line support (bug 1324619)

bz has been assigned.

> layout/reftests/svg/as-image/context-fill-01.html lime100x100-ref.html
> layout/reftests/svg/as-image/context-fill-02.html lime100x100-w-border-ref.html
> layout/reftests/svg/as-image/context-fill-03.html lime100x100-50pct-ref.html
> layout/reftests/svg/as-image/context-fill-04.html lime100x100-50pct-ref.html
> layout/reftests/svg/as-image/context-fill-05.html context-fill-or-stroke-05-ref.html
> layout/reftests/svg/as-image/context-fill-06.html lime100x100-ref.html
> layout/reftests/svg/as-image/context-fill-07.html context-fill-07-ref.html
> layout/reftests/svg/as-image/context-fill-bg-image-01.html blue100x100-ref.html
> layout/reftests/svg/as-image/context-stroke-01.html lime100x100-ref.html
> layout/reftests/svg/as-image/context-stroke-02.html lime100x100-w-border-ref.html
> layout/reftests/svg/as-image/context-stroke-03.html lime100x100-50pct-ref.html
> layout/reftests/svg/as-image/context-stroke-04.html lime100x100-50pct-ref.html
> layout/reftests/svg/as-image/context-stroke-05.html context-fill-or-stroke-05-ref.html
> layout/reftests/svg/as-image/context-stroke-06.html lime100x100-ref.html
> layout/reftests/svg/as-image/context-stroke-bg-image-01.html blue100x100-border-ref.html

Looks like Tommy has fixed all of them in Bug 1370797. \o/

> layout/reftests/image/image-srcset-svg-3x.html

At first, bz and I thought this could be fixed in bug 1374761.
However, per bug 1369321 comment 7, looks like this needs more investigation.
Priority: P2 → --
Update the remaining unresolved tests since bz just landed bug 1324619.

> ========
> 
> layout/reftests/svg/smil/** (150 tests)

After I ran

`grep 'stylo' -r layout/reftests/svg/smil/`

,there are only 9 tests remaining:

> layout/reftests/svg/smil/reftest.list:fails-if(!styloVsGecko) == anim-fillcolor-1.svg      anim-standard-ref.svg # bug 436296
> layout/reftests/svg/smil/reftest.list:skip-if(styloVsGecko) == anim-view-01.svg#view lime.svg # bug 1354406
> layout/reftests/svg/smil/reftest.list:fails-if(!styloVsGecko) == anim-strokecolor-1.svg anim-standard-ref.svg # bug 436296
> layout/reftests/svg/smil/reftest.list:fails-if(!styloVsGecko) == anim-pattern-attr-presence-02.svg anim-pattern-attr-presence-02-ref.svg
> layout/reftests/svg/smil/reftest.list:skip-if(styloVsGecko||stylo) == anim-display-in-g-element.svg lime.svg # Bug 1385089
> layout/reftests/svg/smil/style/reftest.list:fails-if(!stylo) == anim-css-fill-overflow-1-from-by.svg anim-css-fill-overflow-1-ref.svg # bug 515919
> layout/reftests/svg/smil/style/reftest.list:fails-if(!stylo) == anim-css-stopcolor-overflow-1-from-by.svg anim-css-stopcolor-overflow-1-ref.svg # bug 515919
> layout/reftests/svg/smil/style/reftest.list:fails-if(!stylo) == anim-css-floodcolor-overflow-1-from-by.svg anim-css-floodcolor-overflow-1-ref.svg # bug 515919
> layout/reftests/svg/smil/style/reftest.list:skip-if(!styloVsGecko) == anim-css-strokedasharray-1.svg anim-css-strokedasharray-1-ref.svg

For the 3 fails-if(!styloVsGecko) tests, I believe we're fine to leave them as they are, since they should be expected. So, that makes the number even less!!!

Brian and Hiro are still working on the rest. (tracked by bug 1302948)


> layout/reftests/scoped-style/scoped-style-019.svg
> layout/reftests/scoped-style/scoped-style-dynamic-012.svg
> layout/reftests/scoped-style/scoped-style-dynamic-013.svg
> layout/reftests/scoped-style/scoped-style-dynamic-014.svg
> layout/reftests/scoped-style/scoped-style-dynamic-015.svg
> layout/reftests/scoped-style/scoped-style-dynamic-015.svg
>   lack of <style scoped> support (bug 1345702)

We may consider to remove <style scoped> support in Bug 1345702.
Here's the intent to unship thread: https://groups.google.com/forum/#!topic/mozilla.dev.platform/iBoROFkR9V8

Cameron is working on disabling <style scoped> in content documents in Bug 1291515. Even though, we still can't re-enable these tests, unless we resolve Bug 1345702.

So, set Bug 1345702 as a blocker for Bug 1352284 (stylo-svg) for now.
Looks like all the other tests are tracked in other issues.
Priority: -- → P5
Well, this bug is meant for tracking the uncertainty of the SVG tests. Since the remaining tests are very few, and all of the rest are tracked in other bugs that block Bug 1352284 (stylo-svg), I think we can resolve this bug now.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.