137223 - PNG images used in drop-down DIVs paint poorly

Status: VERIFIED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Arun Ranganathan]

Navigate to http://www.thekompany.com/ and put your mouse over the drop down 
menus in the top region.  You'll see that the drop-down menus (DIVs) are using 
a small tiled PNG image to create a transparent menuing experience. This demo 
works great in 0.9.4-based browsers such as N6.2.2, but NOT in Mozilla 0.9.9+ 
or 1.0 branch builds.  That's a shame :-(

Comment 1

[Arun Ranganathan]

Nominating nsbeta1 .

Comment 2

[Bob Clary [:bc] (inactive)]

let's make sure we mark all of these regressions. i don't like the trend i am
seeing here and want to have some stats since that is all that matters to the
powers that be.

Comment 3

[Tristan Nitot]

CCing myself. This bug is really significant. We do not want web sites broken
that have changed their code to use PNGs and DIVs for Gecko-based browsers like
we asked the to do. That would be terrible for the evangelism effort.

Comment 4

[Stuart Parmenter]

over to dcone.  this works fine on linux.  it looks like the tile offset isn't 
being properly used.. or one of the translations isn't quite right..

Comment 5

[Kevin McCluskey (gone)]

nsbeta1+

Comment 6

[dcone (gone)]

Attachment: Fixes the PNG offset problem.

Comment 7

[dcone (gone)]

*** Bug 123511 has been marked as a duplicate of this bug. ***

Comment 8

[dcone (gone)]

*** Bug 125629 has been marked as a duplicate of this bug. ***

Comment 9

[dcone (gone)]

*** Bug 125896 has been marked as a duplicate of this bug. ***

Comment 10

[Kevin McCluskey (gone)]

Don: Can you attach a cvs diff -u patch instead?

Comment 11

[dcone (gone)]

Attachment: -u version of patch..

Comment 12

[Stuart Parmenter]

Comment on attachment 80799 [details] [diff] [review]
-u version of patch.. 

r=pavlov

Comment 13

[Arun Ranganathan]

OK, who can give dcone an SR so this can land for beta?  kmcclusk?

Comment 14

[Kevin McCluskey (gone)]

I'd love to super review this bug, but I'm not a super-reviewer ;).
[e-mail] will perform the super-review.

Comment 15

[Chris Waterson]

dcone: could you describe what this change does? I'm not really familiar with
the code. thanks, chris.

Comment 16

[Marc Attinasi]

Comment on attachment 80799 [details] [diff] [review]
-u version of patch.. 

sr=attinasi

Comment 17

[scottputterman]

adding adt1.0.0-.  Let's look at this for rtm.

Comment 18

[dcone (gone)]

fixed

Comment 19

[tobias]

http://home.t-online.de/home/tobias.preclik/cp/
look at the url. somehow the png graphics are somehow rendered rastered like
they where dithered or downconverted. the dropdowns are redrawn correctly now
(2002042608) but as i said the vertical wave for example which is a background
png and all the other png graphics look dithered (hope this is the right word
for it in english).

Comment 20

[dcone (gone)]

A couple things.
1.)  I noticed the dither also when I went to a 16 bit display, thats probably
normal since its a 24 bit image offscreen being blended.. some colors could be
dithered.

2.)  I fixed a bug that had to do with a 32 bit PNG.. there may be some
artifacts due to that, I am not sure.. but that should be in the trunk soon.  

Bottom line .. PNG's should be getting alot better within the next few days.

Comment 21

[Kevin McCluskey (gone)]

[e-mail]: Can you verify on the trunk? Thanks.

Comment 22

[/\/\arcio Galli]

Nice that this is fixed and thanks Jaime for the topembed nomination ;)

Not only a regression but this is really important for embed-based users. We
want to be able to provide our APIs, sample and demos accross all the Gecko
browsers and reuse our evangelism content! :) without exceptions!

This have also special value for Dinamic Interface/DHTML applications. PNG
images with alpha channel are really effective when are placed inside DHTML
objects. 

Comment 23

[Terri Preston]

fixed on win 2k trunk build 2002051508

Comment 24

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 80799 [details] [diff] [review]
-u version of patch.. 

a=[e-mail] for branch checkin. Please checkin ASAP

Comment 25

[scottputterman]

adding adt1.0.0+.  Please get drivers approval again since more than 3 days have
passed and then check into the 1.0 branch.

Comment 26

[scottputterman]

changing to adt1.0.1+ for checkin to the 1.0 branch for the Mozilla1.0.1
milestone.  Please get drivers approval before checking in.

Comment 27

[Randell Jesup [:jesup] (needinfo me)]

re-approval for 1.0.1
please check into the 1.0.1 branch ASAP. once landed remove the 
mozilla1.0.1+ keyword and add the fixed1.0.1 keyword

Comment 28

[dcone (gone)]

*** Bug 148412 has been marked as a duplicate of this bug. ***

Comment 29

[scottputterman]

please check this into the branch asap.

Comment 30

[dcone (gone)]

Just so I can track this until it gets on the branch.

Comment 31

[Kevin McCluskey (gone)]

Don checked this into the branch.

Comment 32

[Terri Preston]

Verified win 2k branch build 2002061008

Comment 33

[gavin long]

*** Bug 150870 has been marked as a duplicate of this bug. ***

Comment 34

[Wesha]

Attachment: Messed up

Now the transparrency works (2002080119/win98se), but it gets messed up time to
time. Should I file a separate bug?