Closed Bug 1373187 Opened 7 years ago Closed 2 years ago

Zoom level is always 100% in new mail window

Categories

(Thunderbird :: Mail Window Front End, enhancement)

Product:
Thunderbird
Component:
Mail Window Front End
Version:
52 Branch
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: kvg00, Assigned: aleca)

References

Details

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0 Build ID: 20170518000419 Steps to reproduce: 1. Open create new message window. 2. Change zoom level. 3. Send message 4. Close the window 5. Open the window again for new message Actual results: Zoom level is again 100% Expected results: Zoom level should persist between reopening new mail window. It came broken in some previous version (51 or 52).
I don't know that the zoom-level ever persisted in the compose window. It doesn't persist in version TB 38.
(In reply to Jorg K (GMT+2) from comment #1) > I don't know that the zoom-level ever persisted in the compose window. It > doesn't persist in version TB 38. I've been using TB for more than 6 years. And zoom level in compose window (which I usually change by Ctrl+Wheel) ALWAYS persisted while the app was running. It did not persist after closing and reopening the app. But some recent update (51 or 52) changed this behavior. Maybe it is possible now to set default zoom level (other than 100%) in some setting value?
Richard, Aceman, do you know anything about zoom levels?
Flags: needinfo?(richard.marti)
Flags: needinfo?(acelists)
Maybe this worked when TB the recycled windows in Composer had used. Now the window is always newly initialized.
Flags: needinfo?(richard.marti)
Perhaps you were using an addon. I just tested 38.7.0 and zoom did not persist.
Severity: normal → enhancement
See Also: → 834587
I just checked it on absolutely stock version 38.5.0 (and before on v 24) and zoom level in new message is persisted. I open new message form, change zoom by ctrl+wheel, send mail. After that, when I open send new mail form again I get modified zoom level. No plugins, no addons. And it always worked this way, and it was very convenient.
Maybe there is some confusion in what persist mean. I am talking about persisting zoom level in one session. After restarting the app zoom level was default (100%) in all previous versions. But when I changed it, it was the same before closing the app. Now it is not, It is always 100% in new mail form.
OK, I found out what's going on here. In TB 38 we had something called "compose window recycling", so when closing the compose window, it was not destroyed, but only hidden. For the next message, the window was reused. That's how the zoom level persisted. If you opened a second compose window, it had the original zoom level. Also, if you set the preference mail.compose.max_recycled_windows to 0, so no recycling, the zoom level got lost. So it's not that the zoom level persisted, it was accidentally tied to a window which was reused. Logically I don't know how you'd fix this issue: Say you have two different zoom levels in two different windows, which one would you bring back when you open a new window? Of course we could grab the zoom level of the last closed window and restore it for the the next one.
I think in most cases we always use only one window for sending mail, so restoring zoom level from last closed one would be just fine. Maybe you can add new config for this behavior (e.g. mail.compose.persist_zoom_level (true, false)).
(In reply to Jorg K (GMT+1) from comment #8) > In TB 38 we had something called "compose window recycling", so when closing > the compose window, it was not destroyed, but only hidden. For the next > message, the window was reused. That's how the zoom level persisted. Yes, I was also going to propose this and Paenglab suggested it 6 months ago. (In reply to kvg00 from comment #9) > I think in most cases we always use only one window for sending mail, so > restoring zoom level from last closed one would be just fine. Maybe you can > add new config for this behavior (e.g. mail.compose.persist_zoom_level > (true, false)). This could probably be done. In our ComposeUnload() get ZoomManager.zoom (the zoom seems to be implemented via ZoomManager object, see bug 738194) and store it somewhere: probably not a preference, but maybe a xul attribute on the window so it gets persisted automatically, or get it from the XUL store manually, see e.g. https://dxr.mozilla.org/comm-central/rev/b045d93bbd539474f6c9ded13bd993ba2f3e4c07/mailnews/base/prefs/content/AccountManager.js#1463.
Flags: needinfo?(acelists)

In Firefox, there is a Zoom section in Preference - General - Language and Appearance where users can set default zoom level for content. Can we simply follow the way Firefox did to remember and reuse the zoom level when Thunderbird starts?

Assignee: nobody → alessandro

(In reply to atbest from comment #15)

In Firefox, there is a Zoom section in Preference - General - Language and Appearance where users can set default zoom level for content. Can we simply follow the way Firefox did to remember and reuse the zoom level when Thunderbird starts?

We can't follow what Firefox does because Firefox uses an SQLite file stored in the profile, which saves the % zoom of every modified web page, that's why you can have different zoom levels for different pages.
We don't really wanna do that as our browser content (web page) is actually the email, so saving different % zoom for each email doesn't make sense.
We should have a unique pref that saves the edited zoom level and keeps it consistent across emails and when restarting the application.
Also, we should show the % in the app menu like Firefox does.

Status: UNCONFIRMED → NEW
Ever confirmed: true

(In reply to Alessandro Castellani [:aleca] from comment #16)

We can't follow what Firefox does because Firefox uses an SQLite file stored in the profile, which saves the % zoom of every modified web page, that's why you can have different zoom levels for different pages.
We don't really wanna do that as our browser content (web page) is actually the email, so saving different % zoom for each email doesn't make sense.

Sure, you can use any way that is suitable for Thunderbird.

We should have a unique pref that saves the edited zoom level and keeps it consistent across emails and when restarting the application.
Also, we should show the % in the app menu like Firefox does.

I don't think the actual number matters for the user. There is already View - Zoom menus in Thunderbird to change the zoom for the current email. What we need is to set the default zoom level as Firefox does in Preference - General - Language and Appearance, which should not be changed once a suitable zoom level is set, so I don't think an additional menu entry is necessary.

Severity: normal → S3

Now that we have the global font size that affects the entire UI as well as the content of the email, we can close this.
The zoom level can be changed quickly if needed, but at least now there's an easy global preference that affects the font size of the entire application.
Furthermore, Preference - General - Language and Appearance - Advanced allow to override the font family and size of the message body.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX

Update: Comment added by mistake and removed.

Also closed related bug 834587.

You need to log in before you can comment on or make changes to this bug.