Closed Bug 1373868 Opened 7 years ago Closed 7 years ago

Softvision Testing Request for FxA Feature: Mobile Push (Phase 3): Deeplink with email

Categories

(Cloud Services :: Server: Firefox Accounts, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: julie, Assigned: u549602)

References

Details

The FxA team has developed the third phase of Mobile push, the use of deeplinking to pre-populate the sign-in form with the user's email address. Deployment of the backend signin-code APIs and their ability for manual testing of various deep-linking flows happened with Train -89. It's ready for initial testing by Softvision.

Feature description:  

Feature doc:Draft feature doc can be found at https://docs.google.com/document/d/1ObM7gZn0zt1NL4-3enBugZjJrxoD0ODthmuoaoEe7c0/edit#heading=h.kk0dzhot19of   
There's a Github issue that's been opened, https://github.com/mozilla/fxa/issues/246 to write the final version of the feature doc for deep-linking / pre-filled sign-in form that will be stored in Github. 

Proposed/preliminary test plan: Shane Tomlinson is writing a preliminary test plan (started on June 16th) 

Environment in which to test: Deployed to stage with Train-89 on June 14th

Devices to test with: desktop, android, ios

Need testing completed by: TBD

Will the feature ride Fx train? Introduced in train-89

Will there be any automation test covered by the developer(s): No
   If yes, link to automation test suite:  N/A 

Risk Analysis (concerns about any functionality it touches that might require more in depth testing: TBD
Shane, can you please attach the preliminary test plan that you develop for this feature?
Assignee: nobody → mihai.ninu
Flags: needinfo?(stomlinson)
Yup, here it is!

https://github.com/mozilla/fxa/blob/e4387f0da275d22a976c40ada374d42c5f39a34f/features/FxA-54-connect-another-device-phase-3/README.md#test-planacceptance-criteria

When testing against stage, the <server> tags will be accounts.stage.mozaws.net
Flags: needinfo?(stomlinson)
Depends on: 1383943
:Ninu - this feature has been released to prod behind a feature flag and is ready to test!

The updated test plan can be found at https://github.com/mozilla/fxa/tree/master/features/FxA-54-connect-another-device-phase-3#test-planacceptance-criteria.

Note: :vbudhram has been able to get iOS working on his device, I have not been able to. I am going to follow up with Adjust's support team to see if we can figure out why.

Let me know if you or your team have any questions!
Flags: needinfo?(mihai.ninu)
:jbuck - can you confirm whether SMS is enabled for Romania? If it's not, can we enable RO so Mihai and the other folks on his team are able to test?
Flags: needinfo?(jbuckley)
:jbuck confirmed in IRC that SMS is enabled. Turns out we have a bug that manifests in Fx 55+ [1] that prevents the SMS screen from being displayed. I'm digging in now, perhaps give it a whirl in Fx 54.

Clearing the :ni for :jbuck and :ninu since both of us spoke in IRC.
Flags: needinfo?(mihai.ninu)
Flags: needinfo?(jbuckley)
Depends on: 1386636
Can you please point me to the test results? I'd like to close this bug out.
Flags: needinfo?(mihai.ninu)
Hi Julie,

Here is the test-plan for the feature : https://wiki.mozilla.org/QA/Fennec/Deeplink_with_email
Also, the sign-off email was sent on August 11'th for the Android part. As discussed with Shane, i need to pe followed up on when this feature is available on iOS.
Flags: needinfo?(mihai.ninu)
(In reply to Mihai Ninu {:Ninu} from comment #7)
> As discussed with Shane, i need to pe followed up on when this feature is
> available on iOS.

That's where I come in! I forgot to inform you, the feature is available on iOS, 
and could definitely use a hammering. We believe signinCodes are not being 
consumed at a rate we'd expect and we can't figure out why [1]. Any help
trying to come up with STRs that show the problem would be appreciated.

[1] - https://github.com/mozilla/fxa-content-server/issues/5454
Ninu, are you able to schedule in testing of iOS now that the feature is available to the masses? 
We know there are problems with it, we just don't yet know where.
Flags: needinfo?(mihai.ninu)
(In reply to Shane Tomlinson [:stomlinson] from comment #9)
> Ninu, are you able to schedule in testing of iOS now that the feature is
> available to the masses? 
> We know there are problems with it, we just don't yet know where.

Sure, I'll try to accommodate the testing tomorrow and on Monday. 
Hopefully the full sign-off will be on Monday.
Flags: needinfo?(mihai.ninu)
:Ninu - IIRC, you already did this and gave iOS the green light?
Flags: needinfo?(mihai.ninu)
Waiting for SoftVision to look at this...
Hi everyone,

This issue was also tested on iOS devices and I can confirm that it worked well during my test session when I was using my MoCo account and my softvision account to create new accounts.
On the other hand, when trying to create accounts with my personal Gmail account and with an Outlook mail client test account i could not receive the phone number form to input my number and continue from there. 

All I can think about is that we (Softvision folks) got access to the SMS feature (that was available only for US, CA and UK)only on our Softvision and Mozilla accounts to test. 

While testing with the Moco and Softvision account, no issues to report on this feature.

FYI: this is late response because I was in medical leave for some really agonizing long days(sorry).
Flags: needinfo?(mihai.ninu)
We made some updates to this feature and probably will retest it. Shane to confirm...
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(stomlinson)
Resolution: --- → FIXED
Copying in a response sent to Mihai in email:

I see why you aren't getting /sms with your gmail address. 

From the video it looks like you are opening the verification link first without the extra query parameters. When you do this,
it automatically redirects from /verify_email to /connect_another_device. You then reload /connect_another_device with
the extra query parameters. Unfortunately, once /verify_email redirects to /connect_another_device, it's too late. 
It'll never redirect to /sms.

For a redirect to /sms, you have to load the link from the verification email with the extra query parameters. The link
from the verification email will be of the form /verify_email?lots_of_extra_stuff_here.
Flags: needinfo?(stomlinson) → needinfo?(mihai.ninu)
Hi everyone,

After some new testing rounds I can confirm that this feature works great on both Android and iOS. 
A big thank you to Shane for helping me with the configuration. Also the new input number format works fine. 
After a talk with him on IRC, it seems that the number of SMSs sent have increased considerably in the past few days.
As a conclusion, the feature seems stable and we can continue with launching it in small amounts with every train forward. 

Thank you
Flags: needinfo?(mihai.ninu)
You need to log in before you can comment on or make changes to this bug.