1374983 - Popup blocker notification bar appears then immediately disappears

Status: NEW

(Toolkit :: Popup Blocker, defect, P3)

Description

[Geoffrey De Belie (Smile4ever)]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170620030208

Steps to reproduce:

In TheOldReader you can open articles in a new tab. This is done by pressing "o" when there is a summary of the article open. In the past, the popup blocker blocked the popups, so I whitelisted theoldreader.com so the popups come through.

However, since Nightly 2017-06-20 (maybe sooner) the popup whitelisting does not work for me anymore. I'll explain below:


Actual results:

The notification bar to allow popups is created but then immediately destroyed again.


Expected results:

The notification bar should stay open so I can whitelist the current site.

Comment 1

[Loic]

I don't see any "o" to open an article in a new tab. Could you give more details or attach a screenshot: http://imgur.com/juPDIQ4

Comment 2

[Geoffrey De Belie (Smile4ever)]

Attachment: Press "o" on your keyboard when the highlighted element is in focus

Comment 3

[Geoffrey De Belie (Smile4ever)]

(In reply to Loic from comment #1)
> I don't see any "o" to open an article in a new tab. Could you give more
> details or attach a screenshot: http://imgur.com/juPDIQ4

You just needed to click open an article preview, you were almost there :) Then press the "o" key on your keyboard.

Comment 4

[Loic]

WFM wih Nightly. I added https://theoldreader.com/ to the pop-up exception list (note the HTTPS) and when I press "o", the article is open in a new tab.

Comment 5

[Loic]

That said, the pop-up notification disappears quickly, but it's the same behavior with FF54 or old versions of FF like FF33.

Comment 6

[Geoffrey De Belie (Smile4ever)]

(In reply to Loic from comment #4)
> WFM wih Nightly. I added https://theoldreader.com/ to the pop-up exception
> list (note the HTTPS) and when I press "o", the article is open in a new tab.

I added with the HTTP and HTTPS versions, but it didn't work. I tested it again and now whitelisting works...

Please consider this bug report as only being about the notification bar disappearing.

Comment 7

[Matthew N. [:MattN]]

I can reproduce this with or without e10s. It worked fine on 2014-01-02 so I'm finding a regression range. I'm wondering if it's related to bug 1047111.

Comment 8

[Matthew N. [:MattN]]

A login is available at http://bugmenot.com/view/theoldreader.com

Comment 9

[Matthew N. [:MattN]]

Got as far as we can go bisecting nightlies...
Last good revision: ffdd1a398105 (2014-08-20)
First bad revision: dac8b4a0bd7c (2014-08-21)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ffdd1a398105&tochange=dac8b4a0bd7c

I would guess this was bug 1054840 since that code does get hit with this bug.

Comment 11

[Maire Reavy [:mreavy]]

[Tracking Requested - why for this release]: regression to important feature

Note bug 1054840 landed in Fx34

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Sounds like this has been a regression for quite some time. 
I would not block 56 on this issue, but I agree we could try to fix it for 57.

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tagging this as fix-optional given that it's not a new regression. If a fix is ready and low risk, please nominate for uplift to beta57.

Comment 14

[sgl4kn]

Notification bar is in need of a redesign https://bugzilla.mozilla.org/show_bug.cgi?id=1652170

Comment 15

[Timea Cernea [:tbabos][inactive]]

This is still reproducible on the latest Firefox Nightly 96.0a1 version, tested on MacOS 10.15. Updating severity to current severity rankings.