1375793 - Shipping onboarding overlay to all versions

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[[e-mail]]

separate from bug 1369287,

we'd like ship onboarding overlay to all versions during v56

Comment 1

[[e-mail]]

Attachment: Bug 1375793 - Shipping onboarding overlay to all versions;

Review commit: https://reviewboard.mozilla.org/r/153554/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153554/

Comment 2

[[e-mail]]

Comment on attachment 8882417 [details]
Bug 1375793 - Shipping onboarding overlay to all versions;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153554/diff/1-2/

Comment 3

[[e-mail]]

I think after bug 1374573 (final illustration), and bug 1376521 (final string) landed we will be in good shape to show tours for only new user.

The patch removed the nightly build flag so the onboarding will ship with all versions.

Comment 4

[:Gijs (he/him)]

Comment on attachment 8882417 [details]
Bug 1375793 - Shipping onboarding overlay to all versions;

https://reviewboard.mozilla.org/r/153554/#review158692

Mossop's review here is enough, but as I noted last time, doing this before the thing is feature-complete and shipping-blocking-bug-free seems premature. I'm still seeing bugs filed about RTL compat and a11y today, so it seems early to say "hey-ho, let's ship to release".

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8882417 [details]
Bug 1375793 - Shipping onboarding overlay to all versions;

https://reviewboard.mozilla.org/r/153554/#review158812

I agree with Gijs, I'm still seeing potentially large issues with this feature so I'd like to hear a product and UX sign-off before reviewing this.

Comment 6

[[e-mail]]

Comment on attachment 8882417 [details]
Bug 1375793 - Shipping onboarding overlay to all versions;

Hi, onboarding got QA Pre-Beta sign off now (will relay the mail to both of you), it might be the right time to set review again.

Comment 7

[:Gijs (he/him)]

Comment on attachment 8882417 [details]
Bug 1375793 - Shipping onboarding overlay to all versions;

https://reviewboard.mozilla.org/r/153554/#review166698

(In reply to Fred Lin [:gasolin] (OOO till 7/27) from comment #6)
> Comment on attachment 8882417 [details]
> Bug 1375793 - Shipping onboarding overlay to all versions;
> 
> Hi, onboarding got QA Pre-Beta sign off now (will relay the mail to both of
> you), it might be the right time to set review again.

As noted before, Mossop's review is sufficient here, so I'm clearing review and leaving this up to him. However, note that Mossop wrote:

(In reply to Dave Townsend [:mossop] from comment #5)
> I'm still seeing potentially large issues with this
> feature so I'd like to hear a product and UX sign-off before reviewing this.

While it's good to have QA sign-off, that's quite different from UX and product sign-off.

Comment 8

[Dave Townsend [:mossop]]

Comment on attachment 8882417 [details]
Bug 1375793 - Shipping onboarding overlay to all versions;

https://reviewboard.mozilla.org/r/153554/#review166824

Comment 9

[[e-mail]]

Comment on attachment 8882417 [details]
Bug 1375793 - Shipping onboarding overlay to all versions;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153554/diff/2-3/

Comment 10

[[e-mail]]

Thanks! We periodically sync the progress with UX and product twice a week, and I think they are happy to ship onboarding to all versions.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f683a2f11afb
Shipping onboarding overlay to all versions;r=mossop

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f683a2f11afb

Comment 13

[Justin [:JW_SoftvisionQA]]

I have verified that this is fixed.