Shipping onboarding overlay to all versions

VERIFIED FIXED in Firefox 56

Status

()

enhancement
P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: gasolin, Assigned: gasolin)

Tracking

(Depends on 1 bug)

unspecified
Firefox 56
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [photon-onboarding])

Attachments

(1 attachment)

Assignee

Description

2 years ago
separate from bug 1369287,

we'd like ship onboarding overlay to all versions during v56
Assignee

Updated

2 years ago
Assignee: nobody → gasolin
Blocks: 1354046
No longer depends on: 1369287
Flags: qe-verify+
Priority: -- → P1
See Also: → 1369287
Whiteboard: [photon-onboarding]
Target Milestone: --- → Firefox 56
QA Contact: jwilliams
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Depends on: 1374573
Assignee

Updated

2 years ago
Depends on: 1376521
Comment hidden (mozreview-request)
Assignee

Comment 3

2 years ago
I think after bug 1374573 (final illustration), and bug 1376521 (final string) landed we will be in good shape to show tours for only new user.

The patch removed the nightly build flag so the onboarding will ship with all versions.

Comment 4

2 years ago
mozreview-review
Comment on attachment 8882417 [details]
Bug 1375793 - Shipping onboarding overlay to all versions;

https://reviewboard.mozilla.org/r/153554/#review158692

Mossop's review here is enough, but as I noted last time, doing this before the thing is feature-complete and shipping-blocking-bug-free seems premature. I'm still seeing bugs filed about RTL compat and a11y today, so it seems early to say "hey-ho, let's ship to release".
Attachment #8882417 - Flags: review?(gijskruitbosch+bugs)

Comment 5

2 years ago
mozreview-review
Comment on attachment 8882417 [details]
Bug 1375793 - Shipping onboarding overlay to all versions;

https://reviewboard.mozilla.org/r/153554/#review158812

I agree with Gijs, I'm still seeing potentially large issues with this feature so I'd like to hear a product and UX sign-off before reviewing this.
Attachment #8882417 - Flags: review?(dtownsend)

Updated

2 years ago
Depends on: 1377347

Updated

2 years ago
Depends on: 1378134
Assignee

Comment 6

2 years ago
Comment on attachment 8882417 [details]
Bug 1375793 - Shipping onboarding overlay to all versions;

Hi, onboarding got QA Pre-Beta sign off now (will relay the mail to both of you), it might be the right time to set review again.
Attachment #8882417 - Flags: review?(gijskruitbosch+bugs)
Attachment #8882417 - Flags: review?(dtownsend)

Comment 7

2 years ago
mozreview-review
Comment on attachment 8882417 [details]
Bug 1375793 - Shipping onboarding overlay to all versions;

https://reviewboard.mozilla.org/r/153554/#review166698

(In reply to Fred Lin [:gasolin] (OOO till 7/27) from comment #6)
> Comment on attachment 8882417 [details]
> Bug 1375793 - Shipping onboarding overlay to all versions;
> 
> Hi, onboarding got QA Pre-Beta sign off now (will relay the mail to both of
> you), it might be the right time to set review again.

As noted before, Mossop's review is sufficient here, so I'm clearing review and leaving this up to him. However, note that Mossop wrote:

(In reply to Dave Townsend [:mossop] from comment #5)
> I'm still seeing potentially large issues with this
> feature so I'd like to hear a product and UX sign-off before reviewing this.

While it's good to have QA sign-off, that's quite different from UX and product sign-off.
Attachment #8882417 - Flags: review?(gijskruitbosch+bugs)

Comment 8

2 years ago
mozreview-review
Comment on attachment 8882417 [details]
Bug 1375793 - Shipping onboarding overlay to all versions;

https://reviewboard.mozilla.org/r/153554/#review166824
Attachment #8882417 - Flags: review?(dtownsend) → review+
Comment hidden (mozreview-request)
Assignee

Comment 10

2 years ago
Thanks! We periodically sync the progress with UX and product twice a week, and I think they are happy to ship onboarding to all versions.
Keywords: checkin-needed

Comment 11

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f683a2f11afb
Shipping onboarding overlay to all versions;r=mossop
Keywords: checkin-needed

Comment 12

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f683a2f11afb
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED

Updated

2 years ago
Depends on: 1386226
I have verified that this is fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.