[meta] FX_TAB_SWITCH_TOTAL_E10S_MS probe (and a bunch of others) have expired

ASSIGNED
Assigned to

Status

()

Toolkit
Telemetry
P3
normal
ASSIGNED
a year ago
9 months ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

(Depends on: 1 bug, {leave-open, meta})

unspecified
leave-open, meta
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fix-optional)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

FX_TAB_SWITCH_TOTAL_E10S_MS, and a bunch of other probes listed in Histograms.json have expired. Those probes are:

[
	"APPLICATION_REPUTATION_SERVER_VERDICT",
	"APPLICATION_REPUTATION_REMOTE_LOOKUP_TIMEOUT",
	"CREATE_EVENT_COMPOSITIONEVENT",
	"CREATE_EVENT_CUSTOMEVENT",
	"CREATE_EVENT_DEVICEMOTIONEVENT",
	"CREATE_EVENT_DEVICEORIENTATIONEVENT",
	"CREATE_EVENT_DRAGEVENT",
	"CREATE_EVENT_ERROREVENT",
	"CREATE_EVENT_EVENT",
	"CREATE_EVENT_EVENTS",
	"CREATE_EVENT_HASHCHANGEEVENT",
	"CREATE_EVENT_HTMLEVENTS",
	"CREATE_EVENT_KEYBOARDEVENT",
	"CREATE_EVENT_KEYEVENTS",
	"CREATE_EVENT_MESSAGEEVENT",
	"CREATE_EVENT_MOUSEEVENT",
	"CREATE_EVENT_MOUSEEVENTS",
	"CREATE_EVENT_MOUSESCROLLEVENTS",
	"CREATE_EVENT_MUTATIONEVENT",
	"CREATE_EVENT_MUTATIONEVENTS",
	"CREATE_EVENT_POPSTATEEVENT",
	"CREATE_EVENT_SCROLLAREAEVENT",
	"CREATE_EVENT_STORAGEEVENT",
	"CREATE_EVENT_SVGEVENTS",
	"CREATE_EVENT_TEXTEVENT",
	"CREATE_EVENT_TIMEEVENT",
	"CREATE_EVENT_TOUCHEVENT",
	"CREATE_EVENT_UIEVENT",
	"CREATE_EVENT_UIEVENTS",
	"CREATE_EVENT_XULCOMMANDEVENT",
	"CREATE_EVENT_XULCOMMANDEVENTS",
	"HTTP_RESPONSE_STATUS_CODE",
	"FX_TAB_SWITCH_TOTAL_MS",
	"FX_TAB_SWITCH_TOTAL_E10S_MS",
	"FORM_ISINDEX_USED",
	"SCRIPT_BLOCK_INCORRECT_MIME",
	"XCTO_NOSNIFF_BLOCK_IMAGE",
	"PRINT_PREVIEW_OPENED_COUNT",
	"PRINT_PREVIEW_SIMPLIFY_PAGE_OPENED_COUNT",
	"PRINT_PREVIEW_SIMPLIFY_PAGE_UNAVAILABLE_COUNT",
	"PRINT_DIALOG_OPENED_COUNT",
	"PRINT_COUNT",
	"DEVTOOLS_MEMORY_TAKE_SNAPSHOT_COUNT",
	"DEVTOOLS_MEMORY_IMPORT_SNAPSHOT_COUNT",
	"DEVTOOLS_MEMORY_EXPORT_SNAPSHOT_COUNT",
	"DEVTOOLS_MEMORY_FILTER_CENSUS",
	"DEVTOOLS_MEMORY_DIFF_CENSUS",
	"DEVTOOLS_MEMORY_INVERTED_CENSUS",
	"DEVTOOLS_MEMORY_BREAKDOWN_CENSUS_COUNT",
	"DEVTOOLS_MEMORY_DOMINATOR_TREE_COUNT",
	"DEVTOOLS_MEMORY_BREAKDOWN_DOMINATOR_TREE_COUNT",
	"JS_AOT_USAGE",
	"CONTENT_PAINT_TIME",
	"CONTENT_LARGE_PAINT_PHASE_WEIGHT",
	"NARRATE_CONTENT_BY_LANGUAGE_2",
	"NARRATE_CONTENT_SPEAKTIME_MS",
	"TABCHILD_PAINT_TIME",
	"DISPLAY_ITEM_USAGE_COUNT"
]

We should figure out which ones we need to keep collecting here.
Speaking for myself, I would like to extend collection of the following probes:

FX_TAB_SWITCH_TOTAL_MS (until 57)
FX_TAB_SWITCH_TOTAL_E10S_MS (until 60?)
PRINT_PREVIEW_OPENED_COUNT
PRINT_PREVIEW_SIMPLIFY_PAGE_OPENED_COUNT
PRINT_PREVIEW_SIMPLIFY_PAGE_UNAVAILABLE_COUNT
PRINT_DIALOG_OPENED_COUNT
PRINT_COUNT
TABCHILD_PAINT_TIME

Hey digitarald, are you relying on any of the above probes?
Flags: needinfo?(hkirschner)

Comment 2

a year ago
To extend collection, bump the expires_in_version to a more acceptable value and request r? on the patch from a telemetry person (I _suppose_ you can ask me. If you must. I guess.) and data-r? from a Data Peer as per the Data Collection process: https://wiki.mozilla.org/Firefox/Data_Collection

If you want to upgrade any from a definite expiry to never-expires, throw each of those new "never"s in their own commit as they'll likely require additional scrutiny and tests.
In reply to Chris H-C :chutten from comment #2)
> To extend collection, bump the expires_in_version to a more acceptable value
> and request r? on the patch from a telemetry person (I _suppose_ you can ask
> me. If you must. I guess.) and data-r? from a Data Peer as per the Data
> Collection process: https://wiki.mozilla.org/Firefox/Data_Collection

Cool, thanks.

(In reply to Mike Conley (:mconley) - Digging out of needinfo / review backlog. from comment #1)
> 
> Hey digitarald, are you relying on any of the above probes?

To be clear, I meant the probes listed in comment 0 that I didn't already mention in comment 1.
Your list contains what I would have selected as well, Mike. I pinged Milan about the gfx probes.
Flags: needinfo?(hkirschner)
Priority: -- → P3
Mike, i assume you are tracking this bug?
Flags: needinfo?(mconley)
Comment hidden (mozreview-request)
(In reply to :Harald Kirschner :digitarald from comment #4)
> Your list contains what I would have selected as well, Mike. I pinged Milan
> about the gfx probes.

leave-open in case multiple landings are needed to deal with this.  Extended the gfx ones to 60 for now.  We definitely want to see how retained display lists and other work change things here.
Keywords: leave-open
Comment on attachment 8885276 [details]
Bug 1378146: Extend CONTENT_PAINT_TIME and CONTENT_LARGE_PAINT_PHASE_WEIGHT to 60, and update the e-mails.

https://reviewboard.mozilla.org/r/156148/#review161378
Attachment #8885276 - Flags: review?(dvander) → review+

Comment 9

a year ago
Pushed by msreckovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d47ea404c95b
Extend CONTENT_PAINT_TIME and CONTENT_LARGE_PAINT_PHASE_WEIGHT to 60, and update the e-mails. r=dvander
Do we need data-review+ on extending collection times like this? If so, are you able to give a post-facto data-r+ on attachment 8885276 [details], or should we back it out?
Flags: needinfo?(benjamin)

Comment 11

a year ago
Yes you should ask for data-steward review on extensions, and this is fine data-r=me
Flags: needinfo?(benjamin)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Hey liuche,

I'm extending some expired probes here in my two patches. Would it be possible to get a data review?
Flags: needinfo?(mconley) → needinfo?(liuche)

Comment 15

a year ago
mozreview-review
Comment on attachment 8885747 [details]
Bug 1378146 - Extend printing Telemetry probes. , data-review=liuche

https://reviewboard.mozilla.org/r/156548/#review161640

rs=me
Attachment #8885747 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 16

a year ago
mozreview-review
Comment on attachment 8885746 [details]
Bug 1378146 - Extend tab switch timing probes and update alert emails. , data-review=liuche

https://reviewboard.mozilla.org/r/156546/#review161648
Attachment #8885746 - Flags: review?(gkrizsanits) → review+
Comment on attachment 8885746 [details]
Bug 1378146 - Extend tab switch timing probes and update alert emails. , data-review=liuche

https://reviewboard.mozilla.org/r/156546/#review161712
Attachment #8885746 - Flags: review+
Comment on attachment 8885747 [details]
Bug 1378146 - Extend printing Telemetry probes. , data-review=liuche

https://reviewboard.mozilla.org/r/156548/#review161714
Attachment #8885747 - Flags: review+

Comment 19

a year ago
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/af70cce986e7
Extend tab switch timing probes and update alert emails. r=krizsa,liuche, data-review=liuche
https://hg.mozilla.org/integration/autoland/rev/d5c37739a12e
Extend printing Telemetry probes. r=Gijs,liuche, data-review=liuche

Comment 22

11 months ago
Making sure this stays on someone's radar. Mike, can this be closed or are there remaining probes to deal with?

Clearing ni for liuche given she's r+'d the patches and they've landed. :-)
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Flags: needinfo?(liuche) → needinfo?(mconley)
I'm going to needinfo the folks who landed the remaining probes that have expired.

Folks who I'm needinfo'ing here - are we okay to let these go?

gcp: (bug 1050141)
"APPLICATION_REPUTATION_SERVER_VERDICT",
"APPLICATION_REPUTATION_REMOTE_LOOKUP_TIMEOUT",

smaug: (bug 1295588)
"CREATE_EVENT_COMPOSITIONEVENT",
"CREATE_EVENT_CUSTOMEVENT",
"CREATE_EVENT_DEVICEMOTIONEVENT",
"CREATE_EVENT_DEVICEORIENTATIONEVENT",
"CREATE_EVENT_DRAGEVENT",
"CREATE_EVENT_ERROREVENT",
"CREATE_EVENT_EVENT",
"CREATE_EVENT_EVENTS",
"CREATE_EVENT_HASHCHANGEEVENT",
"CREATE_EVENT_HTMLEVENTS",
"CREATE_EVENT_KEYBOARDEVENT",
"CREATE_EVENT_KEYEVENTS",
"CREATE_EVENT_MESSAGEEVENT",
"CREATE_EVENT_MOUSEEVENT",
"CREATE_EVENT_MOUSEEVENTS",
"CREATE_EVENT_MOUSESCROLLEVENTS",
"CREATE_EVENT_MUTATIONEVENT",
"CREATE_EVENT_MUTATIONEVENTS",
"CREATE_EVENT_POPSTATEEVENT",
"CREATE_EVENT_SCROLLAREAEVENT",
"CREATE_EVENT_STORAGEEVENT",
"CREATE_EVENT_SVGEVENTS",
"CREATE_EVENT_TEXTEVENT",
"CREATE_EVENT_TIMEEVENT",
"CREATE_EVENT_TOUCHEVENT",
"CREATE_EVENT_UIEVENT",
"CREATE_EVENT_UIEVENTS",
"CREATE_EVENT_XULCOMMANDEVENT",
"CREATE_EVENT_XULCOMMANDEVENTS",

ckerschb: (bug 1272345, bug 1288361, bug 1302539)
"HTTP_RESPONSE_STATUS_CODE",
"SCRIPT_BLOCK_INCORRECT_MIME",
"XCTO_NOSNIFF_BLOCK_IMAGE",

ehsan: (bug 1356181)
"FORM_ISINDEX_USED",

fitzgen: (bug 1221619)
"DEVTOOLS_MEMORY_TAKE_SNAPSHOT_COUNT",
"DEVTOOLS_MEMORY_IMPORT_SNAPSHOT_COUNT",
"DEVTOOLS_MEMORY_EXPORT_SNAPSHOT_COUNT",
"DEVTOOLS_MEMORY_FILTER_CENSUS",
"DEVTOOLS_MEMORY_DIFF_CENSUS",
"DEVTOOLS_MEMORY_INVERTED_CENSUS",
"DEVTOOLS_MEMORY_BREAKDOWN_CENSUS_COUNT",
"DEVTOOLS_MEMORY_DOMINATOR_TREE_COUNT",
"DEVTOOLS_MEMORY_BREAKDOWN_DOMINATOR_TREE_COUNT",

bbouvier: (bug 1288778)
"JS_AOT_USAGE",

eeejay: (bug 1324868, bug 1308030)
"NARRATE_CONTENT_BY_LANGUAGE_2",
"NARRATE_CONTENT_SPEAKTIME_MS",

mchang: (bug 1353521)
"DISPLAY_ITEM_USAGE_COUNT"
Flags: needinfo?(nfitzgerald)
Flags: needinfo?(mconley)
Flags: needinfo?(mchang)
Flags: needinfo?(gpascutto)
Flags: needinfo?(eitan)
Flags: needinfo?(ehsan)
Flags: needinfo?(ckerschb)
Flags: needinfo?(bugs)
Flags: needinfo?(bbouvier)
Depends on: 1381034
Converting this into a meta. For remaining probe work, we should probably file new bugs blocking this one, like mchang just did.
Keywords: meta
Summary: FX_TAB_SWITCH_TOTAL_E10S_MS probe (and a bunch of others) have expired → [meta] FX_TAB_SWITCH_TOTAL_E10S_MS probe (and a bunch of others) have expired
Flags: needinfo?(mchang)
(In reply to Mike Conley (:mconley) - Digging out of needinfo / review backlog. from comment #23)
> ckerschb: (bug 1272345, bug 1288361, bug 1302539)
> "HTTP_RESPONSE_STATUS_CODE",
> "SCRIPT_BLOCK_INCORRECT_MIME",
> "XCTO_NOSNIFF_BLOCK_IMAGE",

No need for those probes anymore. If you want me to write a patch to remove them, please let me know. Thanks for reaching out.
Flags: needinfo?(ckerschb)
Forwarding ni to jimb: Jim, is anyone still looking at these telemetry probes / are they worth renewing?
Flags: needinfo?(nfitzgerald) → needinfo?(jimb)
Forward ni to francois: I think monitoring health of the remote server (that isn't ours) is still intersting for us?
Flags: needinfo?(gpascutto) → needinfo?(francois)

Comment 28

11 months ago
(In reply to Christoph Kerschbaumer [:ckerschb] from comment #25)
> (In reply to Mike Conley (:mconley) - Digging out of needinfo / review
> backlog. from comment #23)
> > ckerschb: (bug 1272345, bug 1288361, bug 1302539)
> > "HTTP_RESPONSE_STATUS_CODE",
> > "SCRIPT_BLOCK_INCORRECT_MIME",
> > "XCTO_NOSNIFF_BLOCK_IMAGE",
> 
> No need for those probes anymore. If you want me to write a patch to remove
> them, please let me know. Thanks for reaching out.

Please do! We have an awful lot of expired probes cluttering Histograms.json.

Comment 29

11 months ago
We are not working on the memory profiling tools right now, so I think we can lose all the DEVTOOLS_MEMORY_ telemetry probes for now.
Flags: needinfo?(jimb)

Updated

11 months ago
Depends on: 1381178
Depends on: 1381467
Thanks for the ping, opened bug 1381467. Do we need another data review for extending?
Flags: needinfo?(bbouvier)
(In reply to Benjamin Bouvier [:bbouvier] from comment #30)
> Thanks for the ping, opened bug 1381467. Do we need another data review for
> extending?

Yes (see comment 11). I'll also mention that in bug 1381467 for reference.

Comment 32

11 months ago
ok to remove the CREATE_EVENT_*
Flags: needinfo?(bugs)

Updated

11 months ago
Depends on: 1381544
Opened bug 1381544 for narrate probes. Thanks for the heads up!
Flags: needinfo?(eitan)
Depends on: 1381691
(In reply to Gian-Carlo Pascutto [:gcp] from comment #27)
> Forward ni to francois: I think monitoring health of the remote server (that
> isn't ours) is still intersting for us?

Indeed. I have filed bug 1381691 to extend these.
Flags: needinfo?(francois)

Comment 35

11 months ago
(In reply to Mike Conley (:mconley) - Digging out of needinfo / review backlog. from comment #23)
> ehsan: (bug 1356181)
> "FORM_ISINDEX_USED",

OK to remove, the feature this was testing was removed in bug 1266495.
Flags: needinfo?(ehsan)

Updated

11 months ago
Depends on: 1382269
status-firefox57: --- → fix-optional
You need to log in before you can comment on or make changes to this bug.