|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
+++ This bug was initially created as a clone of Bug #1344782 +++ Let's update to compare-locales 2.0
Depends on: 1376761
Summary: Update in-tree version of compare-locales to 2.0 → Update in-tree version of compare-locales to 2.1
Splitting the review between libraries and build, stas for the former, glandium for the latter. This is green on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=be64f34bf2e5f09dd6f2c65c499ed496df3979d3 The build changes are really mostly removal and then just adding the shims to make the upstream compare-locales command logic work. I'm just a bit torn on keeping the mach command. I like that people that know the details can still run the in-tree compare-locales code. OTH, with the build owning the process now, this could also be a py_action. Maybe in a different bug, if that's a good idea. I wish it'd be easy to call py_actions from the command line, ./mach python -m mozbuild.action.foo is quite a mouthful.
Comment on attachment 8909805 [details] bug 1382005, vendor new dependency for compare-locales, python-fluent, https://reviewboard.mozilla.org/r/181296/#review186594
Attachment #8909805 - Flags: review?(stas) → review+
Comment on attachment 8909806 [details] bug 1382005, update compare-locales to 2.1, https://reviewboard.mozilla.org/r/181298/#review186608
Attachment #8909806 - Flags: review?(stas) → review+
Moving over to build config, as that's mostly what this bug is about.
Component: compare-locales → Build Config
Product: Localization Infrastructure and Tools → Core
Comment on attachment 8909807 [details] bug 1382005, make mach command a bare minimum wrapper, https://reviewboard.mozilla.org/r/181300/#review187416
Attachment #8909807 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8909808 [details] bug 1382005, update compare-locales to 2.1, https://reviewboard.mozilla.org/r/181302/#review187418 ::: toolkit/locales/l10n.mk:208 (Diff revision 1) > $(NSINSTALL) -D $(L10NBASEDIR) ; \ > $(L10N_CO) ; \ > fi > endif > $(RM) -rf $(REAL_LOCALE_MERGEDIR) > - $(MOZILLA_DIR)/mach compare-locales --l10n-base $(L10NBASEDIR) --merge-dir $(REAL_LOCALE_MERGEDIR) $* > + $(MOZILLA_DIR)/mach compare-locales --merge $(BASE_MERGE) $(srcdir)/l10n.toml $(L10NBASEDIR) $* These 4 patches should all be folded into one. Because the state of the tree is essentially broken after the first patch and until this last one.
Attachment #8909808 - Flags: review?(mh+mozilla) → review+
Attachment #8909805 - Attachment is obsolete: true
Attachment #8909806 - Attachment is obsolete: true
Attachment #8909807 - Attachment is obsolete: true
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/c6d94140d11b update compare-locales to 2.1, r=glandium
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
8 months ago
Depends on: 1402401
You need to log in before you can comment on or make changes to this bug.