Update in-tree version of compare-locales to 2.1

RESOLVED FIXED in Firefox 58

Status

Firefox Build System
General
P1
normal
RESOLVED FIXED
10 months ago
3 months ago

People

(Reporter: Pike, Assigned: Pike)

Tracking

unspecified
mozilla58
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

10 months ago
+++ This bug was initially created as a clone of Bug #1344782 +++

Let's update to compare-locales 2.0
(Assignee)

Updated

10 months ago
Assignee: nobody → l10n
(Assignee)

Updated

10 months ago
Priority: -- → P1
(Assignee)

Updated

10 months ago
Depends on: 1382632
(Assignee)

Updated

9 months ago
Depends on: 1376761
Summary: Update in-tree version of compare-locales to 2.0 → Update in-tree version of compare-locales to 2.1
(Assignee)

Updated

9 months ago
Depends on: 1396580
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 5

8 months ago
Splitting the review between libraries and build, stas for the former, glandium for the latter.

This is green on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=be64f34bf2e5f09dd6f2c65c499ed496df3979d3

The build changes are really mostly removal and then just adding the shims to make the upstream compare-locales command logic work. I'm just a bit torn on keeping the mach command. I like that people that know the details can still run the in-tree compare-locales code. OTH, with the build owning the process now, this could also be a py_action. Maybe in a different bug, if that's a good idea.

I wish it'd be easy to call py_actions from the command line, ./mach python -m mozbuild.action.foo is quite a mouthful.

Comment 6

8 months ago
mozreview-review
Comment on attachment 8909805 [details]
bug 1382005, vendor new dependency for compare-locales, python-fluent,

https://reviewboard.mozilla.org/r/181296/#review186594
Attachment #8909805 - Flags: review?(stas) → review+

Comment 7

8 months ago
mozreview-review
Comment on attachment 8909806 [details]
bug 1382005, update compare-locales to 2.1,

https://reviewboard.mozilla.org/r/181298/#review186608
Attachment #8909806 - Flags: review?(stas) → review+
(Assignee)

Comment 8

8 months ago
Moving over to build config, as that's mostly what this bug is about.
Component: compare-locales → Build Config
Product: Localization Infrastructure and Tools → Core

Comment 9

8 months ago
mozreview-review
Comment on attachment 8909807 [details]
bug 1382005, make mach command a bare minimum wrapper,

https://reviewboard.mozilla.org/r/181300/#review187416
Attachment #8909807 - Flags: review?(mh+mozilla) → review+

Comment 10

8 months ago
mozreview-review
Comment on attachment 8909808 [details]
bug 1382005, update compare-locales to 2.1,

https://reviewboard.mozilla.org/r/181302/#review187418

::: toolkit/locales/l10n.mk:208
(Diff revision 1)
>  		$(NSINSTALL) -D $(L10NBASEDIR) ; \
>  		$(L10N_CO) ; \
>  	fi
>  endif
>  	$(RM) -rf $(REAL_LOCALE_MERGEDIR)
> -	$(MOZILLA_DIR)/mach compare-locales --l10n-base $(L10NBASEDIR) --merge-dir $(REAL_LOCALE_MERGEDIR) $*
> +	$(MOZILLA_DIR)/mach compare-locales --merge $(BASE_MERGE) $(srcdir)/l10n.toml $(L10NBASEDIR) $*

These 4 patches should all be folded into one. Because the state of the tree is essentially broken after the first patch and until this last one.
Attachment #8909808 - Flags: review?(mh+mozilla) → review+
No longer blocks: 1365426
Comment hidden (mozreview-request)
(Assignee)

Updated

8 months ago
Attachment #8909805 - Attachment is obsolete: true
(Assignee)

Updated

8 months ago
Attachment #8909806 - Attachment is obsolete: true
(Assignee)

Updated

8 months ago
Attachment #8909807 - Attachment is obsolete: true

Comment 12

8 months ago
Pushed by axel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6d94140d11b
update compare-locales to 2.1, r=glandium

Comment 13

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c6d94140d11b
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.