1387762 - Status of Find bar settings are difficult to discern in dark theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Greg]

Attachment: Highlight All.png

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.78 Safari/537.36

Steps to reproduce:

activated the Find bar and selected "Highlight All".

See screenshot of Find bar. Can you tell whether "Highlight All" is enabled or not?


Actual results:

I couldn't tell whether any change occurred in the setting. Is "Highlight All" enabled or disabled? With Dark Theme, it's difficult to discern what state the setting is in.


Expected results:

As with Bug 1386919, Mozilla is making poor usability decisions with no consideration for people with visual disabilities. It should be clearly discernible whether a setting is enabled or not, and it is not in Dark Theme.

Comment 1

[:Gijs (he/him)]

(In reply to Greg from comment #0)
> As with Bug 1386919, Mozilla is making poor usability decisions with no
> consideration for people with visual disabilities. It should be clearly
> discernible whether a setting is enabled or not, and it is not in Dark Theme.

I'm pretty sure this is simply a bug / regression. This is normal in Nightly. It would be helpful if you can clarify when exactly this broke, like by using mozregression ( https://mozilla.github.io/mozregression/ ), instead of assuming bad faith.

Comment 2

[Greg]

I believe the regression started in v57 with the "new" dark theme.

This issue is not as bad in v54, but even in v54 it is not as good a design as it should be. The "dark highlight" is much easier to see in v54, but it should be a "bright highlight" or even a color change to accommodate people with visual disabilities etc. So obviously, the situation in v57 is a regression, but I am also taking issue with the "intended" design of v57 and even v54.

You guys should be clearly indicating focus with "bright highlight" or changed color and not simply reducing a shade, like you are currently doing with focused tab, find bar settings, etc. This is my argument that you are describing as "bad faith."

Comment 5

[Tim Nguyen :ntim]

Looks like the findbar is missing the [brighttext] attribute to make this rule apply: https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/toolbarbuttons.inc.css#31

Comment 6

[Dale Harvey (:daleharvey)]

Attachment: Bug 1387762 - Ensure findbar is correctly styled in dark theme.

Review commit: https://reviewboard.mozilla.org/r/176788/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/176788/

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8904964 [details]
Bug 1387762 - Ensure findbar is correctly styled in dark theme.

https://reviewboard.mozilla.org/r/176788/#review181734

::: browser/themes/shared/toolbarbuttons.inc.css:33
(Diff revision 1)
>  
>  :root[uidensity=touch] {
>    --toolbarbutton-inner-padding: 9px;
>  }
>  
> -toolbar[brighttext] {
> +:root:-moz-lwtheme-brighttext {

Unfortunately this is completely wrong for dark OS themes.

Comment 8

[Dão Gottwald [:dao]]

I guess we could use both selectors, although this would still leave this bug unfixed for dark OS themes.

Comment 9

[Tim Nguyen :ntim]

Why not add the findbar to this selector: https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#8706 ?

Then make the CSS rule apply to findbar[brighttext]

Comment 10

[Dão Gottwald [:dao]]

Attachment: Bug 1387762 - Define default --toolbarbutton-hover-background and --toolbarbutton-active-background values that work on both light and dark backgrounds.

Review commit: https://reviewboard.mozilla.org/r/177688/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177688/

Comment 11

[Dale Harvey (:daleharvey)]

Comment on attachment 8905880 [details]
Bug 1387762 - Define default --toolbarbutton-hover-background and --toolbarbutton-active-background values that work on both light and dark backgrounds.

https://reviewboard.mozilla.org/r/177688/#review182824

Thats a pretty smart solution and works well here

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40df319376b8
Define default --toolbarbutton-hover-background and --toolbarbutton-active-background values that work on both light and dark backgrounds. r=daleharvey

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/40df319376b8

Comment 14

[Sajedul Islam]

I have reproduced this bug with Nightly 57.0a1 (2017-08-05) on Windows 8.1, 64-Bit ! 

This bug's fix is Verified with latest Nightly !

Build   ID    20170909100226
User Agent    Mozilla/5.0 (Windows NT 6.3; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0

[bugday-20170906]