1388376 - Reader mode button should be removable from Address Bar (make reader mode a 'real' page action)

Status: NEW

(Firefox :: Toolbars and Customization, defect, P5)

Description

[Ronan Jouchet]

With Photon it's great to be able to
- Pin commonly-used Page Actions to the address bar, always visible
- Shove unused Page Actions to the "..." menu

Given I use Reader View only rarely, I'd like to hide it,
but it's not possible: it doesn't seem to support
Right click > "Remove from Address Bar"

Comment 2

[:Gijs (he/him)]

TBH, it's not super clear to me how this would work - if you add the button to the page action panel, clearly it should be greyed out (disabled) if reader mode is not available, rather than hidden.

But then if you add it to the location bar, what happens if it's not available? What happens if it's not available when you add it? It'll just look odd to say "add to address bar" and for that to do "nothing". Likewise, if the icon gets mixed in with all the other icons, it'll cause all of the other icons to shift when the button appears/disappears.

The alternative would be to just always display it and come up with some kind of disabled state for the button in the location bar.

None of those really sound very attractive.


Note that users who really really don't like reader mode and the button showing up in the URL bar can already just turn it off in about:config.

Comment 3

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

I would prefer having the reader view in the page actions menu not because I do not like it, but because it already appears or disappears now and than. This is just my personal opinion, but I would be more happy if it's in the page actions without the option to move it to the addressbar, rather than having it in the addressbar just "sometimes".

Comment 4

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Looking at how it behaves now, all entries seems to appear in the menu all the time now, while in the address bar only when available. When not available (like report page issues in Nightly on about: pages), it's grayed out in the menu and not displayed in the bar. That's a way I can imagine this working for reader view. To be even more clear, the title could change to something like "Reader mode not available on this page" in the menu, or "This page does not support Reader mode".

Comment 5

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Btw. the behaviour should be probably the same as for the subscribe action (bug 1375687).

Comment 7

[Drew Willcoxon :adw]

To be clear, the spec for 57 shows this as a separate, non-page-action icon.  Beyond 57, it's really up to UX whether we want to change that, so I'm CC'ing Aaron.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S4. However, the bug has 3 duplicates.
:Gijs, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 10

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.