1389458 - [meta] Implement WebAssembly threads proposal

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Lars T Hansen [:lth]]

Proposal repo:
https://github.com/WebAssembly/threads

Main proposal text:
https://github.com/WebAssembly/threads/blob/master/proposals/threads/Overview.md

The proposal is stable and basically finished but may not be completely nailed down until the November 2017 CG meeting.  If we land before then (and I think we should do that) we should land behind a NIGHTLY flag or similar.

Comment 1

[Lars T Hansen [:lth]]

Attachment: wasm-atomics.bundle

WIP, mostly for safekeeping purposes.  Atomics work (so far as a casual observer is concerned) in the baseline compiler; Ion is still missing 64-bit atomics.  Most of the pieces are here but the Memory object does not allocate shared memory yet.  Lots of work remains.

Comment 2

[Lars T Hansen [:lth]]

Attachment: wasm-threads.bundle

Another snapshot.  This has a complete implementation of thread ops and atomics of all sizes for all tier-1 platforms but the queue is pretty messy, and there's some outstanding cleanup.

Comment 3

[Lars T Hansen [:lth]]

Functionally complete and with test cases apart from the issue around atomic access to current_memory during a concurrent grow_memory:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1148fff7492d327d5d2f6bf281603e19a18cf40a

Comment 4

[Lars T Hansen [:lth]]

Attachment: wasm-threads.bundle

The patch set for that try run.

Comment 5

[Lars T Hansen [:lth]]

Attachment: wasm-threads.bundle

New patch set with some bug fixes and better test cases; new builds:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cdca47678e191aaf81d8be5252c26b6ffbc49c1d

Comment 6

[Lars T Hansen [:lth]]

Attachment: wasm-threads.bundle

New queue, with fixes after reviews and rebasing.

Artifacts here (even though the patch set does not look clean in this try build it is the same):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a97f120a4a037a9954b3ce6be3c9013bd4040cf7

Comment 7

[Lars T Hansen [:lth]]

(metabug, no owner)

Comment 8

[EventHorizon]

This news item may be of interest ... it references this issue

WebAssembly Threads ready to try in Chrome 70 (developers.google.com)

https://news.ycombinator.com/item?id=18332991

Comment 9

[Clemens Eisserer]

Please implement it - it is the one last major item which keeps webassembly from beeing really useful.

Comment 10

[William Furr]

Should this be marked as blocked by https://bugzilla.mozilla.org/show_bug.cgi?id=1477743 ?

Comment 11

[Clemens Eisserer]

please prioritize - Google shipped this enabled by default with Chrome 74 - release on 2019-04-23.
So exactly 3 months to go until Firefox lacks Chrome by a whole year when it comes to webassembly threads.

Comment 12

[Lars T Hansen [:lth]]

We're done here - the two remaining blockers aren't really blocking anything. \o/

Comment 13

[Chris Mills [:cmills]]

I've completed the documentation on MDN about this; see https://github.com/mdn/sprints/issues/3428#issuecomment-655053796 for details.

Let me know if you think this needs anything else; thanks!