1398067 - Fully support context menu and "tab" related functionality in GeckoView-based custom tabs/web apps

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P2)

Description

[Jan Henning [:JanH]]

Bug 1365868 has gained a patch for a basic context menu, but there's more work to be done.

+++ This bug was initially created as a clone of Bug #1365868 +++

Things that work at the moment and won't work automatically after switching to GeckoView:
- context menus
- context menu entries added by add-ons
- "Open Link in New (Private) Tab" opens a new tab in Firefox and shows the usual snackbar - pressing the "Switch" button on that then switches to our normal BrowserApp-based UI to show that tab (I guess bug 1365868 won't support opening the tab in background without switching to Firefox?)
- "Parent tab" functionality: Pressing the back button on a normal tab that was opened from a custom tab/web app closes that tab again and returns to the original custom tab/web app activity. (This might already work with the patches for bug 1365868 if the new tab is treated as an externally opened tab?)

Comment 2

[Wesly Huang (EPM)]

[triage0913] + as P1 as we still expect a better implementation of it.

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Hi Snorp 
I need to support PWA onboarding(bug 1393672). I'll pause the work on this.

Comment 4

[Wesly Huang (EPM)]

James, do you think this is something your team can help on? Thanks.

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

We won't have time, but I think Nevin added a minimal impl in bug 1409296

Comment 6

[Nevin Chen(Not active on Bugzilla)]

After bug 1411529, previous "minimal context menu" worked. This bug should only

Comment 7

[Nevin Chen(Not active on Bugzilla)]

After bug 1411529 landed, previous "minimal context menu" worked. This bug should only focus on "full" support of the feature.

Comment 10

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.