1400533 - Mac builds broken on C-C (gfxCoreTextShaper.cpp:34:26: error: use of undeclared identifier 'kCTWritingDirectionOverride'): Switch Mac builds to 10.11 SDK

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1324892 +++

Landed so far

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b0d8d878f627
Keep build files in sync (Port bug 1324892: Update Mac builds to use the OS X 10.11 SDK). rs=bustage-fix DONTBUILD

as a port of
https://hg.mozilla.org/mozilla-central/rev/643c70cb9158

But it looks like this was not enough, since we can't build due to compile errors:

Bug 1398133 comment #4 and bug 1398582 comment #21, although the latter got backed out.

Comment 1

[Jorg K (CEST = GMT+2)]

Since bug 1398582 got backed out (https://hg.mozilla.org/mozilla-central/rev/0f15faa4f0fa), we're back to the problem from bug 1398133 comment #4:

/builds/slave/tb-c-cen-m64-00000000000000000/build/mozilla/gfx/thebes/gfxCoreTextShaper.cpp:34:26: error: use of undeclared identifier 'kCTWritingDirectionOverride'; did you mean 'kCTWritingDirectionNatural'? [log…]
/builds/slave/tb-c-cen-m64-00000000000000000/build/mozilla/gfx/thebes/gfxCoreTextShaper.cpp:45:49: error: use of undeclared identifier 'kCTWritingDirectionAttributeName' [log…]
/builds/slave/tb-c-cen-m64-00000000000000000/build/mozilla/gfx/thebes/gfxCoreTextShaper.cpp:49:45: error: no matching function for call to 'ArrayLength' [log…]

Comment 2

[Jorg K (CEST = GMT+2)]

See bug 1379062 for SM going to cross compiles.

Comment 3

[Wayne Mery (:wsmwk)]

ouch!

Comment 4

[Jorg K (CEST = GMT+2)]

The compile error in comment #1 is currently overshadowed by bug 1401487.

Comment 5

[Jorg K (CEST = GMT+2)]

I've addressed bug 1401487, so we're back to the error from comment #1.

Comment 6

[Tom Prince [:tomprince]]

Attachment: Bug 1400533: Pickup $TOOLTOOL_DIR to figure out where compilers are.

Review commit: https://reviewboard.mozilla.org/r/184156/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184156/

Comment 7

[Tom Prince [:tomprince]]

Attachment: Bug 1400533: Install OSX SDK.

Review commit: https://reviewboard.mozilla.org/r/184158/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184158/

Comment 8

[Tom Prince [:tomprince]]

Attachment: Bug 1400533: Add sync exceptions.

Review commit: https://reviewboard.mozilla.org/r/184160/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184160/

Comment 9

[Tom Prince [:tomprince]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e661f4fc3eb3e5b3a708d4ada2058910cd2328c8

Comment 10

[Tom Prince [:tomprince]]

Attachment: Bug 1400533: Disable xcode installation checking when using tooltool provided OSX SDK.

Review commit: https://reviewboard.mozilla.org/r/184210/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184210/

Comment 11

[Tom Prince [:tomprince]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=ac6fe5715f8661423c7b0afffa15b3e7afa6acd8

Comment 12

[Tom Prince [:tomprince]]

Comment on attachment 8912834 [details]
Bug 1400533: Pickup $TOOLTOOL_DIR to figure out where compilers are.

https://reviewboard.mozilla.org/r/184154/#review190652

I'm going to land this, to get OSX builds working, but would still appreciate a post-commit review.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/67bd36f127c9
Pickup $TOOLTOOL_DIR to figure out where compilers are; r=me
https://hg.mozilla.org/comm-central/rev/210e3bfaccd6
Install OSX SDK; r=me
https://hg.mozilla.org/comm-central/rev/ddc0d42d08e6
Add sync exceptions; r=me
https://hg.mozilla.org/comm-central/rev/706e5fdd3012
Disable xcode installation checking when using tooltool provided OSX SDK; r=me

Comment 14

[Jorg K (CEST = GMT+2)]

Nice, but tests don't seem to start.

Comment 15

[Tom Prince [:tomprince]]

Mozilla has migrated most of the workers to running taskcluster, and there are only a few left allocated to buildbot. It looks like that push just ran into a mozilla-esr52 push which is monopolizing all the OSX testers. At this moment, there are about 37 builds pending, 4 of which are from the TB push, and 9 workers. Once the esr52 builds are done, it'll pick up these tests.

Comment 16

[Jorg K (CEST = GMT+2)]

Thanks for the explanation.

gfxCoreTextShaper.cpp:34:26: error: use of undeclared identifier 'kCTWritingDirectionOverride'
strangely seems to be popping up intermittently, maybe there is an issue with individual machines picking up the compile job.

Comment 17

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 8912834 [details]
Bug 1400533: Pickup $TOOLTOOL_DIR to figure out where compilers are.

https://reviewboard.mozilla.org/r/184156/#review190996

r+wc

::: build/macosx/local-mozconfig.common:20
(Diff revision 1)
> -    export AR=$topsrcdir/cctools/bin/ar
> -    export RANLIB=$topsrcdir/cctools/bin/ranlib
>  elif [ -d "$topsrcdir/../clang" ]; then
> -    # comm-central based build
> -    export CC=$topsrcdir/../clang/bin/clang
> -    export CXX=$topsrcdir/../clang/bin/clang++
> +    TOOLTOOL_DIR=$topsrcdir/..
> +else
> +    echo "Don't know where we are; can't find clang. topsrcdir: $topsrcdir"

Would it make sense to keep the else case, for debugging?

Comment 18

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 8912835 [details]
Bug 1400533: Install OSX SDK.

https://reviewboard.mozilla.org/r/184158/#review190998

r+wc

::: build/macosx/local-mozconfig.common:23
(Diff revision 1)
>      TOOLTOOL_DIR=$topsrcdir/..
>  else
>      echo "Don't know where we are; can't find clang. topsrcdir: $topsrcdir"
>  fi
>  
> +if [ -d $TOOLTOOL_DIR/MacOSX10.10.sdk ]; then

Is this only an issue with the 10.10 SDK, or are other versions also affected? If the latter, then it might make sense to generalize this.

Comment 19

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 8912836 [details]
Bug 1400533: Add sync exceptions.

https://reviewboard.mozilla.org/r/184160/#review191000

Comment 20

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 8912891 [details]
Bug 1400533: Disable xcode installation checking when using tooltool provided OSX SDK.

https://reviewboard.mozilla.org/r/184210/#review191002

Comment 21

[Tom Prince [:tomprince]]

(In reply to Jorg K (GMT+2) from comment #16)
> Thanks for the explanation.
> 
> gfxCoreTextShaper.cpp:34:26: error: use of undeclared identifier
> 'kCTWritingDirectionOverride'
> strangely seems to be popping up intermittently, maybe there is an issue
> with individual machines picking up the compile job.

It looks like some builds were picking up cached autoconf settings that didn't include the new SDK. I've clobbered all the OSX comm-central/try-comm-central builders, so hopefully the issue will disappear.

Comment 22

[Tom Prince [:tomprince]]

Comment on attachment 8912835 [details]
Bug 1400533: Install OSX SDK.

https://reviewboard.mozilla.org/r/184158/#review191080

::: build/macosx/local-mozconfig.common:23
(Diff revision 1)
>      TOOLTOOL_DIR=$topsrcdir/..
>  else
>      echo "Don't know where we are; can't find clang. topsrcdir: $topsrcdir"
>  fi
>  
> +if [ -d $TOOLTOOL_DIR/MacOSX10.10.sdk ]; then

It isn't that there is an issue with the 10.10 SDK, it is that we need a newer SDK than is globally installed, so we install a newer SDK with tooltool (see bellow).

Comment 23

[Tom Prince [:tomprince]]

Comment on attachment 8912835 [details]
Bug 1400533: Install OSX SDK.

https://reviewboard.mozilla.org/r/184158/#review190998

> Is this only an issue with the 10.10 SDK, or are other versions also affected? If the latter, then it might make sense to generalize this.

There isn't an issue with the 10.10 SDK. The issue is that the globally available SDK is too old to compile Thunderbird with, so we install a newer (i.e. 10.10) SDK with tooltool (see below). The directory being checked here needs to match the SDK being installed with tooltool below.

Comment 24

[Tom Prince [:tomprince]]

Comment on attachment 8912834 [details]
Bug 1400533: Pickup $TOOLTOOL_DIR to figure out where compilers are.

https://reviewboard.mozilla.org/r/184156/#review190996

> Would it make sense to keep the else case, for debugging?

I'm not sure I understand this comment. The patch is *adding* the else case.

Comment 25

[Jorg K (CEST = GMT+2)]

Tom, uplift the changesets in comment #13 to beta?

Comment 26

[Tom Prince [:tomprince]]

Jorg, everything but 706e5fdd3012 (which is dealing with a patch to M-C that isn't in beta).

Comment 27

[Jorg K (CEST = GMT+2)]

Comment on attachment 8912834 [details]
Bug 1400533: Pickup $TOOLTOOL_DIR to figure out where compilers are.

This patch and the following two, not "Disable xcode installation checking" as per comment #26.

Comment 28

[Jorg K (CEST = GMT+2)]

Beta (TB 57):
https://hg.mozilla.org/releases/comm-beta/rev/0d6e99cb215ea9b7b52db06ee09b02f50a7b9cad
https://hg.mozilla.org/releases/comm-beta/rev/7cbe450c455f464c66e1fd31d07f80a0ae7a0eba
https://hg.mozilla.org/releases/comm-beta/rev/20667d0ac282a3199729d996dacfa7e483e42ca6

Comment 29

[Axel Hecht [:Pike]]

Tom, can it be that --disable-xcode-checks is incompatible with --disable-compile-environment?

https://archive.mozilla.org/pub/thunderbird/nightly/2017/12/2017-12-03-03-02-05-comm-central-l10n/comm-central-macosx64-l10n-nightly-de-bm82-build1-build3552.txt.gz looks like that's a general bustage of mac l10n builds.