Closed Bug 1402392 Opened 3 years ago Closed 3 years ago

Autophone - Prevent Firefox opening privacy notification tab during tests

Categories

(Testing :: Autophone, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bc, Unassigned)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1402388 +++

While checking the running tests on AWFY, I noticed that Firefox had opened the privacy notification page in a background tab. I'm pretty sure we don't want that though I doubt it has much impact overall.

Bug Archaeology shows:

Bug 1400675 - Fix reference to undefined property FirsRunURL

Bug 1382196 - Use the prefs defined in TelemetryUtils.jsm in TelemetryReportingPolicy.jsm

Bug 1367076 - Set datareporting.policy.firstRunURL by default to replace data choices infobar with privacy policy in a background tab on first run.

The combination of these patches has resulted in Firefox opening the privacy tab on first run.

We should set:

user_pref("datareporting.policy.firstRunURL", "");

and reading the patches, probably need to set:

// Skip data reporting policy notifications.
user_pref("datareporting.policy.dataSubmissionPolicyBypassNotification", true);

We should probably do the same for Autophone. Thoughts?
Flags: needinfo?(snorp)
Flags: needinfo?(gbrown)
bbouvier pointed me to http://searchfox.org/mozilla-central/source/toolkit/components/telemetry/docs/internals/preferences.rst#84

I think these are sufficient, though perhaps not all necessary.

"datareporting.policy.firstRunURL", ""
"datareporting.policy.dataSubmissionPolicyBypassNotification", true
"datareporting.policy.dataSubmissionEnabled", false
Attachment #8911303 - Flags: review?(gbrown)
Attachment #8911303 - Flags: review?(gbrown) → review+
Flags: needinfo?(gbrown)
https://github.com/mozilla/autophone/commit/3b3091aa5f4ebfbb3874281dbb3c2b45ec0c053b
deployed
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
I broke autophone with the previous push. This fixes it.
https://github.com/mozilla/autophone/commit/ebecb7fe205544390b2a7bdba232a860ebefe6bf

I'd hoped for a more significant commit for #700. :-( Sorry.
Looks like no info needed from me now?
Flags: needinfo?(snorp)
You need to log in before you can comment on or make changes to this bug.