1402392 - Autophone - Prevent Firefox opening privacy notification tab during tests

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, enhancement)

Description

[Bob Clary [:bc] (inactive)]

+++ This bug was initially created as a clone of Bug #1402388 +++

While checking the running tests on AWFY, I noticed that Firefox had opened the privacy notification page in a background tab. I'm pretty sure we don't want that though I doubt it has much impact overall.

Bug Archaeology shows:

Bug 1400675 - Fix reference to undefined property FirsRunURL

Bug 1382196 - Use the prefs defined in TelemetryUtils.jsm in TelemetryReportingPolicy.jsm

Bug 1367076 - Set datareporting.policy.firstRunURL by default to replace data choices infobar with privacy policy in a background tab on first run.

The combination of these patches has resulted in Firefox opening the privacy tab on first run.

We should set:

user_pref("datareporting.policy.firstRunURL", "");

and reading the patches, probably need to set:

// Skip data reporting policy notifications.
user_pref("datareporting.policy.dataSubmissionPolicyBypassNotification", true);

We should probably do the same for Autophone. Thoughts?

Comment 1

[Bob Clary [:bc] (inactive)]

bbouvier pointed me to http://searchfox.org/mozilla-central/source/toolkit/components/telemetry/docs/internals/preferences.rst#84

I think these are sufficient, though perhaps not all necessary.

"datareporting.policy.firstRunURL", ""
"datareporting.policy.dataSubmissionPolicyBypassNotification", true
"datareporting.policy.dataSubmissionEnabled", false

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: bug-1402392-v1.patch

Comment 3

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/3b3091aa5f4ebfbb3874281dbb3c2b45ec0c053b
deployed

Comment 4

[Bob Clary [:bc] (inactive)]

I broke autophone with the previous push. This fixes it.
https://github.com/mozilla/autophone/commit/ebecb7fe205544390b2a7bdba232a860ebefe6bf

I'd hoped for a more significant commit for #700. :-( Sorry.

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Looks like no info needed from me now?