1407618 - Crash in @0x0 | mozilla::wr::RenderDXGITextureHostOGL::EnsureLockable

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-7b8a423f-2edb-4da6-8437-841690171011.
=============================================================

Seen while looking at nightly data. Crashes started on 20171005100211: http://bit.ly/2g0GVfv

29 crashes/5 installs so far.

Comment 1

[Calixte Denizet (:calixte)]

There are 69 in nightly 58 vs 8 crashes in nightly 57.
:nical, could you investigate please ?

Comment 2

[Michael Leu[:Lenzak](UTC+8)]

I suspect it is actually the same issue as Bug 1407748.

Comment 3

[Nicolas Silva [:nical]]

Jerry, you have looked more closely into DXGI textures with webrender, can you have a look?

Comment 4

[Jerry Shih[:jerry] (UTC+8) (inactive)]

(In reply to Michael Leu[:Lenzak](UTC+8) from comment #2)
> I suspect it is actually the same issue as Bug 1407748.

I also suspect it's the same problem as Bug 1407748. Let's see if there is no more crash after 10/14.

Comment 5

[Marcia Knous [:marcia]]

I see a few crashes using 20171015100127.

Comment 6

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: We still have the assertion in EnsureLockable after bug 1407748.

https://crash-stats.mozilla.com/signature/?signature=%400x0%20%7C%20mozilla%3A%3Awr%3A%3ARenderDXGITextureHostOGL%3A%3AEnsureLockable&date=%3E%3D2017-10-03T10%3A11%3A49.000Z&date=%3C2017-10-17T10%3A11%3A49.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1#reports

This patch try to add more gl texture creation checking in RenderDXGITexture.
1. dxgi shared texture handle.
2. ANGLE_d3d_share_handle_client_buffer ext.

Comment 7

[Sotaro Ikeda [:sotaro]]

FYI, Bug 1404232 also has a fix attachment 8919215 [details] [diff] [review] that is related to EnsureLockable.

Comment 8

[Jerry Shih[:jerry] (UTC+8) (inactive)]

(In reply to Sotaro Ikeda [:sotaro] from comment #7)
> FYI, Bug 1404232 also has a fix attachment 8919215 [details] [diff] [review]
> that is related to EnsureLockable.

Thanks. It will have a problem if we pass a different context from the previous gl context.

Comment 9

[Jerry Shih[:jerry] (UTC+8) (inactive)]

try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=643e76b467963db289e030e43d1fe4d9ee9a88b1

Comment 10

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Please land the attachment 8919226 [details] [diff] [review] to m-c.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4af4f28dc9d0
add more gl texture creation checking for RenderDXGITexture. r=jgilbert

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4af4f28dc9d0

Comment 13

[Calixte Denizet (:calixte)]

No more crash after buildid 20171020221129.