Closed Bug 1408080 Opened 8 years ago Closed 8 years ago

October 2017 batch of root CA changes

Categories

(NSS :: CA Certificates Code, task)

Product:
NSS
Component:
CA Certificates Code
Version:
3.34
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: KaiE, Assigned: KaiE)

References

Details

Attachments

(2 files)

1408080-v1.patch
168.50 KB, patch
kathleen.a.wilson
: review+
KaiE
: checked-in+
Details | Diff | Splinter Review
1408080-part2.patch
33.86 KB, patch
kathleen.a.wilson
: review+
KaiE
: checked-in+
Details | Diff | Splinter Review
October 2017 batch of root CA changes
Assignee: nobody → kaie
Blocks: 1367265, 1387260, 1392849, 1392853, 1385063, 1395726, 1400013, 1400021, 1400030, 1403549
Attached patch 1408080-v1.patch — — Splinter Review
Test build with the attached patch v1: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cddbbca4c9ec9c9c4b112043d082d374a6bb75ac After the builds are complete, in order to find the binary, for example, for Mac OSX: Find the line with OSX that contains tc(B). Click the green B inside that tc(B), and the bottom part of the page will change to show more details of that build. In the right hand colum, you see several "artifact uploaded" entries. Scroll down that list to find "target.dmg". That's the Mac disk image that you're looking for.
Comment on attachment 8917993 [details] [diff] [review] 1408080-v1.patch Please test the build and review this patch, thanks.
Attachment #8917993 - Flags: review?(kwilson)
I have verified that the changes are as expected. I have tested with the Mac OSX test build and confirm the correct removals and additions. Testing succeeded for the addition of GDCA TrustAUTH R5 ROOT, TrustCor RootCert CA-1, TrustCor RootCert CA-2. Testing failed for the addition of TrustCor ECA-1 -- probably something wrong with the test site. I will ask the CAs to test now. Thanks!
(In reply to Kathleen Wilson from comment #4) > Testing failed for the addition of TrustCor ECA-1 -- probably something > wrong with the test site. I had the wrong test website URL. The correct one is: https://valid.epki.external.trustcor.ca And it works. Waiting for the CAs to do their testing.
CAs have finished testing.
Comment on attachment 8917993 [details] [diff] [review] 1408080-v1.patch I confirm that the changes are as requested, I have tested the changes, and the CAs have verified their root additions. Thanks!
Attachment #8917993 - Flags: review?(kwilson) → review+
Adding bug 1410954.
Blocks: 1410954
Attachment #8917993 - Attachment description: 1395726-v1.patch → 1408080-v1.patch
Attachment #8917993 - Attachment filename: 1395726-v1.patch → 1408080-v1.patch
Incremental patch, part 2, adds roots from bug 1410954
Comment on attachment 8921186 [details] [diff] [review] 1408080-part2.patch Please test the new build and review this patch, thanks.
Attachment #8921186 - Flags: review?(kwilson)
I confirm that the patch is correct, and I have verified the changes in the test build on Mac OS. I will ask the CA to do their testing. Thanks!
Comment on attachment 8921186 [details] [diff] [review] 1408080-part2.patch I confirm that the changes are as requested, I have tested the changes, and the CAs have verified their root additions. Thanks!
Attachment #8921186 - Flags: review?(kwilson) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: