1408080 - October 2017 batch of root CA changes

Status: RESOLVED FIXED

(NSS :: CA Certificates Code, task)

Description

[Kai Engert (:KaiE:)]

October 2017 batch of root CA changes

Comment 1

[Kai Engert (:KaiE:)]

Attachment: 1408080-v1.patch

Comment 2

[Kai Engert (:KaiE:)]

Test build with the attached patch v1:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=cddbbca4c9ec9c9c4b112043d082d374a6bb75ac

After the builds are complete, in order to find the binary, for example, for Mac OSX:

Find the line with OSX that contains tc(B). Click the green B inside that tc(B), and the bottom part of the page will change to show more details of that build.

In the right hand colum, you see several "artifact uploaded" entries.

Scroll down that list to find "target.dmg". That's the Mac disk image that you're looking for.

Comment 3

[Kai Engert (:KaiE:)]

Comment on attachment 8917993 [details] [diff] [review]
1408080-v1.patch

Please test the build and review this patch, thanks.

Comment 4

[Kathleen Wilson]

I have verified that the changes are as expected.

I have tested with the Mac OSX test build and confirm the correct removals and additions.

Testing succeeded for the addition of GDCA TrustAUTH R5 ROOT, TrustCor RootCert CA-1, TrustCor RootCert CA-2.

Testing failed for the addition of TrustCor ECA-1 -- probably something wrong with the test site.

I will ask the CAs to test now.

Thanks!

Comment 5

[Kathleen Wilson]

(In reply to Kathleen Wilson from comment #4)
> Testing failed for the addition of TrustCor ECA-1 -- probably something
> wrong with the test site.

I had the wrong test website URL. The correct one is:
https://valid.epki.external.trustcor.ca

And it works.

Waiting for the CAs to do their testing.

Comment 6

[Kathleen Wilson]

CAs have finished testing.

Comment 7

[Kathleen Wilson]

Comment on attachment 8917993 [details] [diff] [review]
1408080-v1.patch

I confirm that the changes are as requested, I have tested the changes, and the CAs have verified their root additions. 

Thanks!

Comment 8

[Kai Engert (:KaiE:)]

Comment on attachment 8917993 [details] [diff] [review]
1408080-v1.patch

https://hg.mozilla.org/projects/nss/rev/946f134980f3

Comment 9

[Kai Engert (:KaiE:)]

Adding bug 1410954.

Comment 10

[Kai Engert (:KaiE:)]

Attachment: 1408080-part2.patch

Incremental patch, part 2, adds roots from bug 1410954

Comment 11

[Kai Engert (:KaiE:)]

Test build that contains both attached patches:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=28d1a40bfeeeccbe5c8d7ac657d7683ab61055a7

Comment 12

[Kai Engert (:KaiE:)]

Comment on attachment 8921186 [details] [diff] [review]
1408080-part2.patch

Please test the new build and review this patch, thanks.

Comment 13

[Kathleen Wilson]

I confirm that the patch is correct, and I have verified the changes in the test build on Mac OS.

I will ask the CA to do their testing.

Thanks!

Comment 14

[Kathleen Wilson]

Comment on attachment 8921186 [details] [diff] [review]
1408080-part2.patch

I confirm that the changes are as requested, I have tested the changes, and the CAs have verified their root additions. 

Thanks!

Comment 15

[Kai Engert (:KaiE:)]

Comment on attachment 8921186 [details] [diff] [review]
1408080-part2.patch

https://hg.mozilla.org/projects/nss/rev/3dfd171371fa