Closed Bug 1411259 Opened 2 years ago Closed 2 years ago

Reduce mochitest tab process leak threshold to 0 on non-Windows platforms

Categories

(Testing :: Mochitest, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Once bug 1408523 is fixed, we have no Mochitest leaks on non-Windows platforms (the reftest threshold was already reduced to 0 for them) in the tab process. Also, the high water mark on Windows is 544 bytes, so I'll reduce the threshold to 1000 bytes.

As with bug 1409075 it is possible that this will result in more intermittent oranges. The prior bug didn't add any, but now that we're dropping to zero maybe a few tiny ones will show up.
There are actually a few other small leaks remaining (bug 1411416, bug 1411644). If I can't figure those out, I'll bump up the threshold a bit.
Depends on: 1412408, 1411416
This isn't green yet, but it should be once the blocking bugs are fixed. Though I do need to double check that it is green on Windows.
Attachment #8924345 - Flags: review?(erahm)
Comment on attachment 8924345 [details] [diff] [review]
Reduce mochitest tab process leak threshold to 0 on non-Windows platforms.

Review of attachment 8924345 [details] [diff] [review]:
-----------------------------------------------------------------

r+ pending landing of the blocking bugs.
Attachment #8924345 - Flags: review?(erahm) → review+
Keywords: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/92f8f3e2d198
Reduce mochitest tab process leak threshold to 0 on non-Windows platforms. r=erahm
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/92f8f3e2d198
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.