1412517 - Time picker layout broken when opened in landscape mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Jan Henning [:JanH]]

Attachment: Screenshot_20171028-142237.png

See the screenshot - the clock is overhanging the dialogue and partially invisible.

Comment 1

[Nevin Chen(Not active on Bugzilla)]

Thanks! Is there a STR? or it's for every site?

Comment 2

[Bogdan Surd, QA [:bsurd, NI]]

Tried it on 2 separate devices (Galaxy Tab S3 - 7.0, Nexys 6P 7.0) and could not personally reproduce it on those.

I did however notice something similar like the screenshot Jan attached on a HTC Desire 820 - 6.0.1 the clock is truncated but the area is scrollable so you can access the entire area of the clock.

SRT:
 1. Got to: https://goo.gl/nLhZ1k;
 2. Tap on the time picker.

Expected results:
 The clock and time are fully displayed on the site.

Actual results:
 The clock is truncated.

Comment 3

[Jan Henning [:JanH]]

It's any site that triggers our own time picker.

(In reply to Bogdan Surd, QA [:BogdanS, NI] from comment #2)
> I did however notice something similar like the screenshot Jan attached on a
> HTC Desire 820 - 6.0.1 the clock is truncated but the area is scrollable so
> you can access the entire area of the clock.

1. I'm using a Moto G4 Play - 6.0.1 - 720 x 1280 px and I think it counts as xhdpi (320 dpi)
2. I can only scroll vertically (so I can see the clear and cancel buttons), but not horizontally (to access the right side of the clock and the ok button).

Comment 4

[Wesly Huang (EPM)]

Even we may not able to implement a convenient "year" picker soon, this one should get higher priority.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

[triage] Time picker broken on some devices: critical. This may only be small devices but these are sometimes popular in non-US locales.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1412517 - Time picker layout broken when opened in landscape mode;

Review commit: https://reviewboard.mozilla.org/r/252332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252332/

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8987102 [details]
Bug 1412517 - Time picker layout broken when opened in landscape mode;

https://reviewboard.mozilla.org/r/252332/#review258860

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c13bf70a3e1
Time picker layout broken when opened in landscape mode; r=jchen

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5c13bf70a3e1

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Seems like this is worth a Beta approval request.

Comment 11

[Stefan Deiac]

Verified as fixed on latest Niglty 63.0a1 (2018-07-16). 
Device: Nokia 6 (Android 7.1.1), OnePlus 5T (Android 8.0.0) and Huawei P9 Lite (Android 6.0.0)

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Petru, were you going to nominate this for Beta uplift?

Comment 13

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 8987102 [details]
Bug 1412517 - Time picker layout broken when opened in landscape mode;

Approval Request Comment
[Feature/Bug causing the regression]: Time Picker is cut off on smaller screen devices 
[User impact if declined]: Impossibility to properly select the wanted time. Chopped widget.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: --
[List of other uplifts needed for the feature/fix]: 1475251
[Is the change risky?]: No
[Why is the change risky/not risky?]: Has been QE tested; No issues reported in Nightly other than Bug 1475251
[String changes made/needed]: --

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8987102 [details]
Bug 1412517 - Time picker layout broken when opened in landscape mode;

One of several small fixes for the time/date picker in 62 related to bug  	1464997. Verified in nightly. Let's uplift for beta 16/17.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9ad2ab8a19ab

Comment 16

[Ioana Chiorean]

Can you please check this, Igor?

Comment 17

[Bogdan Surd, QA [:bsurd, NI]]

Devices:
 - HTC Desire 820 (Android 6.0.1);
 - Samsung Galaxy Note 8 (Android 8.0.0).

Verified as fixed in 62.0b17