Closed Bug 1412517 Opened 2 years ago Closed Last year

Time picker layout broken when opened in landscape mode

Categories

(Firefox for Android :: General, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 63
Tracking Status
firefox61 --- wontfix
firefox62 --- verified
firefox63 --- verified

People

(Reporter: JanH, Assigned: petru)

References

(Blocks 1 open bug)

Details

(Whiteboard: [priority:medium] )

Attachments

(2 files)

See the screenshot - the clock is overhanging the dialogue and partially invisible.
Thanks! Is there a STR? or it's for every site?
Flags: needinfo?(jh+bugzilla)
Tried it on 2 separate devices (Galaxy Tab S3 - 7.0, Nexys 6P 7.0) and could not personally reproduce it on those.

I did however notice something similar like the screenshot Jan attached on a HTC Desire 820 - 6.0.1 the clock is truncated but the area is scrollable so you can access the entire area of the clock.

SRT:
 1. Got to: https://goo.gl/nLhZ1k;
 2. Tap on the time picker.

Expected results:
 The clock and time are fully displayed on the site.

Actual results:
 The clock is truncated.
tracking-fennec: --- → ?
It's any site that triggers our own time picker.

(In reply to Bogdan Surd, QA [:BogdanS, NI] from comment #2)
> I did however notice something similar like the screenshot Jan attached on a
> HTC Desire 820 - 6.0.1 the clock is truncated but the area is scrollable so
> you can access the entire area of the clock.

1. I'm using a Moto G4 Play - 6.0.1 - 720 x 1280 px and I think it counts as xhdpi (320 dpi)
2. I can only scroll vertically (so I can see the clear and cancel buttons), but not horizontally (to access the right side of the clock and the ok button).
Flags: needinfo?(jh+bugzilla)
Even we may not able to implement a convenient "year" picker soon, this one should get higher priority.
Priority: -- → P2
tracking-fennec: ? → +
[triage] Time picker broken on some devices: critical. This may only be small devices but these are sometimes popular in non-US locales.
Priority: P2 → P1
Summary: Time picker layout broken when opened in portrait mode → Time picker layout broken when opened in landscape mode
See Also: → 1460072
Whiteboard: [priority:medium]
Blocks: 1464997
Assignee: nobody → petru.lingurar
Attachment #8987102 - Flags: review?(sdaswani) → review?(nchen)
Comment on attachment 8987102 [details]
Bug 1412517 - Time picker layout broken when opened in landscape mode;

https://reviewboard.mozilla.org/r/252332/#review258860
Attachment #8987102 - Flags: review?(nchen) → review+
Keywords: checkin-needed
Status: NEW → ASSIGNED
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c13bf70a3e1
Time picker layout broken when opened in landscape mode; r=jchen
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5c13bf70a3e1
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Seems like this is worth a Beta approval request.
Flags: needinfo?(petru.lingurar)
Flags: needinfo?(petru.lingurar) → qe-verify+
Blocks: 1460072
Depends on: 1475251
Verified as fixed on latest Niglty 63.0a1 (2018-07-16). 
Device: Nokia 6 (Android 7.1.1), OnePlus 5T (Android 8.0.0) and Huawei P9 Lite (Android 6.0.0)
tracking-fennec: + → ---
Flags: qe-verify+
Petru, were you going to nominate this for Beta uplift?
Flags: needinfo?(petru.lingurar)
Comment on attachment 8987102 [details]
Bug 1412517 - Time picker layout broken when opened in landscape mode;

Approval Request Comment
[Feature/Bug causing the regression]: Time Picker is cut off on smaller screen devices 
[User impact if declined]: Impossibility to properly select the wanted time. Chopped widget.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: --
[List of other uplifts needed for the feature/fix]: 1475251
[Is the change risky?]: No
[Why is the change risky/not risky?]: Has been QE tested; No issues reported in Nightly other than Bug 1475251
[String changes made/needed]: --
Flags: needinfo?(petru.lingurar)
Attachment #8987102 - Flags: approval-mozilla-beta?
Comment on attachment 8987102 [details]
Bug 1412517 - Time picker layout broken when opened in landscape mode;

One of several small fixes for the time/date picker in 62 related to bug  	1464997. Verified in nightly. Let's uplift for beta 16/17.
Attachment #8987102 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
Can you please check this, Igor?
Flags: needinfo?(igor.lazar)
Devices:
 - HTC Desire 820 (Android 6.0.1);
 - Samsung Galaxy Note 8 (Android 8.0.0).

Verified as fixed in 62.0b17
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: needinfo?(igor.lazar)
You need to log in before you can comment on or make changes to this bug.