1418212 - Opening the profiler with WR enabled causes WR to get disabled unless extensions.webextensions.remote is true

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebRender, defect, P5)

Description

[Emilio Cobos Álvarez (:emilio)]

I experience this consistently when I try to take a WR profile, so I need to enable that other pref.

That other pref has its own set of problems though, including various errors from WR spawned in stderr.

Anyway.

STR:

 * Enable webrender.
 * Install the Gecko profiler.
 * Press the profiler wheel to start / stop profiling.
 * As soon as the popup opens, current tab goes blank and WR gets disabled.
 * On stderr:

[GFX1-]: Failed GL context creation for WebRender: 0
[GFX1-]: Compositors might be mixed (5,2)

Expected results:

 * I'm able to profile with WR enabled and no random webextension prefs.

FWIW, also happens with the hamburger menu, though I haven't checked if the pref fixes that, will check that now.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

> FWIW, also happens with the hamburger menu, though I haven't checked if the
> pref fixes that, will check that now.

The hamburger menu isn't fixed by that...

FWIW, the problems with the pref that I was talking about was extra black padding around the profiler popup, and errors like:

  ERROR:webrender::frame: ERROR: Invalid window dimensions! Please call api.set_window_size()

On stderr.

Comment 2

[Sotaro Ikeda [:sotaro]]

:emilio, in which OS did you experience it?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Linux, WebRender - OpenGL version new 4.5 (Core Profile) Mesa 17.4.0-devel

Comment 4

[Darkspirit]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #3)
> Linux, WebRender - OpenGL version new 4.5 (Core Profile) Mesa 17.4.0-devel

Are you using the GPU process (bug 1406230 comment 3)?

Comment 5

[Emilio Cobos Álvarez (:emilio)]

So I tracked this down to us wanting to create a window with windowAttrs.depth == 32, but ChooseFBConfigs only returning depths == 24.

I don't know where does the window come from and if we can control the requested depth, that's the next task I guess :)

Meanwhile I found some cleanup to do, will do that in bug 1420170.

Comment 6

[Darkspirit]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #0)
> [GFX1-]: Failed GL context creation for WebRender: 0
> [GFX1-]: Compositors might be mixed (5,2)

bug 1401455 has the same error message. (Proprietary Nvidia driver: Buggy background until you click on the burger button and get a fallback to OpenGL(?) compositing.)

---

(Sotaro Ikeda [:sotaro] from bug 1419023 comment 3)
> I suspect that Bug 1418212 is caused by GLX and widget related problem.

Comment 7

[Darkspirit]

The first two error messages are the same you are getting.

GPU Process(!) + OOP Webextensions prevent WebRender from functioning at all (on Linux).
bug 1406230 [@ gfxPlatform::Init | mozilla::widget::WindowSurfaceX11::GetVisualFormat ]
> Error	Compositors might be mixed (5,2)
> GP+[GFX1-]: Failed GL context creation for WebRender: 0
> GP+[GFX1-]: [OPENGL] Failed to init compositor with reason: FEATURE_FAILURE_OPENGL_CREATE_CONTEXT
> GP+[GFX1-]: [OPENGL] Failed to init compositor with reason: FEATURE_FAILURE_OPENGL_CREATE_CONTEXT

Comment 8

[Emilio Cobos Álvarez (:emilio)]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #7)
> The first two error messages are the same you are getting.
> 
> GPU Process(!) + OOP Webextensions prevent WebRender from functioning at all
> (on Linux).
> bug 1406230 [@ gfxPlatform::Init |
> mozilla::widget::WindowSurfaceX11::GetVisualFormat ]
> > Error	Compositors might be mixed (5,2)
> > GP+[GFX1-]: Failed GL context creation for WebRender: 0
> > GP+[GFX1-]: [OPENGL] Failed to init compositor with reason: FEATURE_FAILURE_OPENGL_CREATE_CONTEXT
> > GP+[GFX1-]: [OPENGL] Failed to init compositor with reason: FEATURE_FAILURE_OPENGL_CREATE_CONTEXT

Yeah, I investigated this a bit today. It seems that the window is requesting a 32-bit depth buffer, and mesa cannot find a suitable FBConfig, failing to create the GLContext.

As a note to self, Markus pointed out that these nsWindows are created from nsMenuPopupFrame, and that the options that probably make this happen are the transparency mode or `aInitData->mSupportsTransparency` in https://searchfox.org/mozilla-central/rev/477ac066b565ae0eb3519875581a62dfb1430e98/widget/gtk/nsWindow.cpp#3661

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Hack that "fixes" the issue.

This happens to fix the issue, and nothing looks broken because, I guess, the hamburger menu and such don't use transparency at all...

I wonder which widgets do use it... If none, the easiest fix is just removing that functionality I guess...

Otherwise, I guess we need to figure out why mesa doesn't return any suitable configuration for that (maybe it just doesn't exist with my gpu).

Comment 10

[Markus Stange [:mstange]]

I would like to understand why this breaks with WebRender on + force acceleration but not with Webrender off + force acceleration. Or does it?
With WebRender off + force acceleration, do we create a BasicCompositor or a CompositorOGL for these panels?

Comment 11

[Emilio Cobos Álvarez (:emilio)]

(In reply to Markus Stange [:mstange] from comment #10)
> I would like to understand why this breaks with WebRender on + force
> acceleration but not with Webrender off + force acceleration. Or does it?
> With WebRender off + force acceleration, do we create a BasicCompositor or a
> CompositorOGL for these panels?

It creates a CompositorOGL, we take this path[1] instead of the one above it because we're not using WR.

[1]: https://searchfox.org/mozilla-central/rev/f5f1c3f294f89cfd242c3af9eb2c40d19d5e04e7/gfx/gl/GLContextProviderGLX.cpp#947

Comment 12

[Emilio Cobos Álvarez (:emilio)]

I cannot repro this anymore.

Comment 13

[Mayank Bansal]

can this be resolved fixed by bug 1357487 ?

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Presumably even sooner given comment 12.