Closed Bug 1428465 Opened 2 years ago Closed 2 years ago

TV skipped a browser chrome test that requires e10s

Categories

(Testing :: General, defect)

defect
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jryans, Assigned: gbrown)

References

Details

Attachments

(1 file)

In try run:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e296d5a1caeb8c132bb4eff4bc435931c247f40b

TV should have included the test `devtools/client/responsive.html/test/browser/browser_device_change.js`, but fails to run it.  The issue appears to be that this test directory has `skip-if = !e10s`, and the mozinfo used by test-verify does not indicate e10s status at all:

{u'allow_legacy_extensions': True, u'pgo': False, u'sync': True, u'buildapp': u'browser', u'crashreporter': True, u'addon_signing': True, u'devedition': False, u'require_signing': False, u'platform_guess': u'linux64', u'appname': u'firefox', u'stylo': True, u'mozconfig': u'/builds/worker/workspace/build/src/.mozconfig', u'topsrcdir': u'/builds/worker/workspace/build/src', u'telemetry': False, 'version': 'Ubuntu 16.04', u'datareporting': True, u'buildtype_guess': u'opt', 'bits': 64, u'bin_suffix': u'', u'artifact': True, u'toolkit': u'gtk3', u'healthreport': True, u'updater': True, u'asan': False, u'release_or_beta': False, u'ccov': False, u'ubsan': False, u'tests_enabled': True, u'official': True, u'tsan': False, u'nightly_build': True, u'debug': False, 'os': u'linux', 'processor': u'x86_64'}
I initially thought this might be a dup of bug 1428137 / bug 1428461, but it is not -- this is a separate issue.
Assignee: nobody → gbrown
Mochitest' runtests.py updates mozinfo with some dynamic info like e10s, headless, and coverage:

https://dxr.mozilla.org/mozilla-central/rev/81362f7306fe413b19fdba27cd0e9a5525d902e1/testing/mochitest/runtests.py#2533-2539

runtests.py also updates mozinfo for stylo and "extra" mozinfo parameters:

https://dxr.mozilla.org/mozilla-central/rev/81362f7306fe413b19fdba27cd0e9a5525d902e1/testing/mochitest/runtests.py#1411-1416


None of this info is available to test-verify support in mozharness.
--extra-mozinfo-json is unused (not specified or used except in the obscure mach chunk finder command).
mozharness config (desktop_unittest) has items 'e10s', 'headless', 'enable_stylo' and 'disable_stylo'.

I'm not too concerned about 'coverage' because we don't run TV on coverage builds.
Blocks: 1406407
The e10s part of this issue was addressed in bug 1413005: https://hg.mozilla.org/mozilla-central/rev/0382668563a5.

That was accidentally clobbered by bug 1411660: https://hg.mozilla.org/mozilla-central/rev/5b960167158f.

*sigh*
Comment on attachment 8940584 [details] [diff] [review]
try to determine e10s, headless and stylo settings for mozinfo

Review of attachment 8940584 [details] [diff] [review]:
-----------------------------------------------------------------

nice
Attachment #8940584 - Flags: review?(jmaher) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/90da22b0bf05
Improve test-verify mozinfo for dynamic parameters like e10s; r=jmaher
https://hg.mozilla.org/mozilla-central/rev/90da22b0bf05
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Duplicate of this bug: 1428900
You need to log in before you can comment on or make changes to this bug.