1428465 - TV skipped a browser chrome test that requires e10s

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

In try run:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e296d5a1caeb8c132bb4eff4bc435931c247f40b

TV should have included the test `devtools/client/responsive.html/test/browser/browser_device_change.js`, but fails to run it.  The issue appears to be that this test directory has `skip-if = !e10s`, and the mozinfo used by test-verify does not indicate e10s status at all:

{u'allow_legacy_extensions': True, u'pgo': False, u'sync': True, u'buildapp': u'browser', u'crashreporter': True, u'addon_signing': True, u'devedition': False, u'require_signing': False, u'platform_guess': u'linux64', u'appname': u'firefox', u'stylo': True, u'mozconfig': u'/builds/worker/workspace/build/src/.mozconfig', u'topsrcdir': u'/builds/worker/workspace/build/src', u'telemetry': False, 'version': 'Ubuntu 16.04', u'datareporting': True, u'buildtype_guess': u'opt', 'bits': 64, u'bin_suffix': u'', u'artifact': True, u'toolkit': u'gtk3', u'healthreport': True, u'updater': True, u'asan': False, u'release_or_beta': False, u'ccov': False, u'ubsan': False, u'tests_enabled': True, u'official': True, u'tsan': False, u'nightly_build': True, u'debug': False, 'os': u'linux', 'processor': u'x86_64'}

Comment 1

[Geoff Brown [:gbrown]]

I initially thought this might be a dup of bug 1428137 / bug 1428461, but it is not -- this is a separate issue.

Comment 2

[Geoff Brown [:gbrown]]

Mochitest' runtests.py updates mozinfo with some dynamic info like e10s, headless, and coverage:

https://dxr.mozilla.org/mozilla-central/rev/81362f7306fe413b19fdba27cd0e9a5525d902e1/testing/mochitest/runtests.py#2533-2539

runtests.py also updates mozinfo for stylo and "extra" mozinfo parameters:

https://dxr.mozilla.org/mozilla-central/rev/81362f7306fe413b19fdba27cd0e9a5525d902e1/testing/mochitest/runtests.py#1411-1416


None of this info is available to test-verify support in mozharness.

Comment 3

[Geoff Brown [:gbrown]]

--extra-mozinfo-json is unused (not specified or used except in the obscure mach chunk finder command).

Comment 4

[Geoff Brown [:gbrown]]

mozharness config (desktop_unittest) has items 'e10s', 'headless', 'enable_stylo' and 'disable_stylo'.

I'm not too concerned about 'coverage' because we don't run TV on coverage builds.

Comment 5

[Geoff Brown [:gbrown]]

The e10s part of this issue was addressed in bug 1413005: https://hg.mozilla.org/mozilla-central/rev/0382668563a5.

That was accidentally clobbered by bug 1411660: https://hg.mozilla.org/mozilla-central/rev/5b960167158f.

*sigh*

Comment 6

[Geoff Brown [:gbrown]]

Attachment: try to determine e10s, headless and stylo settings for mozinfo

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1608fc961e9e496eb96417c16386a75da6128d4a

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8940584 [details] [diff] [review]
try to determine e10s, headless and stylo settings for mozinfo

Review of attachment 8940584 [details] [diff] [review]:
-----------------------------------------------------------------

nice

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/90da22b0bf05
Improve test-verify mozinfo for dynamic parameters like e10s; r=jmaher

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/90da22b0bf05

Comment 11

[Intermittent Failures Robot]

1 failures in 788 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 1

Platform breakdown:
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1428465&startday=2018-01-08&endday=2018-01-14&tree=all