1428570 - Awesomebar text highlight extends to 100% of width instead of length of text

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Asif Youssuff]

Attachment: bad.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180106100308

Steps to reproduce:

1. Enable WebRender
2. Ensure that UI density is set to compact
3. Navigate to https://bugzilla.mozilla.org/show_bug.cgi?id=1421696 (other pages work, but not *all* other pages. This page works reliably)
4. Perform Ctrl+l shortcut to highlight awesomebar content


Actual results:

The awesomebar text selection highlight extends to the entire width of the awesomebar. 


Expected results:

Previously, text highlight extended to the width of the URL/selected text. 

See screenshots of good and bad results.

Comment 1

[Asif Youssuff]

Attachment: good.png

Comment 2

[Asif Youssuff]

11:56.07 INFO: Narrowed inbound regression window from [0e6a5c7f, 9f8cde87] (4 builds) to [3abc6abd, 9f8cde87] (2 builds) (~1 steps left)
11:56.07 INFO: No more inbound revisions, bisection finished.
11:56.07 INFO: Last good revision: 3abc6abd34bf81eb3bd29f21630cbefa2f43947b
11:56.07 INFO: First bad revision: 9f8cde87eaa7a7b164c999a369b4835c7ec68e62
11:56.07 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3abc6abd34bf81eb3bd29f21630cbefa2f43947b&tochange=9f8cde87eaa7a7b164c999a369b4835c7ec68e62

Comment 3

[Kartikaya Gupta (email:[e-mail])]

I can't repro this on OS X nightly.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

I tried the STR on Linux also and still couldn't reproduce. Is this issue dependent on the width of the browser window? It seems odd that it would happen only with some URLs and not others.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

> 11:56.07 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/
> pushloghtml?fromchange=3abc6abd34bf81eb3bd29f21630cbefa2f43947b&tochange=9f8c
> de87eaa7a7b164c999a369b4835c7ec68e62

FWIW these are the WR changes in that push:

*   b7714b1d Auto merge of #2165 - lsalzman:fix-bitmap-offset, r=glennw
|\
| * c8f460fd don't redundantly offset bitmap glyph origins in FreeType font backend
* |   439dfeff Auto merge of #2158 - demo99:ellipse2, r=glennw
|\ \
| * | dcad8bed Check the aa_range before calculating the ellipse distance.
* | |   20b3e2d1 Auto merge of #2164 - lsalzman:fix-embedded-bitmaps, r=pcwalton
|\ \ \
| * | | 45c83c5a fix handling of embedded bitmaps in FreeType font backend
| | |/
| |/|
* | |   dcb71e94 Auto merge of #2161 - Eijebong:bump, r=glennw
|\ \ \
| |/ /
|/| |
| * | 2d5bb88c Bump lazy_static to 1.0
* | |   c76f272e Auto merge of #2156 - mrobinson:clip-scroll-tree-opt-2, r=glennw
|\ \ \
| |/ /
|/| |
| * | 2901a69a Remove some unused code from util.rs
| * | 1751eccd Extract bounding rect calculation from TransformedRect
| * | 41c5eb19 Use transform_rect in prim_store.rs
| * | f9f2b7df Refactor ClipScrollTree::update
|/ /
* |   5e6494c0 Auto merge of #2150 - mephisto41:chain-filter, r=glennw
|\ \
| * | c378cf9a Reverse apply filters.
|  /
* |   c966fdba Auto merge of #2147 - kvark:pbo-style, r=glennw
|\ \
| * | 61f59d8a UploadMethod configuration
| * | e2d18711 TextureUploader abstraction
|  /
* |   d1feb4f5 Auto merge of #2146 - glennw:b10, r=kvark
|\ \
| * | b562ddf6 Convert rectangle from prim to brush shader and support segments.
* | |   7d55afc0 Auto merge of #2155 - lsalzman:mac-bold, r=glennw
|\ \ \
| |_|/
|/| |
| * | f56f9b2d fake bold for Mac font backend
| |/
* |   3aa47112 Auto merge of #2152 - lsalzman:allow-smoothing, r=mstange
|\ \
| |/
|/|
| * f4acfb68 don't override Mac operating system AA settings
* bcdcd6aa Auto merge of #2142 - mrobinson:clip-scroll-tree-opt-1, r=glennw
* f6783f1b Invert ClipScrollNode transformation in the vertex shader
* b5fc728a Reserve appropriate capacity for GPU Frame data

Comment 6

[Asif Youssuff]

@ Kartikaya -- yes, it does seem like the steps are dependent on the width of the awesomebar. 

Here's another (shorter) URL that works for me - https://duckduckgo.com/?q=a&ia=web Oddly, https://duckduckgo.com/settings doesn't work. It seems to be dependent on the characters in the entered URL somehow. https://duckduckgo.com/?a also doesn't work to reproduce.

Comment 7

[Asif Youssuff]

https://www.boringcompany.com/hat works to repro
https://www.boringcompany.com does not. 

https://aeon.co/science does not work.
https://aeon.co/ does not work
https://aeon.co/donate does not work
https://aeon.co/culture/travel does not work
https://aeon.co/culture/food-drink does not work
https://aeon.co/culture/architecture-landscape reproduces the issue
https://aeon.co/culture/cultures-languages reproduces

Comment 8

[Ethan Lin[:ethlin]]

I cannot reproduce. But the fix in bug 1424673 might be related.

Comment 9

[Asif Youssuff]

This seems fixed in the latest nightly.

Unfortunately, trying to find a fix gets stuck when switching to autoland in mozregression:

mozregression --bad 2018-01-08 --find-fix --arg="https://bugzilla.mozilla.org/show_bug.cgi?id=1421696" --pref "layers.acceleration.force-enabled:true" "gfx.webrender.enabled:true" "browser.uidensity:1"

<snip>

 1:43.72 INFO: Narrowed inbound regression window from [05fed903, 7c9de87c] (3 builds) to [05fed903, 42486026] (2 builds) (~1 steps left)
 1:43.72 INFO: No more inbound revisions, bisection finished.
 1:43.72 INFO: First good revision: 4248602674ff589f368a4b868fa4743a033640e4
 1:43.72 INFO: Last bad revision: 05fed903f40f05fd923ba2137696ecc1fa0bafe6
 1:43.72 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=05fed903f40f05fd923ba2137696ecc1fa0bafe6&tochange=4248602674ff589f368a4b868fa4743a033640e4

 1:44.91 INFO: ************* Switching to autoland by process of elimination (no branch detected in commit message)
 1:44.91 INFO: Getting autoland builds between a66b031b9f6bb1b259be74ea80802229a6d7a187 and 4248602674ff589f368a4b868fa4743a033640e4
 1:45.30 ERROR: The url u'https://hg.mozilla.org/integration/autoland/json-pushes?fromchange=4248602674ff589f368a4b868fa4743a033640e4&tochange=a66b031b9f6bb1b259be74ea80802229a6d7a187' contains no pushlog. Maybe use another range ?

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Seems probable that this was fixed by bug 1426116 then.

Comment 11

[Catalin Sasca, Desktop Test Engineering [:csasca]]

I was not able to reproduce this issue on Firefox 59.0a1(2018-01-05) under Linux 16.04 x64 or Windows 10 x64 using the steps from comment 0 and additional links from comment 7, and so I'm not able to confirm the fix on the latest builds.

Asif Youssuf, please let me know if you can still reproduce this issue on the affected builds. Also, can you please provide the updated STR if the issue is still reproducible on your side?

Comment 12

[Asif Youssuff]

Sasca, Not sure why, but I can't reproduce the issue either in the previously affected builds, perhaps my graphics drivers were updated, changing the way Firefox works. In any case, it is still working as expected in the latest builds.

Comment 13

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Thank you Asif Youssuff for the info. I have also ran some tests under Ubuntu 16.04 (x64) on Firefox 59 RC and on Firefox 60.0a1 (2018-03-11) and everything works as expected. Taking this in consideration and Comment 12, I'm marking this issue as Verified-Fixed.