143072 - No way to close the Properties-window without canceling the download

Status: VERIFIED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[Adrian Ulrich]

1) Download something
2) in the (new-)Download-manager, select the item wich you are downloading and
hit the 'Properties' button..

-> a new window opens
BUT: you can't close this window: there is now close window, just pause / cancel
.. if you hit the close-button of your windowmanager, the download gets canceled

Build 2002050323 on linux

Comment 1

[Erin Dalzell]

This is really annoying the first time you discover this. I was 90% through a
large 100MB download when I tried to close the properties window. It killed my
download and I couldn't resume it!! Arrrgh!

Maybe the properties button could be disabled until this is fixed?

Comment 2

[R.K.Aa.]

*** Bug 148635 has been marked as a duplicate of this bug. ***

Comment 3

[R.K.Aa.]

*** Bug 152091 has been marked as a duplicate of this bug. ***

Comment 4

[Blake Ross]

Unexpected data loss, pretty easy fix, let's see what nav triage thinks...

Comment 5

[Ricky Webb]

Opps, I put Mozilla1.0.1+ instead of Mozilla1.0.1 on my duped bug...sorry.

Comment 6

[Samir Gehani]

Nav triage team: nsbeta1+, adt2

Comment 7

[Blake Ross]

Attachment: patch

Comment 8

[Bill Law]

Comment on attachment 89311 [details] [diff] [review]
patch

r=law

Does this leave Mac users out of luck?	Or can they use command-W to close the
dialog without cancelling? (this question doesn't affect this patch, I'm just
curious)

Comment 9

[Adrian Ulrich]

Just noticed that the Downloadmanager is broken in build 20020626 on OSX ->
Downloads, but doesn't show any items..


Bill:
If the downloadmanager is disabled and you use the Progress window (The window
that would appear when we hit Properties in the DL-Manager, if it would work in
20020626), there is no way to close it:
- Close button is disabled
- Command W does nothing

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 89311 [details] [diff] [review]
patch

sr=[e-mail]

Comment 11

[Ricky Webb]

Do you think this will make the 1.0 branch before 1.0.1?

Comment 12

[Blake Ross]

Fixed on trunk.  As for mac, the problem is that we open the progress window as
a dialog and not a window, so the standard window controls aren't there.  I
can't control that, nsIProgressDialog does. I will file a new bug.

Comment 13

[sairuh (rarely reading bugmail)]

i'm guessing this was fixed only on the trunk, not the branch: removing
fixed1.0.1 kw, since today's linux trunk (2002.07.08.08 comm) build appears
fixed, but the linux branch (2002.07.08.07-1.0 comm) does not.

tested by setting the "open dl mgr window" pref ON, and clicking the close
widget in the Properties window while download is in progress.

i'll check this out on win2k and mac once i get those trunk bits installed...

re comment 9 about dl mgr not showing entries on Mac OS X: i filed bug 155426.

Comment 14

[sairuh (rarely reading bugmail)]

vrfy'd fixed on win2k using 2002.07.08.08 trunk commercial bits.

bug 155426 still blocks any dl mgr testing on the Mac OS X trunk.

Comment 15

[sairuh (rarely reading bugmail)]

double-checked on OS X, and as on OS 9 (comment 12), there isn't a window
control to close the progress dlg (the close and max buttons are greyed-out, and
only have access to the minimize one).

so, i'll mark this verified fixed (TRUNK), since mac is a separate issue.

Comment 16

[scottputterman]

adding adt1.0.1-.  Let's get this in the next release.

Comment 17

[Blake Ross]

*** Bug 153702 has been marked as a duplicate of this bug. ***

Comment 18

[Olav Vitters]

*** Bug 164878 has been marked as a duplicate of this bug. ***

Comment 19

[R.K.Aa.]

*** Bug 197634 has been marked as a duplicate of this bug. ***